[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245843#comment-17245843 ] Mikhail Khludnev commented on SOLR-8673:

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245758#comment-17245758 ] ASF subversion and git services commented on SOLR-8673: --- Commit

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245647#comment-17245647 ] Mikhail Khludnev commented on SOLR-8673: Sorry to hear that, @thekabdude. I'm on it. >

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245498#comment-17245498 ] Tim Owen commented on SOLR-8673: Good point, yes I found a similar message when I first ported this patch

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245398#comment-17245398 ] Timothy Potter commented on SOLR-8673: -- [~mkhl] it looks like this commit to 8x is causing precommit

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245130#comment-17245130 ] ASF subversion and git services commented on SOLR-8673: --- Commit

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244989#comment-17244989 ] ASF subversion and git services commented on SOLR-8673: --- Commit

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-01 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241456#comment-17241456 ] Tim Owen commented on SOLR-8673: Hi, yes sure (I prefer GH PRs to patch files).. see

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-29 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240343#comment-17240343 ] Mikhail Khludnev commented on SOLR-8673: [~TimOwen], I'm steadily getting back to development. I

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-06 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227421#comment-17227421 ] Tim Owen commented on SOLR-8673: Good idea, I've updated my patch with a new test - it simply confirms

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226927#comment-17226927 ] Mikhail Khludnev commented on SOLR-8673: I think it's good. However, it's worth to add a dummy

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-05 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226628#comment-17226628 ] Tim Owen commented on SOLR-8673: I've attached a patch that I used and it allowed me to port our custom

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-04 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225955#comment-17225955 ] Tim Owen commented on SOLR-8673: Hi Christine! Yes, it is FacetContext.. I am going to do that today, in

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-04 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225936#comment-17225936 ] Christine Poerschke commented on SOLR-8673: --- {quote}... work done in SOLR-14482 has extracted

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-11-03 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225573#comment-17225573 ] Tim Owen commented on SOLR-8673: No, still can't define new aggregates in custom code. That class is now

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-05-29 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119612#comment-17119612 ] Tim Owen commented on SOLR-8673: Yes this is annoying, I was mid-way through writing a custom aggregate