[
https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-4048.
----------------------------------
Fix Version/s: 4.0-BETA
Resolution: Duplicate
> Move getLines out of ResourceLoader and require Charset
> -------------------------------------------------------
>
> Key: LUCENE-4048
> URL: https://issues.apache.org/jira/browse/LUCENE-4048
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Chris Male
> Priority: Major
> Fix For: 4.0-BETA
>
> Attachments: LUCENE-4048.patch, LUCENE-4048.patch
>
>
> {{ResourceLoader.getLines()}} is only used by analysis factories.
> {{SolrResourceLoader}}'s implementation does the job well and it's unlikely
> that another {{ResourceLoader}} implementation would handle it differently.
> We should extract the {{getLines()}} method out to
> {{AbstractAnalysisFactory}} so it can be used by the factories. Additionally
> we shouldn't assume the files are encoded in UTF-8, instead we should allow a
> Charset to be specified.
> This would take us one step closer to reducing the {{ResourceLoader}}
> interface just to what it says, a loader of resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
