benwtrent merged PR #12915:
URL: https://github.com/apache/lucene/pull/12915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1528440247
##
lucene/CHANGES.txt:
##
@@ -174,12 +174,14 @@ API Changes
New Features
-
-
* GITHUB#12679: Add support for similarity-based vector searches
benwtrent commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1528339145
##
lucene/CHANGES.txt:
##
@@ -174,12 +174,14 @@ API Changes
New Features
-
-
* GITHUB#12679: Add support for similarity-based vector
github-actions[bot] commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1907129523
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
dungba88 commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1882788058
I think it's good to go, but I don't have merge permission. Mike should be
able to help you, otherwise you can try notify the dev mailing list as
suggested by the bot
--
This is an
daixque commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1882633384
@mikemccand @dungba88 Let me ping. Do I still have anything to do for this
PR? If not, could you merge it?
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1880898815
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
daixque commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1860673133
> Looks great @daixque -- would you like to add a `lucene/CHANGES.txt` entry
dscribing this awesome new capability? Be sure to put it under the `9.10.0`
section since we can backport
mikemccand commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1860587667
Looks great @daixque -- would you like to add a `lucene/CHANGES.txt` entry
dscribing this awesome new capability? Be sure to put it under the `9.10.0`
section since we can backport
daixque commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1858684072
I did refactoring to apply a same kind of enhancement to Katakana filter as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1427647228
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -60,15 +60,13 @@ public
mikemccand commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1426601556
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -60,15 +60,13 @@ public
dungba88 commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1853744401
Besides the optimization of manipulating the internal byte[] directly, I
think this is good to go.
--
This is an automated message from the Apache Git Service.
To respond to the
mikemccand commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1424520399
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,65 @@
+package
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423583689
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,65 @@
+package org.apache.lucene.analysis.ja;
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423585285
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423575442
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423470044
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423469570
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423469570
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423469570
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423482123
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423470044
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423469570
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423402789
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423384044
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423383461
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,83 @@
+package org.apache.lucene.analysis.ja;
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423382747
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423381320
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423380431
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
dungba88 commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423380431
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
daixque commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1851177452
Hi @mikemccand and @kojisekig, thank you for your reviews.
I updated some codes along with the comments and add lines to module-info
and resources to make `gradle check` green.
--
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423277326
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseKatakanaUppercaseFilter.java:
##
@@ -0,0 +1,83 @@
+package org.apache.lucene.analysis.ja;
+
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423277099
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,65 @@
+package org.apache.lucene.analysis.ja;
daixque commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1423277455
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,65 @@
+package org.apache.lucene.analysis.ja;
+
kojisekig commented on PR #12915:
URL: https://github.com/apache/lucene/pull/12915#issuecomment-1851116639
From a Japanese perspective, the necessity sounds reasonable. Thank you for
the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message,
mikemccand commented on code in PR #12915:
URL: https://github.com/apache/lucene/pull/12915#discussion_r1422804214
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java:
##
@@ -0,0 +1,65 @@
+package
37 matches
Mail list logo
