HoustonPutman commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1936231183
So I just finished the 8.11.3 release, and had some problems with the
back-compat testing code. Obviously the ant/gradle switch and jdk versions
meant that I had to do a lot of it
s1monw commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1919215269
thanks everybody... I will go and backport this to 9.x as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
s1monw merged PR #13046:
URL: https://github.com/apache/lucene/pull/13046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1471723409
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
uschindler commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1471716431
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
uschindler commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1471695464
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
uschindler commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1917572859
There is no formatted() with locale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
s1monw commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1917508359
@uschindler I need to hear you speaking german to tell, you know that ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1917488764
> > > We should PnP this!
> >
> >
> > What on earth means PnP? Mike, check out this search:
https://www.google.com/search?q=pnp+acronym wikipedia FTW
>
> PnP =
mikemccand commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1917387757
> > We should PnP this!
>
> What on earth means PnP? Mike, check out this search:
https://www.google.com/search?q=pnp+acronym wikipedia FTW
PnP = progress not
uschindler commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1471018363
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
s1monw commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1916447395
> We should PnP this!
What on earth means PnP? Mike, check out this search:
https://www.google.com/search?q=pnp+acronym wikipedia FTW
--
This is an automated message from the
mikemccand commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1469886161
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestIndexUpgradeBackwardsCompatibility.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the
dweiss commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1915017690
Oh, one more problem is that you can't "see" the structure of tests before
you actually run them (in an IDE). Don't know how much of an issue this is in
practice but it's impossible to
dweiss commented on PR #13046:
URL: https://github.com/apache/lucene/pull/13046#issuecomment-1915011660
I like it. Whenever there is test repetition that can be driven by data, it
should be driven by data.
The only downside to using ParametersFactory is that it's something that is
jpountz commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1469520708
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBinaryBackwardsCompatibility.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software
s1monw commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1469520535
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestIndexUpgradeBackwardsCompatibility.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache
s1monw commented on code in PR #13046:
URL: https://github.com/apache/lucene/pull/13046#discussion_r1469519342
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestDVUpdateBackwardsCompatibility.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
18 matches
Mail list logo
