[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1391: SOLR-14014 Add a disable Admin UI Flag

2020-04-05 Thread GitBox
MarcusSorealheis commented on issue #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#issuecomment-609394891 @gerlowskija I believe all the changes here are made This is an

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-05 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r403686320 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[jira] [Commented] (SOLR-14386) Update Jetty to 9.4.27 and dropwizard-metrics version to 4.1.5

2020-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075829#comment-17075829 ] ASF subversion and git services commented on SOLR-14386: Commit

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1406: SOLR-14388: Remove references to rule-based replica placement in the ref guide

2020-04-05 Thread GitBox
ErickErickson opened a new pull request #1406: SOLR-14388: Remove references to rule-based replica placement in the ref guide URL: https://github.com/apache/lucene-solr/pull/1406 First cut of document changes. This is an

[jira] [Commented] (SOLR-14210) Introduce Node-level status handler for replicas

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075861#comment-17075861 ] Jan Høydahl commented on SOLR-14210: So I think I have addressed all comments. Planning to merge this

[GitHub] [lucene-solr] janhoy commented on issue #1387: SOLR-14210: Include replica health in healtcheck handler

2020-04-05 Thread GitBox
janhoy commented on issue #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#issuecomment-609438005 I think I have addressed all comments now? This is an

[GitHub] [lucene-solr] dsmiley opened a new pull request #1407: Use QueryUtils.combineQueryAndFilter more

2020-04-05 Thread GitBox
dsmiley opened a new pull request #1407: Use QueryUtils.combineQueryAndFilter more URL: https://github.com/apache/lucene-solr/pull/1407 and check query==MatchAllDocsQuery (minor & cheap optimization) I more thoroughly examined opportunities to use this new function and found them

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler

2020-04-05 Thread GitBox
janhoy commented on a change in pull request #1387: SOLR-14210: Include replica health in healtcheck handler URL: https://github.com/apache/lucene-solr/pull/1387#discussion_r403719563 ## File path: solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075863#comment-17075863 ] ASF subversion and git services commented on SOLR-14359: Commit

[jira] [Resolved] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14359. Resolution: Fixed > Admin UI has "Select an option" for collections and cores drop-downs. >

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075864#comment-17075864 ] ASF subversion and git services commented on SOLR-14359: Commit

[jira] [Commented] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075949#comment-17075949 ] Jan Høydahl commented on SOLR-14371: So I feel the current PR solves the intention of the issue, and

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML

2020-04-05 Thread GitBox
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-609394019 @shalinmangar another precommit failure unrelated to my code: ```check-licenses: [echo] License check under:

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403702846 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403703718 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403701699 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403701954 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403701483 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403702986 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403704846 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403703730 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403703871 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403704655 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403703688 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403702693 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java

[jira] [Resolved] (LUCENE-9060) Fix the files generated python scripts in lucene/util/packed to not use RamUsageEstimator.NUM_BYTES_INT

2020-04-05 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-9060. Resolution: Fixed Fixed in LUCENE-9080 > Fix the files generated python scripts in

[jira] [Commented] (SOLR-4457) Queries ending in question mark interpreted as wildcard

2020-04-05 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075833#comment-17075833 ] Erick Erickson commented on SOLR-4457: -- [~janhoy] Ran into this by accident, should we close it? >

[jira] [Commented] (SOLR-12741) Nuke rule based replica placement strategy in Lucene/Solr 8.0

2020-04-05 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075836#comment-17075836 ] Erick Erickson commented on SOLR-12741: --- Linking issues from the query: project = SOLR AND summary

[jira] [Commented] (SOLR-14347) Autoscaling placement wrong when concurrent replica placements are calculated

2020-04-05 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075774#comment-17075774 ] Shalin Shekhar Mangar commented on SOLR-14347: -- The PR is still open, can you please close

[jira] [Created] (SOLR-14388) Remove references to rule-based replica placement in the ref guide

2020-04-05 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14388: - Summary: Remove references to rule-based replica placement in the ref guide Key: SOLR-14388 URL: https://issues.apache.org/jira/browse/SOLR-14388 Project: Solr

[jira] [Commented] (SOLR-4457) Queries ending in question mark interpreted as wildcard

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075843#comment-17075843 ] Jan Høydahl commented on SOLR-4457: --- Perhaps we should document somewhere that applications must strip

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403700502 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403814196 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403751529 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-05 Thread GitBox
dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403812199 ## File path: lucene/core/src/java/org/apache/lucene/index/FlushPolicy.java ## @@ -52,38

[jira] [Commented] (SOLR-12067) AutoAddReplicas default 30 second wait time is too low

2020-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075997#comment-17075997 ] ASF subversion and git services commented on SOLR-12067: Commit

[jira] [Resolved] (SOLR-12720) Remove autoReplicaFailoverWaitAfterExpiration in Solr 8.0

2020-04-05 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar resolved SOLR-12720. -- Assignee: Shalin Shekhar Mangar Resolution: Fixed Thanks

[jira] [Commented] (SOLR-12720) Remove autoReplicaFailoverWaitAfterExpiration in Solr 8.0

2020-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076001#comment-17076001 ] ASF subversion and git services commented on SOLR-12720: Commit

[jira] [Commented] (SOLR-12720) Remove autoReplicaFailoverWaitAfterExpiration in Solr 8.0

2020-04-05 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075999#comment-17075999 ] Shalin Shekhar Mangar commented on SOLR-12720: -- The commit for this issue used the wrong

[jira] [Commented] (SOLR-12720) Remove autoReplicaFailoverWaitAfterExpiration in Solr 8.0

2020-04-05 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076020#comment-17076020 ] Marcus Eagan commented on SOLR-12720: - No problem. Thank you! > Remove