[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296446#comment-17296446 ] ASF subversion and git services commented on SOLR-15154: Commit

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296463#comment-17296463 ] ASF subversion and git services commented on SOLR-15154: Commit

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100517 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -67,14 +66,15 @@

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100307 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -67,14 +66,15 @@

[GitHub] [lucene-site] janhoy commented on pull request #42: fix the example command

2021-03-05 Thread GitBox
janhoy commented on pull request #42: URL: https://github.com/apache/lucene-site/pull/42#issuecomment-791250939 Actually when using venv, the `env/bin/activate` command will make `pip` an alias to `pip3` for you, so the end result is the same. But if you have chosen to work with your

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter opened a new pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457 # Description `ngram` is expensive (O(N*M*M)) but we can make it O(N) by precompiling some automatons, specialized for the case `n=3` and `weighted=false` # Solution

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588099915 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -1025,6 +1025,7 @@ private int

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588101697 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -374,14 +373,9 @@ private

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100894 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -89,7 +89,8 @@ }

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588101236 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -152,7 +153,7 @@ private void

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588105332 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to

[jira] [Commented] (SOLR-15217) rename shardsWhitelist and use it more broadly

2021-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295944#comment-17295944 ] Jan Høydahl commented on SOLR-15217: +1. Please consider adding a simple code somewhere that prints

[GitHub] [lucene-solr] rmuir commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
rmuir commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588280433 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to the

[jira] [Created] (LUCENE-9825) Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9825: Summary: Hunspell: reverse the "words" trie for faster word lookup/suggestions Key: LUCENE-9825 URL: https://issues.apache.org/jira/browse/LUCENE-9825 Project:

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588288024 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to

[jira] [Assigned] (SOLR-15189) Tracking downloads on new Solr site

2021-03-05 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch reassigned SOLR-15189: Assignee: Alexandre Rafalovitch > Tracking downloads on new Solr site >

[jira] [Commented] (SOLR-15189) Tracking downloads on new Solr site

2021-03-05 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296015#comment-17296015 ] Alexandre Rafalovitch commented on SOLR-15189: -- I'll try to dig into this over the weekend.

[jira] [Created] (SOLR-15218) check failed on AArch64, Fedora 33

2021-03-05 Thread Lutz Weischer (Jira)
Lutz Weischer created SOLR-15218: Summary: check failed on AArch64, Fedora 33 Key: SOLR-15218 URL: https://issues.apache.org/jira/browse/SOLR-15218 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] rmuir commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
rmuir commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588317811 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to the

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296033#comment-17296033 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296036#comment-17296036 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296039#comment-17296039 ] ASF subversion and git services commented on SOLR-15193: Commit

[GitHub] [lucene-solr] donnerpeter commented on pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791448721 The latter is ~10% faster, so there's some difference. `RunAutomaton.step` has a constant-time array access branch, and it's taken quite often, it seems. On

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296041#comment-17296041 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296043#comment-17296043 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296042#comment-17296042 ] ASF subversion and git services commented on SOLR-15193: Commit

[GitHub] [lucene-solr] rmuir commented on a change in pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
rmuir commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588339682 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to the

[jira] [Created] (SOLR-15219) TestPointFields.testIntPointFieldMultiValuedRangeFacet fails for seed

2021-03-05 Thread David Smiley (Jira)
David Smiley created SOLR-15219: --- Summary: TestPointFields.testIntPointFieldMultiValuedRangeFacet fails for seed Key: SOLR-15219 URL: https://issues.apache.org/jira/browse/SOLR-15219 Project: Solr

[GitHub] [lucene-solr] donnerpeter commented on pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
donnerpeter commented on pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791466479 Thanks for the suggestion, but it works on code points as well, which I'd prefer to leave out for now. On Fri, 5 Mar 2021 at 15:35, Robert Muir wrote: >

[GitHub] [lucene-solr] rmuir commented on pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
rmuir commented on pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791471797 > The latter is ~10% faster, so there's some difference. `RunAutomaton.step` has a constant-time array access branch, and it's taken quite often, it seems. good, thanks

[GitHub] [lucene-solr] rmuir merged pull request #2457: LUCENE-9824: Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread GitBox
rmuir merged pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9824) Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9824. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell suggestions: speed up ngram

[jira] [Commented] (LUCENE-9824) Hunspell suggestions: speed up ngram score calculation for each dictionary entry

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296071#comment-17296071 ] ASF subversion and git services commented on LUCENE-9824: - Commit

[GitHub] [lucene-solr] dsmiley opened a new pull request #2458: SOLR-15215: SolrJ: Remove Netty dependency

2021-03-05 Thread GitBox
dsmiley opened a new pull request #2458: URL: https://github.com/apache/lucene-solr/pull/2458 Netty is an *optional* dependency of Zookeeper; one must opt-in to use it. Netty remains a solr-core dependency transitively via Hadoop/HDFS.

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter opened a new pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459 # Description FST lookup and especially traversal are too slow # Solution Replace FST with a same-shaped data structure, but with nodes referring to their

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588370160 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -91,14 +90,8 @@ */ ArrayList

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588372773 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -1275,76 +1258,6 @@ boolean

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588371507 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -272,36 +264,27 @@ int formStep() {

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on a change in pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588374683 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/ModifyingSuggester.java ## @@ -234,6 +234,8 @@ private void

[GitHub] [lucene-solr] dsmiley opened a new pull request #2460: SOLR-15219: Fix TestPointFields integer overflow

2021-03-05 Thread GitBox
dsmiley opened a new pull request #2460: URL: https://github.com/apache/lucene-solr/pull/2460 And also restore it's getRandomInts(..,..,bound) semantics to what it was -- positive or negative random values. https://issues.apache.org/jira/browse/SOLR-15219 @madrob about a year

[GitHub] [lucene-solr] janhoy commented on pull request #2458: SOLR-15215: SolrJ: Remove Netty dependency

2021-03-05 Thread GitBox
janhoy commented on pull request #2458: URL: https://github.com/apache/lucene-solr/pull/2458#issuecomment-791505707 I put them in https://issues.apache.org/jira/browse/SOLR-13665. And the reason was to enable secure connections with Zookeeper. * To be able to use secure solr-zk

[GitHub] [lucene-solr] madrob commented on pull request #2460: SOLR-15219: Fix TestPointFields integer overflow

2021-03-05 Thread GitBox
madrob commented on pull request #2460: URL: https://github.com/apache/lucene-solr/pull/2460#issuecomment-791515684 I suspect that my change should have masked the bug that you found here, so I'm not exactly sure how you encountered this now, but this change looks fine.

[GitHub] [lucene-solr] dsmiley opened a new pull request #2461: SOLR-2852: SolrJ: remove Woodstox dependency

2021-03-05 Thread GitBox
dsmiley opened a new pull request #2461: URL: https://github.com/apache/lucene-solr/pull/2461 It was never truly required there. Pervasive use of "javabin" reduces the need to care about client-side XML speed. Better to reduce dependencies and let clients use the libs they want.

[GitHub] [lucene-solr] dsmiley commented on pull request #2460: SOLR-15219: Fix TestPointFields integer overflow

2021-03-05 Thread GitBox
dsmiley commented on pull request #2460: URL: https://github.com/apache/lucene-solr/pull/2460#issuecomment-791524076 I hear you but the test method that was broken didn't use that particular method, so it didn't matter. I temporarily inserted an "assert false;" to assure myself of this

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2442: SOLR-15205: don't mention (deprecated) CloudSolrClient.setIdField in javadocs

2021-03-05 Thread GitBox
cpoerschke commented on a change in pull request #2442: URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588447559 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -91,6 +91,12 @@ import static

[GitHub] [lucene-solr] rmuir commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
rmuir commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791536656 I like the idea, optimize for the operations hunspell needs to do. do you happen to have any more details on the memory usage increase (e.g. by language)? I imagine things

[GitHub] [lucene-solr] donnerpeter commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791543521 The largest dictionaries in my collection: el_GR: 1.7 MB -> 11.1 MB gd: 14.5 MB -> 18.3 MB fy: 36.7 MB -> 39.3 MB rw: remains 18.8 MB (because it's all

[GitHub] [lucene-solr] donnerpeter edited a comment on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter edited a comment on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791543521 The largest dictionaries in my collection: el_GR: 1.7 MB -> 11.1 MB gd: 14.5 MB -> 18.3 MB fy: 36.7 MB -> 39.3 MB rw: remains 18.8 MB (because it's all

[jira] [Created] (SOLR-15220) Json faceting allows val and count as stat/subfacet names

2021-03-05 Thread Tim Owen (Jira)
Tim Owen created SOLR-15220: --- Summary: Json faceting allows val and count as stat/subfacet names Key: SOLR-15220 URL: https://issues.apache.org/jira/browse/SOLR-15220 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-15220) Json faceting allows val and count as stat/subfacet names

2021-03-05 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296185#comment-17296185 ] Tim Owen commented on SOLR-15220: - Example in a non-distributed search {noformat} { facet: { authors: {

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2442: SOLR-15205: don't mention (deprecated) CloudSolrClient.setIdField in javadocs

2021-03-05 Thread GitBox
dsmiley commented on a change in pull request #2442: URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588505022 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -91,6 +91,12 @@ import static

[GitHub] [lucene-solr] rmuir commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
rmuir commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791574562 greek dictionary has `828806` words, so the hash table alone is 3.2MB, right? as far as encoding of actual words (`n * VINT: the word form data`), maybe it is possible

[jira] [Commented] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296241#comment-17296241 ] David Smiley commented on SOLR-15215: - See [~janhoy] comment on the PR --

[GitHub] [lucene-solr] rmuir commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
rmuir commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791585657 For greek, if you analyze the distribution of dictionary (I use https://scripts.sil.org/UnicodeCharacterCount ), you can see that smallest character in the whole dictionary

[GitHub] [lucene-solr] rmuir commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
rmuir commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791593379 a lot of these dictionaries are encoded in legacy charsets which explains why they conform so well to their unicode block, e.g. zero stray ASCII or chinese or whatever in the

[jira] [Commented] (SOLR-2852) SolrJ doesn't need woodstox jar

2021-03-05 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296253#comment-17296253 ] Mike Drob commented on SOLR-2852: - Does this mean that SolrJ clients will not be able to read xml

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #228: Handle dependency licenses correctly

2021-03-05 Thread GitBox
HoustonPutman commented on issue #228: URL: https://github.com/apache/lucene-solr-operator/issues/228#issuecomment-791601700 Reached out to legal, asking for guidance here. [LEGAL-562](https://issues.apache.org/jira/browse/LEGAL-562) I explained that we planned to use

[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #232: Add note about versions supporting log4j.xml

2021-03-05 Thread GitBox
HoustonPutman commented on pull request #232: URL: https://github.com/apache/lucene-solr-operator/pull/232#issuecomment-791603218 I think it's good to go! This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] donnerpeter commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791605098 A great idea about the base char! It's much simpler than what I had in mind if Greek becomes a problem :) Should I do this in this PR or in another one?

[jira] [Commented] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-05 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296270#comment-17296270 ] Mike Drob commented on SOLR-15215: -- Agree with Jan, I'd like to see this available as a package before

[jira] [Commented] (SOLR-2852) SolrJ doesn't need woodstox jar

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296269#comment-17296269 ] David Smiley commented on SOLR-2852: It does *not* mean that.  The JDK has had an XML parser since JDK

[jira] [Commented] (SOLR-14660) Migrating HDFS into a package

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296274#comment-17296274 ] David Smiley commented on SOLR-14660: - Correction: Netty will stay in Solr-core for the foreseeable

[GitHub] [lucene-solr] dsmiley merged pull request #2460: SOLR-15219: Fix TestPointFields integer overflow

2021-03-05 Thread GitBox
dsmiley merged pull request #2460: URL: https://github.com/apache/lucene-solr/pull/2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-15219) TestPointFields.testIntPointFieldMultiValuedRangeFacet fails for seed

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296275#comment-17296275 ] ASF subversion and git services commented on SOLR-15219: Commit

[jira] [Commented] (SOLR-15219) TestPointFields.testIntPointFieldMultiValuedRangeFacet fails for seed

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296278#comment-17296278 ] ASF subversion and git services commented on SOLR-15219: Commit

[jira] [Resolved] (SOLR-15219) TestPointFields.testIntPointFieldMultiValuedRangeFacet fails for seed

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15219. - Fix Version/s: 8.9 Resolution: Fixed >

[GitHub] [lucene-solr-operator] madrob merged pull request #232: Add note about versions supporting log4j.xml

2021-03-05 Thread GitBox
madrob merged pull request #232: URL: https://github.com/apache/lucene-solr-operator/pull/232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] tflobbe merged pull request #2445: SOLR-15154: Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread GitBox
tflobbe merged pull request #2445: URL: https://github.com/apache/lucene-solr/pull/2445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296283#comment-17296283 ] ASF subversion and git services commented on SOLR-15154: Commit

[GitHub] [lucene-solr] donnerpeter commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
donnerpeter commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791614662 I've found a regression not covered by unit tests, will fix it (probably on Monday), please don't merge yet :)

[GitHub] [lucene-solr] rmuir commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-05 Thread GitBox
rmuir commented on pull request #2459: URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791621851 we can definitely do this stuff in another PR! I'm just throwing out wacky ideas to try to help out. This is

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2442: SOLR-15205: don't mention (deprecated) CloudSolrClient.setIdField in javadocs

2021-03-05 Thread GitBox
cpoerschke commented on a change in pull request #2442: URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588621150 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -91,6 +91,12 @@ import static

[GitHub] [lucene-solr] cpoerschke closed pull request #2442: SOLR-15205: don't mention (deprecated) CloudSolrClient.setIdField in javadocs

2021-03-05 Thread GitBox
cpoerschke closed pull request #2442: URL: https://github.com/apache/lucene-solr/pull/2442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (SOLR-15206) improve CoreContainer constructor javadocs

2021-03-05 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15206. Fix Version/s: 8.9 master (9.0) Resolution: Fixed >

[jira] [Resolved] (SOLR-15205) don't mention (deprecated) CloudSolrClient.setIdField in javadocs

2021-03-05 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15205. Resolution: Won't Do Based on https://github.com/apache/lucene-solr/pull/2442

[GitHub] [lucene-solr] cpoerschke commented on pull request #1693: SOLR-14607: LTR Query, timeAllowed parameter causes a timeout exception with no result

2021-03-05 Thread GitBox
cpoerschke commented on pull request #1693: URL: https://github.com/apache/lucene-solr/pull/1693#issuecomment-791639415 > @cpoerschke Please help to look at this PR. Hello @limingnihao, thanks for this pull request and the 'ping' on it! Just wanted to let you know that I spent some

[jira] [Updated] (LUCENE-9793) Measure check/precommit aggregate task wall time

2021-03-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9793: Attachment: screenshot-1.png > Measure check/precommit aggregate task wall time >

[jira] [Commented] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296305#comment-17296305 ] Jan Høydahl commented on SOLR-15215: Let’s make a plug-in/package to wrap those jars, and remove the

[GitHub] [lucene-solr] madrob opened a new pull request #2462: SOLR-14759 fix tests that need on lucene test-src

2021-03-05 Thread GitBox
madrob opened a new pull request #2462: URL: https://github.com/apache/lucene-solr/pull/2462 Rewrite one, ignore the other two. This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (LUCENE-9793) Measure check/precommit aggregate task wall time

2021-03-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296308#comment-17296308 ] Dawid Weiss commented on LUCENE-9793: - !screenshot-1.png! > Measure check/precommit aggregate

[jira] [Comment Edited] (LUCENE-9793) Measure check/precommit aggregate task wall time

2021-03-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296308#comment-17296308 ] Dawid Weiss edited comment on LUCENE-9793 at 3/5/21, 7:59 PM: --

[jira] [Assigned] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-15215: --- Assignee: (was: David Smiley) While I think that'd be a fine thing, we don't have that

[jira] [Created] (SOLR-15221) Distributed commit errors are not propagated to the initiating client

2021-03-05 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-15221: - Summary: Distributed commit errors are not propagated to the initiating client Key: SOLR-15221 URL: https://issues.apache.org/jira/browse/SOLR-15221 Project: Solr

[jira] [Updated] (SOLR-15221) Distributed commit errors are not propagated to the initiating client

2021-03-05 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-15221: -- Attachment: SOLR-15221-initial-tests.patch > Distributed commit errors are not propagated to

[jira] [Commented] (SOLR-15221) Distributed commit errors are not propagated to the initiating client

2021-03-05 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296329#comment-17296329 ] Michael Gibney commented on SOLR-15221: --- I was initially (and still am) inclined to think that this

[jira] [Created] (SOLR-15222) Solr should not auto-create the "userfiles" dir

2021-03-05 Thread David Smiley (Jira)
David Smiley created SOLR-15222: --- Summary: Solr should not auto-create the "userfiles" dir Key: SOLR-15222 URL: https://issues.apache.org/jira/browse/SOLR-15222 Project: Solr Issue Type:

[GitHub] [lucene-solr] HoustonPutman closed pull request #2454: Test docker change, just to see if the docker github action works

2021-03-05 Thread GitBox
HoustonPutman closed pull request #2454: URL: https://github.com/apache/lucene-solr/pull/2454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2463: Docker build perms

2021-03-05 Thread GitBox
HoustonPutman opened a new pull request #2463: URL: https://github.com/apache/lucene-solr/pull/2463 There is currently an issue on the Ubuntu 20.04 github runner, with incorrect ownership being set for the `/var/solr` directory in the docker image.

[jira] [Commented] (SOLR-15215) SolrJ: Remove needless Netty dependency

2021-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296348#comment-17296348 ] Jan Høydahl commented on SOLR-15215: Ok, if you're leaving netty in solr-core then ZK SSL will still

[jira] [Created] (SOLR-15223) Deprecate HttpSolrClient, mark httpclient as "optional" in SolrJ

2021-03-05 Thread David Smiley (Jira)
David Smiley created SOLR-15223: --- Summary: Deprecate HttpSolrClient, mark httpclient as "optional" in SolrJ Key: SOLR-15223 URL: https://issues.apache.org/jira/browse/SOLR-15223 Project: Solr

[jira] [Updated] (SOLR-15223) Deprecate HttpSolrClient, mark httpcomponents dep as "optional" in SolrJ

2021-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15223: Fix Version/s: master (9.0) Summary: Deprecate HttpSolrClient, mark httpcomponents dep as

[jira] [Commented] (SOLR-15045) Commit through curl command is causing delay in issuing commit

2021-03-05 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296373#comment-17296373 ] Michael Gibney commented on SOLR-15045: --- fwiw, a more descriptive title for this issue might have

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #231: Add conditional dependency for zk-operator helm chart

2021-03-05 Thread GitBox
HoustonPutman commented on a change in pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#discussion_r588764883 ## File path: helm/solr-operator/Chart.yaml ## @@ -95,4 +95,10 @@ annotations: name: "example" numThreads: 4

[GitHub] [lucene-solr] HoustonPutman merged pull request #2463: Install ACL package for Solr Docker tests Github action

2021-03-05 Thread GitBox
HoustonPutman merged pull request #2463: URL: https://github.com/apache/lucene-solr/pull/2463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296389#comment-17296389 ] ASF subversion and git services commented on SOLR-15154: Commit

[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

2021-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296388#comment-17296388 ] ASF subversion and git services commented on SOLR-15154: Commit

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2021-03-05 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296407#comment-17296407 ] Mark Robert Miller commented on SOLR-14788: --- A final update: