[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447673#comment-17447673 ] Greg Miller commented on LUCENE-10250: -- {quote}I think it would be good to turn the problem

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447683#comment-17447683 ] Robert Muir commented on LUCENE-10250: -- If you take the solr approach #1 from that page listed,

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format in future release, we moved them

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[GitHub] [lucene] rmuir opened a new pull request #465: LUCENE-10243: increase unicode versions of tokenizers to 12.1

2021-11-22 Thread GitBox
rmuir opened a new pull request #465: URL: https://github.com/apache/lucene/pull/465 Increase the unicode versions of our tokenizers from `9` to `12.1`. Modify jflex grammars appropriately for changes to UAX#29 between these versions. Modify/regenerate conformance tests for changes

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447714#comment-17447714 ] Robert Muir commented on LUCENE-10250: -- And in case you are curious, that default implementation

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Commented] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447741#comment-17447741 ] Robert Muir commented on LUCENE-10243: -- OK, I see my main problem with the generated conformance

[jira] [Created] (LUCENE-10252) ValueSource.asDoubleValues shouldn't fetch score

2021-11-22 Thread David Smiley (Jira)
David Smiley created LUCENE-10252: - Summary: ValueSource.asDoubleValues shouldn't fetch score Key: LUCENE-10252 URL: https://issues.apache.org/jira/browse/LUCENE-10252 Project: Lucene - Core

[jira] [Created] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Marc D'Mello (Jira)
Marc D'Mello created LUCENE-10250: - Summary: Add hierarchical labels to SSDV facets Key: LUCENE-10250 URL: https://issues.apache.org/jira/browse/LUCENE-10250 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447645#comment-17447645 ] Greg Miller commented on LUCENE-10250: -- I can't think of any reason off the top of my head that

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447715#comment-17447715 ] Marc D'Mello commented on LUCENE-10250: --- I'll take a look at the code that you guys pointed to.

[jira] [Commented] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447730#comment-17447730 ] Robert Muir commented on LUCENE-10243: -- OK, I looked at this in more detail. Bumped to 10, tests

[jira] [Commented] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447775#comment-17447775 ] Feng Guo commented on LUCENE-10233: --- Hi [~jpountz]. I'm still trying some optimization for the

[GitHub] [lucene] rmuir commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
rmuir commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754721280 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -720,9 +745,9 @@ long addNode(FSTCompiler fstCompiler,

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447712#comment-17447712 ] Robert Muir commented on LUCENE-10250: -- {quote} We would need a general way to determine the

[GitHub] [lucene] spike-liu opened a new pull request #464: LUCENE-10251: Add the compliant "Direct" doc-value format

2021-11-22 Thread GitBox
spike-liu opened a new pull request #464: URL: https://github.com/apache/lucene/pull/464 https://issues.apache.org/jira/browse/LUCENE-10251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[jira] [Updated] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] spike liu updated LUCENE-10251: --- Description: In an effort to keep the "Direct" doc-value format, which are used in our business

[GitHub] [lucene] rmuir commented on pull request #465: LUCENE-10243: increase unicode versions of tokenizers to 12.1

2021-11-22 Thread GitBox
rmuir commented on pull request #465: URL: https://github.com/apache/lucene/pull/465#issuecomment-976165792 I'm doing this with a few commits. For me, it makes sense to first bump the versions and the tests, then iterate on any grammar refactoring as separate changes (keeping the tests

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447679#comment-17447679 ] Marc D'Mello commented on LUCENE-10250: --- Thanks for the responses! So are you saying that instead

[jira] [Commented] (LUCENE-10252) ValueSource.asDoubleValues shouldn't fetch score

2021-11-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447782#comment-17447782 ] David Smiley commented on LUCENE-10252: --- I commented out putting the "scorer" key in this map and

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447710#comment-17447710 ] Greg Miller commented on LUCENE-10250: -- I took another look at the SSDV faceting code to try to

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447669#comment-17447669 ] Robert Muir commented on LUCENE-10250: -- I think it would be good to turn the problem around, e.g.

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447684#comment-17447684 ] Robert Muir commented on LUCENE-10250: -- And yes, to be clear, i'm proposing modifying the

[jira] [Created] (LUCENE-10251) Add the compliant "Direct" doc-value format

2021-11-22 Thread spike liu (Jira)
spike liu created LUCENE-10251: -- Summary: Add the compliant "Direct" doc-value format Key: LUCENE-10251 URL: https://issues.apache.org/jira/browse/LUCENE-10251 Project: Lucene - Core Issue

[GitHub] [lucene] rmuir commented on pull request #465: LUCENE-10243: increase unicode versions of tokenizers to 12.1

2021-11-22 Thread GitBox
rmuir commented on pull request #465: URL: https://github.com/apache/lucene/pull/465#issuecomment-976207389 So I think this is pretty close. We still "tweak" the UAX#29 by incorporating UTS#51 sequence grammars to deal with emoji. This difference (see "Instead of" in the grammar files for

[GitHub] [lucene] dweiss commented on a change in pull request #465: LUCENE-10243: increase unicode versions of tokenizers to 12.1

2021-11-22 Thread GitBox
dweiss commented on a change in pull request #465: URL: https://github.com/apache/lucene/pull/465#discussion_r754836089 ## File path: gradle/generation/icu.gradle ## @@ -283,35 +283,3 @@ configure(project(":lucene:analysis:common")) { regenerate.dependsOn

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Hendrik Muhs (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447253#comment-17447253 ] Hendrik Muhs commented on LUCENE-10247: --- POC: https://github.com/apache/lucene/pull/460  >

[GitHub] [lucene] hendrikmuhs opened a new pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs opened a new pull request #460: URL: https://github.com/apache/lucene/pull/460 See: https://issues.apache.org/jira/browse/LUCENE-10247 -- FST's use various tricks to reduce size. One more trick that can be added is using relative coding for the

[jira] [Created] (LUCENE-10248) Add SpanishPluralStemFilter

2021-11-22 Thread Xavier Sanchez Loro (Jira)
Xavier Sanchez Loro created LUCENE-10248: Summary: Add SpanishPluralStemFilter Key: LUCENE-10248 URL: https://issues.apache.org/jira/browse/LUCENE-10248 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-10200) Restructure and modernize the release artifacts

2021-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447281#comment-17447281 ] ASF subversion and git services commented on LUCENE-10200: -- Commit

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447323#comment-17447323 ] Dawid Weiss commented on LUCENE-10247: -- Sure, I'll take a look later. Multi-word suggestion

[GitHub] [lucene] hendrikmuhs commented on pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs commented on pull request #460: URL: https://github.com/apache/lucene/pull/460#issuecomment-975283052 Sorry, I somehow missed the `Draft` button, if a maintainer can turn this into draft, please do so. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] hendrikmuhs removed a comment on pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs removed a comment on pull request #460: URL: https://github.com/apache/lucene/pull/460#issuecomment-975283052 Sorry, I somehow missed the `Draft` button, if a maintainer can turn this into draft, please do so. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] xaviersanchez opened a new pull request #461: LUCENE-10248: Spanish Plural Stemmer

2021-11-22 Thread GitBox
xaviersanchez opened a new pull request #461: URL: https://github.com/apache/lucene/pull/461 # Description [Jira ticket](https://issues.apache.org/jira/browse/LUCENE-10248) Code for the Spanish Plural Stemmer. This is a new Spanish stemmer just for stemming plural to

[GitHub] [lucene] zacharymorn commented on a change in pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-11-22 Thread GitBox
zacharymorn commented on a change in pull request #418: URL: https://github.com/apache/lucene/pull/418#discussion_r754091056 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java ## @@ -441,6 +491,273 @@ public boolean

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447282#comment-17447282 ] Dawid Weiss commented on LUCENE-10247: -- Hi [~hendrikmuhs]! This sounds interesting - didn't look

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Hendrik Muhs (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447294#comment-17447294 ] Hendrik Muhs commented on LUCENE-10247: --- The paper is about re-arranging states, what I propose

[jira] [Created] (LUCENE-10249) Analysis factories shouldn't have Solr configuration instructions in their javadoc

2021-11-22 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-10249: -- Summary: Analysis factories shouldn't have Solr configuration instructions in their javadoc Key: LUCENE-10249 URL: https://issues.apache.org/jira/browse/LUCENE-10249

[jira] [Updated] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Hendrik Muhs (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hendrik Muhs updated LUCENE-10247: -- Description: FST's use various tricks to reduce size. One more trick that can be added is

[jira] [Created] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Hendrik Muhs (Jira)
Hendrik Muhs created LUCENE-10247: - Summary: Reduce FST size by using absolute and relative coding for target pointers Key: LUCENE-10247 URL: https://issues.apache.org/jira/browse/LUCENE-10247

[jira] [Commented] (LUCENE-10200) Restructure and modernize the release artifacts

2021-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447291#comment-17447291 ] ASF subversion and git services commented on LUCENE-10200: -- Commit

[jira] [Commented] (LUCENE-10200) Restructure and modernize the release artifacts

2021-11-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447380#comment-17447380 ] ASF subversion and git services commented on LUCENE-10200: -- Commit

[jira] [Reopened] (LUCENE-9820) Separate logic for reading the BKD index from logic to intersecting it.

2021-11-22 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera reopened LUCENE-9820: -- I am reopening the issue as I realised that we are not handling properly the case of pre-8.6

[GitHub] [lucene] iverase opened a new pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes

2021-11-22 Thread GitBox
iverase opened a new pull request #462: URL: https://github.com/apache/lucene/pull/462 In pre-8.6 indexes, high dimensional trees (numDims > 1) were constructed as fully balanced trees but the BKD reader always assumes that trees are unbalanced as it is the case from Lucene 8.6 onwards.

[jira] [Commented] (LUCENE-10249) Analysis factories shouldn't have Solr configuration instructions in their javadoc

2021-11-22 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447342#comment-17447342 ] Alan Woodward commented on LUCENE-10249: Here's a suggestions for a replacement javadoc, using

[jira] [Comment Edited] (LUCENE-10249) Analysis factories shouldn't have Solr configuration instructions in their javadoc

2021-11-22 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447342#comment-17447342 ] Alan Woodward edited comment on LUCENE-10249 at 11/22/21, 11:22 AM:

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-22 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r754297662 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -205,6 +215,43 @@ private FieldEntry

[GitHub] [lucene] dweiss commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
dweiss commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754558907 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/Util.java ## @@ -878,11 +878,20 @@ public static BytesRef toBytesRef(IntsRef input,

[GitHub] [lucene] dweiss commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
dweiss commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754563874 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/Outputs.java ## @@ -49,6 +49,20 @@ /** Encode an output value into a {@link DataOutput}. */

[GitHub] [lucene] cammiemw opened a new pull request #463: LUCENE-10157 - Added IndriOr, IndriWeightedSum, and IndriQueryParser

2021-11-22 Thread GitBox
cammiemw opened a new pull request #463: URL: https://github.com/apache/lucene/pull/463 # Description This pull request adds additional functionality from the Indri search engine (https://www.lemurproject.org/indri/) to lucene. The Indri AND operator was added in

[GitHub] [lucene] rmuir commented on pull request #461: LUCENE-10248: Spanish Plural Stemmer

2021-11-22 Thread GitBox
rmuir commented on pull request #461: URL: https://github.com/apache/lucene/pull/461#issuecomment-975876699 Hi @xaviersanchez, this contribution looks great. I'll do another pass on review and give some time for others to review as well. I did a little investigation at a

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447540#comment-17447540 ] Dawid Weiss commented on LUCENE-10247: -- It is a surprisingly short patch! This said, I don't

[GitHub] [lucene] hendrikmuhs commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754601969 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -1000,6 +1027,98 @@ private void writePresenceBits( assert bytePos -

[GitHub] [lucene] hendrikmuhs commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754601969 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -1000,6 +1027,98 @@ private void writePresenceBits( assert bytePos -

[GitHub] [lucene] hendrikmuhs commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
hendrikmuhs commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754601969 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -1000,6 +1027,98 @@ private void writePresenceBits( assert bytePos -

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Hendrik Muhs (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447609#comment-17447609 ] Hendrik Muhs commented on LUCENE-10247: --- Thanks for the 1st feedback. > and there are some typos

[GitHub] [lucene] dweiss commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
dweiss commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754613632 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -1000,6 +1027,98 @@ private void writePresenceBits( assert bytePos - dest

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447622#comment-17447622 ] Dawid Weiss commented on LUCENE-10247: -- I also wanted to say - kudos for taking a stab at this

[jira] [Commented] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447625#comment-17447625 ] Michael Sokolov commented on LUCENE-10247: -- As far as testing goes,

[jira] [Comment Edited] (LUCENE-10247) Reduce FST size by using absolute and relative coding for target pointers

2021-11-22 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447625#comment-17447625 ] Michael Sokolov edited comment on LUCENE-10247 at 11/22/21, 8:52 PM:

[GitHub] [lucene] msokolov commented on a change in pull request #460: LUCENE-10247 - reduce size of FSTs by relative coding

2021-11-22 Thread GitBox
msokolov commented on a change in pull request #460: URL: https://github.com/apache/lucene/pull/460#discussion_r754629656 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -720,9 +745,9 @@ long addNode(FSTCompiler fstCompiler,