dweiss commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156324489
Just wondering what the impact is going to be, that's all. Can the returned
order of documents from the (parallel) searcher be different? For score-sorted
cases it may not be a problem but
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554603#comment-17554603
]
Michael McCandless commented on LUCENE-10557:
-
Thanks [~tomoko] for driving this
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-10557:
Summary: Migrate to GitHub issue from Jira (was: Migrate to GitHub issue
from
mayya-sharipova commented on code in PR #947:
URL: https://github.com/apache/lucene/pull/947#discussion_r897925136
##
lucene/core/src/java/org/apache/lucene/codecs/lucene93/OffHeapVectorValues.java:
##
@@ -41,11 +42,11 @@ abstract class OffHeapVectorValues extends VectorValues
mikemccand commented on code in PR #922:
URL: https://github.com/apache/lucene/pull/922#discussion_r898026016
##
lucene/CHANGES.txt:
##
@@ -67,6 +67,8 @@ Other
* LUCENE-10493: Factor out Viterbi algorithm in Kuromoji and Nori to
analysis-common. (Tomoko Uchida)
+* Remove
mikemccand commented on PR #922:
URL: https://github.com/apache/lucene/pull/922#issuecomment-1156516445
Yeah I think these attributes of `FacetField.TYPE` are not used, but it is
trappy looking. This `TYPE` is really just a marker/singleton so
`FacetsConfig.build` can know which fields in
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554626#comment-17554626
]
Lu Xugang commented on LUCENE-10600:
{quote}SortedSetDocValues#docValueCount should be an int, not
[
https://issues.apache.org/jira/browse/LUCENE-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554640#comment-17554640
]
fang hou commented on LUCENE-10618:
---
hi [~jpountz] i'm new to lucene, do you mind if i take this
javanna commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156306626
> It's also going to make tests less likely to reproduce though, isn't it?
Do you mean if there are new failures caused by running concurrent searches
more often, these are going to
mikemccand commented on PR #738:
URL: https://github.com/apache/lucene/pull/738#issuecomment-1156523966
> On a related note, since writeBytes() is the only API that doesn't pause,
it may be useful to add this note in comments or docstring somewhere, perhaps
with a reference to the jira
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554620#comment-17554620
]
Michael McCandless commented on LUCENE-10600:
-
Can this be resolved as {{Not a Problem}}
mayya-sharipova commented on PR #947:
URL: https://github.com/apache/lucene/pull/947#issuecomment-1156532534
@msokolov Thanks for your work, this is a very exciting feature. Really
looking forward to it. Extra benefit – less disk space used for vector values.
Overall, this PR looks
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554625#comment-17554625
]
Adrien Grand commented on LUCENE-10600:
---
[~mikemccand] I don't think so, we still need to make
javanna commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156400157
Yep I see what you mean, I've seen that in the past that some tests may rely
on assumptions that are no longer true if you run the search concurrently. Some
may be test bugs, that may be
LuXugang opened a new pull request, #960:
URL: https://github.com/apache/lucene/pull/960
Detailed discussion see:
https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-10600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554645#comment-17554645
]
Adrien Grand commented on LUCENE-10618:
---
sure, feel free to give it a try and ping me for
mikemccand commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156474464
> Can the returned order of documents from the (parallel) searcher be
different? For score-sorted cases it may not be a problem but whenever there
are ties, and the assertions somehow
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang reassigned LUCENE-10603:
--
Assignee: Lu Xugang
> Improve iteration of ords for SortedSetDocValues
>
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156708360
@shaie I like this API approach to supporting other data types. Thanks! I
wonder if we shouldn't make `FacetSet` abstract and create a `LongFacetSet` for
the long-specific impl (and
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156786518
> I wonder if we shouldn't make `FacetSet` abstract and create a
`LongFacetSet` for the long-specific impl
I've contemplated on it when I wrote it. I like the idea of an explicit
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156829025
> I think we should also have some subpackages (maybe a `decoders`,
`matchers`, and `sets` (for `FacetSets`))?
Take a look at the last commit: not sure there's a reason for `decoders`
[
https://issues.apache.org/jira/browse/LUCENE-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554757#comment-17554757
]
ASF subversion and git services commented on LUCENE-10584:
--
Commit
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r898212017
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/FloatFacetSet.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
gsmiller commented on PR #954:
URL: https://github.com/apache/lucene/pull/954#issuecomment-1156721533
Sure, no problem @jpountz. Thanks for the suggestion. Any concerns with
merging this PR as it is?
--
This is an automated message from the Apache Git Service.
To respond to the message,
gsmiller merged PR #929:
URL: https://github.com/apache/lucene/pull/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554746#comment-17554746
]
ASF subversion and git services commented on LUCENE-10584:
--
Commit
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156814974
Yeah I think having their own FSD would make it clear. I think we should
also have some subpackages (maybe a `decoders`, `matchers`, and `sets` (for
`FacetSets`))?
--
This is an
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554764#comment-17554764
]
Michael McCandless commented on LUCENE-10600:
-
OK thanks.
I guess because the "number of
gsmiller commented on PR #929:
URL: https://github.com/apache/lucene/pull/929#issuecomment-1156775532
Thanks @mdmarshmallow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156805329
> Maybe one thing would be that we want to make it mandatory for a
`FacetSet` to implement its own `decode()` function?
I've been there :). The reason I went w/ the static method and
jpountz opened a new pull request, #961:
URL: https://github.com/apache/lucene/pull/961
As suggested by @zhaih on #950, we could support more cases in
`BooleanWeight#count`. This PR adds support for these cases specifically:
- Pure disjunctions where only one clause has a non-zero
shahrs87 commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1156823060
@jpountz Made one more attempt to fix test failures. Can you please take a
look again ? Thank you fir being patient with me.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/LUCENE-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554758#comment-17554758
]
Greg Miller commented on LUCENE-10584:
--
Fixed and backported. Resolving.
> SSDV facets should
[
https://issues.apache.org/jira/browse/LUCENE-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10584.
--
Fix Version/s: 9.3
Resolution: Fixed
> SSDV facets should support hierarchical paths
tangdh created LUCENE-10619:
---
Summary: Optimize the writeBytes in TermsHashPerField
Key: LUCENE-10619
URL: https://issues.apache.org/jira/browse/LUCENE-10619
Project: Lucene - Core
Issue Type:
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r898280617
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/FacetSetsField.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r898279453
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/FloatFacetSet.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156800419
I took a look at the API and seeing if we could do something there with
generics, but that overcomplicates the API haha. It looks good to me! Maybe one
thing would be that we want to
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156833064
@gsmiller @mdmarshmallow in the last commit I refactored `FacetSet` to be an
abstract class with a concrete `LongFacetSet` impl. I struggled back-and-forth
between introducing a `public final
jtibshirani commented on code in PR #958:
URL: https://github.com/apache/lucene/pull/958#discussion_r898455193
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -87,10 +87,14 @@ public static NeighborQueue search(
int numVisited = 0;
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156990982
I like the `getComparableLongs()` approach better as well.
I also think a demo is a good idea, I can create one later today or tomorrow
if you don't get around to it before
jtibshirani commented on code in PR #958:
URL: https://github.com/apache/lucene/pull/958#discussion_r898465271
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -498,7 +498,7 @@ public void testRandom() throws IOException {
/** Tests with
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554832#comment-17554832
]
Julie Tibshirani edited comment on LUCENE-10577 at 6/16/22 12:19 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554832#comment-17554832
]
Julie Tibshirani edited comment on LUCENE-10577 at 6/16/22 12:20 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554832#comment-17554832
]
Julie Tibshirani commented on LUCENE-10577:
---
[~sokolov] this is a really exciting effort.
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554835#comment-17554835
]
Julie Tibshirani commented on LUCENE-10577:
---
Last thought: would it make sense to break this
zhaih commented on code in PR #961:
URL: https://github.com/apache/lucene/pull/961#discussion_r898701671
##
lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java:
##
@@ -346,47 +346,100 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554898#comment-17554898
]
ASF subversion and git services commented on LUCENE-10600:
--
Commit
LuXugang merged PR #960:
URL: https://github.com/apache/lucene/pull/960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554900#comment-17554900
]
Robert Muir commented on LUCENE-10577:
--
I don't understand why we are doing this as yet another
LuXugang opened a new pull request, #962:
URL: https://github.com/apache/lucene/pull/962
Backport for https://github.com/apache/lucene/pull/960 and make same change
for Lucene70DocValues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jpountz commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156171875
I like the idea of better exercising concurrent search. I wonder if this has
potential to slow down tests due to repeated instantiations of threads. I'm
inclined to merge and watch how long
javanna commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156179895
> I wonder if this has potential to slow down tests due to repeated
instantiations of threads.
Yes I wonder the same, this needs some runs before we can evaluate how it
affects tests
dweiss commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156207808
It's also going to make tests less likely to reproduce though, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jpountz commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1156227500
This is my expectation as well, similarly to tests that use
ConcurrentMergeScheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gautamworah96 commented on code in PR #922:
URL: https://github.com/apache/lucene/pull/922#discussion_r897570270
##
lucene/facet/src/java/org/apache/lucene/facet/FacetField.java:
##
@@ -30,14 +30,12 @@
*/
public class FacetField extends Field {
- /** Field type used for
gautamworah96 commented on PR #922:
URL: https://github.com/apache/lucene/pull/922#issuecomment-1156032542
> I think we might be doing the right thing already? If you look at
StringField, we are setting: setIndexOptions(IndexOptions.DOCS)
Yes, that is indeed the case.
Thanks
Gautam Worah created LUCENE-10617:
-
Summary: Investigate recent Jenkins build failures in
TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler
Key: LUCENE-10617
URL:
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554423#comment-17554423
]
ASF subversion and git services commented on LUCENE-10078:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554422#comment-17554422
]
ASF subversion and git services commented on LUCENE-10078:
--
Commit
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156101105
> To complement that on the aggregation side we will need to pass a reader
which can convert the BytesRef to a long[]. I'm thinking that the
Int/Float/Long/DoubleFacetSet impls will
[
https://issues.apache.org/jira/browse/LUCENE-10617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554440#comment-17554440
]
Adrien Grand commented on LUCENE-10617:
---
Neither of these seeds reproduce for me but it looks
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1755#comment-1755
]
ASF subversion and git services commented on LUCENE-10078:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554445#comment-17554445
]
ASF subversion and git services commented on LUCENE-10617:
--
Commit
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1156131175
> Rather than do this, I think that it makes more sense for the impls to
just have the ability of returning their own values as a `long[]` (something
like `getComparableLongs()` that was in
[
https://issues.apache.org/jira/browse/LUCENE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554456#comment-17554456
]
ASF subversion and git services commented on LUCENE-10608:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554455#comment-17554455
]
ASF subversion and git services commented on LUCENE-10608:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554443#comment-17554443
]
ASF subversion and git services commented on LUCENE-10617:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554442#comment-17554442
]
ASF subversion and git services commented on LUCENE-10078:
--
Commit
Adrien Grand created LUCENE-10618:
-
Summary: Implement BooleanQuery rewrite rules based for
minimumShouldMatch
Key: LUCENE-10618
URL: https://issues.apache.org/jira/browse/LUCENE-10618
Project:
70 matches
Mail list logo
