[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-08-15 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579575#comment-17579575 ] Marios Trivyzas commented on LUCENE-10662: -- Is this something we still consider to go ahead

[jira] [Commented] (LUCENE-10423) Remove uses of wall-clock time in codebase

2022-08-15 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579570#comment-17579570 ] Marios Trivyzas commented on LUCENE-10423: -- But `nanoTime()` is marked here:

[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert

2022-08-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579703#comment-17579703 ] Dawid Weiss commented on LUCENE-10662: -- Hi [~matriv] . I don't think we'll integrate this change.

[jira] [Commented] (LUCENE-10423) Remove uses of wall-clock time in codebase

2022-08-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579678#comment-17579678 ] Robert Muir commented on LUCENE-10423: -- The comment is slightly incorrect. nanoTime should still

[jira] [Commented] (LUCENE-10674) BitSetConjunctionDISI iterators fall out of sync when lead doc >= minlength of bitsets

2022-08-15 Thread Jack Mazanec (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579854#comment-17579854 ] Jack Mazanec commented on LUCENE-10674: --- {color:#1d1c1d}Anyone have any thoughts? If not I will

[jira] [Commented] (LUCENE-10423) Remove uses of wall-clock time in codebase

2022-08-15 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579789#comment-17579789 ] Marios Trivyzas commented on LUCENE-10423: -- Thanks for explaining further, could you assign

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-08-15 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579831#comment-17579831 ] Julie Tibshirani commented on LUCENE-10471: --- bq. It makes sense to me to increase the limit

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-08-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579875#comment-17579875 ] Robert Muir commented on LUCENE-10471: -- It is also terrible that this issue says 2048 but somehow

[jira] [Commented] (LUCENE-10577) Enable quantization of HNSW vectors to 8 bits

2022-08-15 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579958#comment-17579958 ] Julie Tibshirani commented on LUCENE-10577: --- I also noticed a recurring test failure after

[jira] [Commented] (LUCENE-10577) Enable quantization of HNSW vectors to 8 bits

2022-08-15 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579957#comment-17579957 ] Julie Tibshirani commented on LUCENE-10577: --- Sorry to be so slow at reviewing @msokolov, this

[GitHub] [lucene] elliotzlin opened a new pull request, #1069: [LUCENE-2587] Highlighter fragment bug

2022-08-15 Thread GitBox
elliotzlin opened a new pull request, #1069: URL: https://github.com/apache/lucene/pull/1069 ### Description (or a Jira issue link if you have one) [LUCENE-2587](https://issues.apache.org/jira/browse/LUCENE-2587) The issue has a good write up of the bug. To summarize, we

[jira] [Assigned] (LUCENE-10423) Remove uses of wall-clock time in codebase

2022-08-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-10423: Assignee: Marios Trivyzas > Remove uses of wall-clock time in codebase >

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-08-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579874#comment-17579874 ] Robert Muir commented on LUCENE-10471: -- My main concern is that it can't be undone, as i

[jira] [Commented] (LUCENE-2587) Highlighter picks wrong offset for fragment boundaries

2022-08-15 Thread Elliot Z. Lin (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579967#comment-17579967 ] Elliot Z. Lin commented on LUCENE-2587: --- Jumping in here to revive this decade-old issue. Roberto,

[GitHub] [lucene] jmazanec15 opened a new pull request, #1068: LUCENE-10674: Update subiterators when BitSetConjDISI exhausts

2022-08-15 Thread GitBox
jmazanec15 opened a new pull request, #1068: URL: https://github.com/apache/lucene/pull/1068 ### Description (or a Jira issue link if you have one) Update all subiterators of BitSetConjunctionDISI to NO_MORE_DOCS when lead iterator's current doc is greater than the length of the

[jira] [Comment Edited] (LUCENE-10577) Enable quantization of HNSW vectors to 8 bits

2022-08-15 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579957#comment-17579957 ] Julie Tibshirani edited comment on LUCENE-10577 at 8/15/22 11:14 PM: