Re: [I] Introduce Bloom Filter as non-experimental/core postings format [lucene]

2024-01-02 Thread via GitHub
shwetathareja commented on issue #12986: URL: https://github.com/apache/lucene/issues/12986#issuecomment-1873988375 Thanks @mikemccand for the feedback. We can pursue the route to offer the backward compatibility in OpenSearch directly if there are no other takers among Lucene users.

Re: [I] Introduce Bloom Filter as non-experimental/core postings format [lucene]

2024-01-02 Thread via GitHub
mikemccand commented on issue #12986: URL: https://github.com/apache/lucene/issues/12986#issuecomment-1873933126 I agree with @rmuir -- promising backwards compatibility (API or index format) is a huge burden on Lucene developers, and it's hard enough with the default Codec today.

Re: [I] org.apache.lucene.search.TestFloatVectorSimilarityQuery.testVectorsAboveSimilarity fails intermittently [lucene]

2024-01-02 Thread via GitHub
benwtrent commented on issue #12955: URL: https://github.com/apache/lucene/issues/12955#issuecomment-1874009723 @kaivalnp this does indeed seem related to disconnectedness. That is a larger effort. I would suggest updating the graph parameters for this particular test to reduce the chance

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-02 Thread via GitHub
tveasey commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1873862125 IMO we shouldn't focus too much on recall since the greediness of non-competitive search allows us to tune this. My main concern is does contention on the queue updates cause slow down.

Re: [I] Refactoring: Rename Levenstein to Levenshtein [LUCENE-7370] [lucene]

2024-01-02 Thread via GitHub
shaikhu commented on issue #8424: URL: https://github.com/apache/lucene/issues/8424#issuecomment-1874242117 @mikemccand I think this can be closed now  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Update copyright year in NOTICE.txt file. [lucene]

2024-01-02 Thread via GitHub
cpoerschke closed pull request #12065: Update copyright year in NOTICE.txt file. URL: https://github.com/apache/lucene/pull/12065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update copyright year in NOTICE.txt file. [lucene]

2024-01-02 Thread via GitHub
cpoerschke commented on PR #12065: URL: https://github.com/apache/lucene/pull/12065#issuecomment-1874287516 Happy New Year 2024! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Reduce number of dimensions for Test[Byte|Float]VectorSimilarityQuery [lucene]

2024-01-02 Thread via GitHub
benwtrent merged PR #12988: URL: https://github.com/apache/lucene/pull/12988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Refactoring: Rename Levenstein to Levenshtein [LUCENE-7370] [lucene]

2024-01-02 Thread via GitHub
mikemccand closed issue #8424: Refactoring: Rename Levenstein to Levenshtein [LUCENE-7370] URL: https://github.com/apache/lucene/issues/8424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Refactoring: Rename Levenstein to Levenshtein [LUCENE-7370] [lucene]

2024-01-02 Thread via GitHub
mikemccand commented on issue #8424: URL: https://github.com/apache/lucene/issues/8424#issuecomment-1874398060 Great, thanks @shaikhu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Reduce number of dimensions for Test[Byte|Float]VectorSimilarityQuery [lucene]

2024-01-02 Thread via GitHub
kaivalnp opened a new pull request, #12988: URL: https://github.com/apache/lucene/pull/12988 ### Description Identified in #12955, where `TestFloatVectorSimilarityQuery.testVectorsAboveSimilarity` fails because of a disconnected HNSW graph This is a bigger issue, but we can

Re: [I] org.apache.lucene.search.TestFloatVectorSimilarityQuery.testVectorsAboveSimilarity fails intermittently [lucene]

2024-01-02 Thread via GitHub
kaivalnp commented on issue #12955: URL: https://github.com/apache/lucene/issues/12955#issuecomment-1874198612 Makes sense @benwtrent.. Opened #12988 to fix this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add support for index sorting with document blocks [lucene]

2024-01-02 Thread via GitHub
mikemccand commented on code in PR #12829: URL: https://github.com/apache/lucene/pull/12829#discussion_r1439716624 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -1176,34 +1176,44 @@ public static Status.IndexSortStatus testSort( comparators[i]

Re: [PR] LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches [lucene]

2024-01-02 Thread via GitHub
mikemccand commented on code in PR #12345: URL: https://github.com/apache/lucene/pull/12345#discussion_r1439744329 ## lucene/core/src/java/org/apache/lucene/index/ExitableIndexReader.java: ## @@ -0,0 +1,499 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] Update package info for HNSW [lucene]

2024-01-02 Thread via GitHub
znnahiyan opened a new issue, #12990: URL: https://github.com/apache/lucene/issues/12990 According to PR #608 #629, the HNSW package had been made hierarchical for Lucene 9.1.0, so it's not single-layer anymore as per the package info description:

[I] NullPointerException in IndexSearcher.search() when searching with SpanfirstQuery and a customized collector [lucene]

2024-01-02 Thread via GitHub
luozhuang opened a new issue, #12991: URL: https://github.com/apache/lucene/issues/12991 ### Description I encountered a NullPointerException when I searched with SpanfirstQuery. The Lucene version is 8.10. The example call stack is ``` A Java Exception: