Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-24 Thread via GitHub
mikemccand commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1908191816 > Maybe we can merge this fix as-is and continue the conversation about where test polygon generation should produce valid polygons in #12596. I +1. Progress not perfection!

Re: [PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-24 Thread via GitHub
ChrisHegarty commented on PR #13014: URL: https://github.com/apache/lucene/pull/13014#issuecomment-1908264542 @gf2121 I've added the 9.9.2 milestone to this PR. Do you agree? If so, is it possible to merge and backport to the `branch_9x` and `branch_9_9` branches. -- This is an

[I] Improve AbstractMultiTermQueryConstantScoreWrapper#RewritingWeight ScorerSupplier cost estimation [lucene]

2024-01-24 Thread via GitHub
rquesada-tibco opened a new issue, #13029: URL: https://github.com/apache/lucene/issues/13029 ### Description We recently discovered a performance degradation on our project when going from Lucene 9.4 to 9.9. The cause seems to be a side effect of

Re: [PR] Add support for similarity-based vector searches [lucene]

2024-01-24 Thread via GitHub
kaivalnp commented on PR #12679: URL: https://github.com/apache/lucene/pull/12679#issuecomment-1907958716 This feature will ship with Lucene 9.10 I'm not sure when that will be released, though [I see](https://lucene.apache.org/core/corenews.html) \~2-4 months between previous minor

Re: [PR] Fix issues with chunked TaxonomyIndexArray [lucene]

2024-01-24 Thread via GitHub
stefanvodita commented on code in PR #13028: URL: https://github.com/apache/lucene/pull/13028#discussion_r1464835176 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java: ## @@ -95,7 +97,8 @@ public TaxonomyIndexArrays(IndexReader reader,

[PR] Fix test failure for TestTopFieldCollector.testTotalHits [lucene]

2024-01-24 Thread via GitHub
easyice opened a new pull request, #13030: URL: https://github.com/apache/lucene/pull/13030 Gradle command to reproduce: ``` ./gradlew :lucene:core:test --tests "org.apache.lucene.search.TestTopFieldCollector.testTotalHits" -Ptests.heapsize=2g -Ptests.jvms=6

[PR] Propagate topLevelScoringClause from QueryProfiler [lucene]

2024-01-24 Thread via GitHub
mrkm4ntr opened a new pull request, #13031: URL: https://github.com/apache/lucene/pull/13031 ### Description The topLevelScoringClause is not propagated with QueryProfiler. This causes some optimizations are skipped during profiling. -- This is an automated message from the

[PR] in BytesRefHash constructor avoid duplicate BytesStartArray.bytesUsed() call [lucene]

2024-01-24 Thread via GitHub
cpoerschke opened a new pull request, #13032: URL: https://github.com/apache/lucene/pull/13032 Noticed whilst code reading. No issue or CHANGES.txt entry needed I think. For `main` and `branch_9x` branches only. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-24 Thread via GitHub
stefanvodita merged PR #12287: URL: https://github.com/apache/lucene/pull/12287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-24 Thread via GitHub
stefanvodita commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1908668560 Thank you for persevering @heemin32! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] join: avoid repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-24 Thread via GitHub
cpoerschke closed pull request #13019: join: avoid repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery URL: https://github.com/apache/lucene/pull/13019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] join: avoid repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-24 Thread via GitHub
cpoerschke commented on PR #13019: URL: https://github.com/apache/lucene/pull/13019#issuecomment-1908384002 closing in favour of #13014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-24 Thread via GitHub
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1908615744 Added CHANGELOG entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Re-explore the logic around when Vector search should be Exact [lucene]

2024-01-24 Thread via GitHub
benwtrent commented on issue #12505: URL: https://github.com/apache/lucene/issues/12505#issuecomment-1908426746 As pointed out in other issue conversations, Cassandra keeps track of the visited ratio over the lifetime of the index and its searches:

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-24 Thread via GitHub
stefanvodita commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1907818280 Maybe we can merge this fix as-is and continue the conversation about where test polygon generation should produce valid polygons in #12596. It's not clear to me now if there is

Re: [PR] Forbidden Thread.sleep API [lucene]

2024-01-24 Thread via GitHub
shubhamvishu commented on PR #13001: URL: https://github.com/apache/lucene/pull/13001#issuecomment-1907646476 @uschindler @mikemccand I think we could merge this now unless I'm missing something? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-24 Thread via GitHub
gf2121 merged PR #13014: URL: https://github.com/apache/lucene/pull/13014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SurroundQuery should pull TermStates during rewrite [lucene]

2024-01-24 Thread via GitHub
github-actions[bot] commented on PR #13008: URL: https://github.com/apache/lucene/pull/13008#issuecomment-1909133869 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Improve Javadoc for Lucene90StoredFieldsFormat [lucene]

2024-01-24 Thread via GitHub
github-actions[bot] commented on PR #12984: URL: https://github.com/apache/lucene/pull/12984#issuecomment-1909133928 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Fix issues with chunked TaxonomyIndexArray [lucene]

2024-01-24 Thread via GitHub
stefanvodita merged PR #13028: URL: https://github.com/apache/lucene/pull/13028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: