Re: [I] byte to int in TruncateTokenFilterFactory to TruncateTokenFilter [lucene]

2024-01-26 Thread via GitHub
scampi commented on issue #12449: URL: https://github.com/apache/lucene/issues/12449#issuecomment-1912710789 The PR got merged, this can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix too many open files Exception for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
rmuir commented on PR #13035: URL: https://github.com/apache/lucene/pull/13035#issuecomment-1912510553 Thank you @easyice ! There is also a `TestUtil.reduceOpenFiles`, I'm not sure if it is appropriate here, but something to look into. It is also nice since it makes it obvious from the

Re: [I] HnwsGraph creates disconnected components [lucene]

2024-01-26 Thread via GitHub
benwtrent commented on issue #12627: URL: https://github.com/apache/lucene/issues/12627#issuecomment-1912598493 OK, I added https://github.com/mikemccand/luceneutil/pull/253 Doing some local benchmarking. It seems that the more merges occur, the worse we can get. Sometimes I

[PR] GitHub#12946: Removing thread sleep calls from TestIndexWriter.testThreadInterruptDeadlock and TestDirectoryReader.testStressTryIncRef [lucene]

2024-01-26 Thread via GitHub
iamsanjay opened a new pull request, #13037: URL: https://github.com/apache/lucene/pull/13037 ### Description As suggested in #12946, I tried to tackle two test cases and replacing `Thread.sleep` calls appearing in `TestIndexWriter.testThreadInterruptDeadlock` and

Re: [PR] SOLR-17120: handle null value when merging partials (backport of solr#2214) [lucene-solr]

2024-01-26 Thread via GitHub
cpoerschke commented on code in PR #2683: URL: https://github.com/apache/lucene-solr/pull/2683#discussion_r1467470648 ## solr/CHANGES.txt: ## @@ -42,6 +42,9 @@ Bug Fixes * SOLR-17098: ZK Credentials and ACLs are no longer sent to all ZK Servers when using Streaming

[PR] Do not use HandleLimitFS for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
easyice opened a new pull request, #13035: URL: https://github.com/apache/lucene/pull/13035 ``` ./gradlew :lucene:core:test --tests "org.apache.lucene.index.TestConcurrentMergeScheduler.testNoStallMergeThreads" -Ptests.jvms=6 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC

Re: [PR] Do not use HandleLimitFS for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
rmuir commented on code in PR #13035: URL: https://github.com/apache/lucene/pull/13035#discussion_r1467598866 ## lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java: ## @@ -43,6 +43,8 @@ import org.apache.lucene.tests.util.TestUtil; import

Re: [PR] Do not use HandleLimitFS for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
easyice commented on PR #13035: URL: https://github.com/apache/lucene/pull/13035#issuecomment-1912109709 Thank you! i replaced the suppress with `setMaxBufferedDocs`, the open files in nightly tests reduced from 4000+ to 400+, does that looks okay? The `testDeleteMerging` might also

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-26 Thread via GitHub
benwtrent commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1912157192 I ran my own experiment, which showed some interesting and frustrating results. I adjusted the indexing to randomly commit() on every 500 docs or so. I indexed the first 10M

Re: [PR] Early exit range queries on non-matching segments. [lucene]

2024-01-26 Thread via GitHub
jpountz merged PR #13033: URL: https://github.com/apache/lucene/pull/13033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Propagate minimum competitive score in ReqOptSumScorer. [lucene]

2024-01-26 Thread via GitHub
jpountz merged PR #13026: URL: https://github.com/apache/lucene/pull/13026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17120: handle null value when merging partials (backport of solr#2214) [lucene-solr]

2024-01-26 Thread via GitHub
cpoerschke merged PR #2683: URL: https://github.com/apache/lucene-solr/pull/2683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Do not use mock merge policy for TestGrouping [lucene]

2024-01-26 Thread via GitHub
benwtrent merged PR #13034: URL: https://github.com/apache/lucene/pull/13034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Reproducible failure in TestGrouping.testRandom [lucene]

2024-01-26 Thread via GitHub
benwtrent closed issue #13025: Reproducible failure in TestGrouping.testRandom URL: https://github.com/apache/lucene/issues/13025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Do not use HandleLimitFS for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
rmuir commented on PR #13035: URL: https://github.com/apache/lucene/pull/13035#issuecomment-1911992774 This is not the correct fix: instead the test must be fixed to not use so many files at once. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Do not use HandleLimitFS for TestConcurrentMergeScheduler [lucene]

2024-01-26 Thread via GitHub
easyice commented on code in PR #13035: URL: https://github.com/apache/lucene/pull/13035#discussion_r1467674266 ## lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java: ## @@ -43,6 +43,8 @@ import org.apache.lucene.tests.util.TestUtil; import