[PR] Remove concatenation in String.format() calls [lucene]

2024-01-28 Thread via GitHub
sabi0 opened a new pull request, #13038: URL: https://github.com/apache/lucene/pull/13038 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Make use of null-checked variable [lucene]

2024-01-28 Thread via GitHub
sabi0 opened a new pull request, #13040: URL: https://github.com/apache/lucene/pull/13040 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Cleanup TokenizedPhraseQueryNode code [lucene]

2024-01-28 Thread via GitHub
sabi0 commented on code in PR #13041: URL: https://github.com/apache/lucene/pull/13041#discussion_r1468923263 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/TokenizedPhraseQueryNode.java: ## @@ -70,10 +70,8 @@ public QueryNode cloneTree()

Re: [PR] Optimize counts on two clause term disjunctions [lucene]

2024-01-28 Thread via GitHub
jfreden commented on code in PR #13036: URL: https://github.com/apache/lucene/pull/13036#discussion_r1468906825 ## lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java: ## @@ -249,10 +249,74 @@ BulkScorer optionalBulkScorer(LeafReaderContext context) throws

[PR] Cleanup TokenizedPhraseQueryNode code [lucene]

2024-01-28 Thread via GitHub
sabi0 opened a new pull request, #13041: URL: https://github.com/apache/lucene/pull/13041 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Support getMaxScore of ConjunctionScorer for non top level scoring clause [lucene]

2024-01-28 Thread via GitHub
mrkm4ntr opened a new pull request, #13043: URL: https://github.com/apache/lucene/pull/13043 ### Description After introducing topLevelScoringClause, ConjunctionScorer with multiple scorers can be used for non top level scoring clause conjunctions instead of BlockMaxConjunctionScorer

Re: [PR] LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary [lucene]

2024-01-28 Thread via GitHub
github-actions[bot] commented on PR #12517: URL: https://github.com/apache/lucene/pull/12517#issuecomment-1913774063 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

[PR] [LUCENE-13044][replicator] NRT add configurable commitData for Custom… [lucene]

2024-01-28 Thread via GitHub
dianjifzm opened a new pull request, #13045: URL: https://github.com/apache/lucene/pull/13045 … security verification ### Description 开放commitData的修改,可以自定义主从同步的安全机制 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

2024-01-28 Thread via GitHub
vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1914149013 @jpountz @mikemccand I resolved the conflicts, and moved the test case for target greater than the last entry of matched block from `TestLucene90PostingsFormat` to

Re: [PR] Propagate topLevelScoringClause from QueryProfiler [lucene]

2024-01-28 Thread via GitHub
mrkm4ntr commented on PR #13031: URL: https://github.com/apache/lucene/pull/13031#issuecomment-1914149588 @jpountz Sure. Added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Propagate topLevelScoringClause from QueryProfiler [lucene]

2024-01-28 Thread via GitHub
jpountz commented on PR #13031: URL: https://github.com/apache/lucene/pull/13031#issuecomment-1914131295 @mrkm4ntr 9.10 please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific