[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-03-10 Thread Adrien Grand (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299342#comment-17299342
 ] 

Adrien Grand commented on LUCENE-9705:
--

bq. I'm not sure I would propose anything different (package-privacy is nice)

+1 to make sure that utility classes for these file formats are pkg-private, 
this doesn't seem to be always the case today and I'm not seeing a reason why 
they couldn't be made pkg-private?

bq. I'm not very familiar with all the different codec classes here or the 
process

FYI the process is now documented at 
https://github.com/apache/lucene/blob/main/lucene/backward-codecs/README.md 
thanks to [~jtibshirani].

> Move all codec formats to the o.a.l.codecs.Lucene90 package
> ---
>
> Key: LUCENE-9705
> URL: https://issues.apache.org/jira/browse/LUCENE-9705
> Project: Lucene - Core
>  Issue Type: Wish
>Reporter: Ignacio Vera
>Priority: Major
>  Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> Current formats are distributed in different packages, prefixed with the 
> Lucene version they were created. With the upcoming release of Lucene 9.0, it 
> would be nice to move all those formats to just the o.a.l.codecs.Lucene90 
> package (and of course moving the current ones to the backwards-codecs).
> This issue would actually facilitate moving the directory API to little 
> endian (LUCENE-9047) as the only codecs that would need to handle backwards 
> compatibility will be the codecs in backwards codecs.
> In addition, it can help formalising the use of internal versions vs format 
> versioning ( LUCENE-9616)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15246) A unified highlighting search under solr 8.8.0/8.8.1 can take over 20 mins to run and eventually times out.

2021-03-10 Thread Matthew Flowerday (Jira)
Matthew Flowerday created SOLR-15246:


 Summary: A unified highlighting search under solr 8.8.0/8.8.1 can 
take over 20 mins to run and eventually times out.
 Key: SOLR-15246
 URL: https://issues.apache.org/jira/browse/SOLR-15246
 Project: Solr
  Issue Type: Bug
  Security Level: Public (Default Security Level. Issues are Public)
  Components: highlighter
Affects Versions: 8.8.1, 8.8
 Environment: I was running solr under windows
Reporter: Matthew Flowerday


With solr 8.8.0 a new unified highlighting parameter  was 
implemented which if not set defaults to 0.5. This attempts to improve the high 
lighting so that highlighted text does not appear right at the left. This works 
well but if you have a search result with numerous occurrences of the word in 
question within the record performance goes right down!

2021-02-27 06:45:03.151 INFO  (qtp762476028-20) [   x:uleaf] o.a.s.c.S.Request 
[uleaf]  webapp=/solr path=/select 
params=\{hl.snippets=2=test=on=100=id,description,specification,score=20=*=10&_=1614405119134}
 hits=57008 status=0 QTime=1414320

2021-02-27 06:45:03.245 INFO  (qtp762476028-20) [   x:uleaf] 
o.a.s.s.HttpSolrCall Unable to write response, client closed connection or we 
are shutting down => org.eclipse.jetty.io.EofException

  at 
org.eclipse.jetty.io.ChannelEndPoint.flush(ChannelEndPoint.java:279)

org.eclipse.jetty.io.EofException: null

  at 
org.eclipse.jetty.io.ChannelEndPoint.flush(ChannelEndPoint.java:279) 
~[jetty-io-9.4.34.v20201102.jar:9.4.34.v20201102]

  at org.eclipse.jetty.io.WriteFlusher.flush(WriteFlusher.java:422) 
~[jetty-io-9.4.34.v20201102.jar:9.4.34.v20201102]

  at 
org.eclipse.jetty.io.WriteFlusher.completeWrite(WriteFlusher.java:378) 
~[jetty-io-9.4.34.v20201102.jar:9.4.34.v20201102]

 

when I set =0.25 results came back much quicker

2021-02-27 14:59:57.189 INFO  (qtp1291367132-24) [   x:holmes] 
o.a.s.c.S.Request [holmes]  webapp=/solr path=/select 
params=\{hl.weightMatches=false=on=id,description,specification,score=1=0.25=100=2=test=100=*=unified=9&_=1614430061690}
 hits=136939 status=0 QTime=87024

And  =0.1

2021-02-27 15:18:45.542 INFO  (qtp1291367132-19) [   x:holmes] 
o.a.s.c.S.Request [holmes]  webapp=/solr path=/select 
params=\{hl.weightMatches=false=on=id,description,specification,score=1=0.1=100=2=test=100=*=unified=9&_=1614430061690}
 hits=136939 status=0 QTime=69033

And =0.0

2021-02-27 15:20:38.194 INFO  (qtp1291367132-24) [   x:holmes] 
o.a.s.c.S.Request [holmes]  webapp=/solr path=/select 
params=\{hl.weightMatches=false=on=id,description,specification,score=1=0.0=100=2=test=100=*=unified=9&_=1614430061690}
 hits=136939 status=0 QTime=2841

I left our setting at 0.0 – this presumably how it was in 7.7.1 (fully left 
aligned).  I am not too sure as to how many time a word has to occur in a 
record for performance to go right down – but if too many it can have a BIG 
impact.

It might be an idea to set the default value to be say 0.25 instead of 0.5 so 
that people are not caught out.

I also noticed that setting =9 did not break out of the query 
until it finished. Perhaps because the query finished quickly and what took the 
time was the highlighting. It might be an idea to get  to also 
cover any highlighting so that the query does not run until the jetty timeout 
is hit. The machine 100% one core for about 20 mins!.

I raised this at the request of a member of the user forum.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Resolved] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Noble Paul (Jira)


 [ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Noble Paul resolved SOLR-15245.
---
Fix Version/s: 8.9
 Assignee: Noble Paul
   Resolution: Fixed

> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Assignee: Noble Paul
>Priority: Major
> Fix For: 8.9
>
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299313#comment-17299313
 ] 

ASF subversion and git services commented on SOLR-15245:


Commit afce3b08fae0e6aac3cfef6c581b65dc70cbc554 in lucene-solr's branch 
refs/heads/branch_8x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=afce3b0 ]

SOLR-15245: Document zk-read permission and use zk-read permission for content


> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Priority: Major
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Noble Paul (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299312#comment-17299312
 ] 

Noble Paul commented on SOLR-15245:
---

{{zk-read}} should be good enough

> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Priority: Major
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] msokolov commented on pull request #2459: LUCENE-9825: Hunspell: reverse the "words" trie for faster word lookup/suggestions

2021-03-10 Thread GitBox


msokolov commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-796347476


   Here's another pithy phrase for you: don't let the perfect be the enemy of
   the good
   
   On Wed, Mar 10, 2021, 7:33 AM Dawid Weiss ***@***.***> wrote:
   
   > All I need is you to remind me about that perfection vs. progress thing...
   > :)
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Mike Drob (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299205#comment-17299205
 ] 

Mike Drob commented on SOLR-15245:
--

Should access to security.json require both zk-read and security-read or is 
just one sufficient?

> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Priority: Major
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Resolved] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir resolved LUCENE-9802.
-
Fix Version/s: main (9.0)
   Resolution: Fixed

marking this fixed. please, lets iterate on followup issues.

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Fix For: main (9.0)
>
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Noble Paul (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299194#comment-17299194
 ] 

Noble Paul commented on SOLR-15245:
---

bq.that should be either documented or corrected as well.

I shall fix this

> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Priority: Major
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Mike Drob (Jira)


 [ 
https://issues.apache.org/jira/browse/SOLR-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated SOLR-15245:
-
Issue Type: Task  (was: Test)

> Ref Guide missing "zk-read" permission
> --
>
> Key: SOLR-15245
> URL: https://issues.apache.org/jira/browse/SOLR-15245
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Mike Drob
>Priority: Major
>
> https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions
> The docs do not explain what is the zk-read permission, found at 
> PermissionNameProvider.
> Also, for some reason /cluster/zk/data/* uses the collection read permission 
> instead of ZK read permission, that should be either documented or corrected 
> as well.
> cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15245) Ref Guide missing "zk-read" permission

2021-03-10 Thread Mike Drob (Jira)
Mike Drob created SOLR-15245:


 Summary: Ref Guide missing "zk-read" permission
 Key: SOLR-15245
 URL: https://issues.apache.org/jira/browse/SOLR-15245
 Project: Solr
  Issue Type: Test
  Security Level: Public (Default Security Level. Issues are Public)
  Components: documentation
Reporter: Mike Drob


https://solr.apache.org/guide/8_8/rule-based-authorization-plugin.html#predefined-permissions

The docs do not explain what is the zk-read permission, found at 
PermissionNameProvider.

Also, for some reason /cluster/zk/data/* uses the collection read permission 
instead of ZK read permission, that should be either documented or corrected as 
well.

cc: [~noble.paul]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14827) Refactor schema loading to not use XPath

2021-03-10 Thread Noble Paul (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299189#comment-17299189
 ] 

Noble Paul commented on SOLR-14827:
---

bq.I observed that this commit included changes to CloudConfigSetService that 
appear to be dormant/unused relating to caching config nodes. 

I think we should get rid of that feature altogether. Now it is always cached. 
We just have one cached object per unique schema.xml

> Refactor schema loading to not use XPath
> 
>
> Key: SOLR-14827
> URL: https://issues.apache.org/jira/browse/SOLR-14827
> Project: Solr
>  Issue Type: Task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
>  Labels: perfomance
> Fix For: 8.8
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> XPath is slower compared to DOM. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #236: Change of solrJavaMem is not propagated to the underlying statefulset

2021-03-10 Thread GitBox


HoustonPutman commented on issue #236:
URL: 
https://github.com/apache/lucene-solr-operator/issues/236#issuecomment-796268136


   Glad to hear it's not an actual bug! Got me a bit worried when I first got 
the notification  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14827) Refactor schema loading to not use XPath

2021-03-10 Thread David Smiley (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299184#comment-17299184
 ] 

David Smiley commented on SOLR-14827:
-

[~noble.paul] I observed that this commit included changes to 
CloudConfigSetService that appear to be dormant/unused relating to caching 
config nodes.  Am I missing something?  I suspect your intention was to re-used 
the DOM (parsed XML) but that isn't happening here.  BTW I recall the 
CuratorFramework has facilities for this sort of thing to make this transparent.

> Refactor schema loading to not use XPath
> 
>
> Key: SOLR-14827
> URL: https://issues.apache.org/jira/browse/SOLR-14827
> Project: Solr
>  Issue Type: Task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
>  Labels: perfomance
> Fix For: 8.8
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> XPath is slower compared to DOM. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-03-10 Thread Greg Miller (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299167#comment-17299167
 ] 

Greg Miller commented on LUCENE-9705:
-

I'm not very familiar with all the different codec classes here or the process, 
but I think there are some cases at least where classes get duplicated even 
though there's no change right? Sort of to Mike S.'s point (if I'm 
understanding at least). This is maybe limited to package-private utility 
stuff? So maybe it's not worth splitting hairs over, but I've at least seen 
duplication (with no change) in the PForUtil/ForUtil/ForDeltaUtil classes. I'm 
not sure I would propose anything different (package-privacy is nice), but it 
is a little bit of a rough edge with the current solution.

> Move all codec formats to the o.a.l.codecs.Lucene90 package
> ---
>
> Key: LUCENE-9705
> URL: https://issues.apache.org/jira/browse/LUCENE-9705
> Project: Lucene - Core
>  Issue Type: Wish
>Reporter: Ignacio Vera
>Priority: Major
>  Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> Current formats are distributed in different packages, prefixed with the 
> Lucene version they were created. With the upcoming release of Lucene 9.0, it 
> would be nice to move all those formats to just the o.a.l.codecs.Lucene90 
> package (and of course moving the current ones to the backwards-codecs).
> This issue would actually facilitate moving the directory API to little 
> endian (LUCENE-9047) as the only codecs that would need to handle backwards 
> compatibility will be the codecs in backwards codecs.
> In addition, it can help formalising the use of internal versions vs format 
> versioning ( LUCENE-9616)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299153#comment-17299153
 ] 

Robert Muir commented on LUCENE-9802:
-

Yeah I didn't change anything about old releases, just fixed logos in the 
source tree so that the next release will use the new logo for its generated 
documentation.

To my knowledge, the new logo is now everywhere it should be.

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] benediktarnold commented on issue #236: Change of solrJavaMem is not propagated to the underlying statefulset

2021-03-10 Thread GitBox


benediktarnold commented on issue #236:
URL: 
https://github.com/apache/lucene-solr-operator/issues/236#issuecomment-796149602


   Stupid me! I tried to reproduce this on another cluster where it turned out 
to work as expected.
   
   It turned out that I never changed the variable since I changed it in the 
values.yaml of my helm chart but I was overriding the same variable in another 
values file, that I supplied via command line flag. 
   
   Sorry for bothering you. Good work btw. I really like the solr-operator!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] benediktarnold closed issue #236: Change of solrJavaMem is not propagated to the underlying statefulset

2021-03-10 Thread GitBox


benediktarnold closed issue #236:
URL: https://github.com/apache/lucene-solr-operator/issues/236


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15244) Use NIO methods instead of IO when interacting with Lucene Directory

2021-03-10 Thread Mike Drob (Jira)
Mike Drob created SOLR-15244:


 Summary: Use NIO methods instead of IO when interacting with 
Lucene Directory
 Key: SOLR-15244
 URL: https://issues.apache.org/jira/browse/SOLR-15244
 Project: Solr
  Issue Type: Improvement
  Security Level: Public (Default Security Level. Issues are Public)
Reporter: Mike Drob


We have a lot of places where we are still using IO methods and File objects, 
and then doing conversions to Path for accessing Lucene Directory. We also have 
places where we are doing a bunch of conversions from Path to String and back 
to Path through SolrResourceLoader.

Do a sweep of these and update at least the easy ones. There are a few places 
where File APIs might still make more sense or be too burdensome to convert, 
can leave those for another day.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299130#comment-17299130
 ] 

Uwe Schindler commented on LUCENE-9802:
---

Ah it's already done for Gradle documentation. Thanks Robert.

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299127#comment-17299127
 ] 

Uwe Schindler commented on LUCENE-9802:
---

Documentation logo must be changed in main git, so Java docs pick it up.

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] dweiss merged pull request #10: LUCENE-9375: some build file cleanups.

2021-03-10 Thread GitBox


dweiss merged pull request #10:
URL: https://github.com/apache/lucene/pull/10


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299126#comment-17299126
 ] 

Uwe Schindler commented on LUCENE-9802:
---

Hi,
Looks fine now. We should maybe change the css a bit to adapt the light green 
colours to the new ones (background of header and link color/background). The 
apache feather in header should also be replaced with new one, it looks 
horrible in combination with new flat logo.

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15243) Ref Guide: MoreLikeThis docs need overhaul

2021-03-10 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-15243:


 Summary: Ref Guide: MoreLikeThis docs need overhaul
 Key: SOLR-15243
 URL: https://issues.apache.org/jira/browse/SOLR-15243
 Project: Solr
  Issue Type: Bug
  Security Level: Public (Default Security Level. Issues are Public)
  Components: documentation, MoreLikeThis
Reporter: Cassandra Targett
Assignee: Cassandra Targett


No offense to anyone who's worked on morelikethis.adoc, but the current docs 
are pretty vague and require a ton of reading between the lines to understand. 
I had to help someone with something today and it took me a couple hours of 
trying things out in a local instance just to wrap my head around it. Good docs 
would prevent that.

Some things off the top of my head that would help:
* examples of config and output for each approach (search component/request 
handler/query parser)
* documenting the defaults for each parameter
* moving the MoreLikeThisQParser docs from other-parsers.adoc to 
morelikethis.adoc for a single source for all MLT stuff in Solr



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] rmuir commented on a change in pull request #10: LUCENE-9375: some build file cleanups.

2021-03-10 Thread GitBox


rmuir commented on a change in pull request #10:
URL: https://github.com/apache/lucene/pull/10#discussion_r591853762



##
File path: gradle/maven/defaults-maven.gradle
##
@@ -184,61 +170,6 @@ configure(subprojects.findAll { it.path in 
rootProject.published }) { prj ->
   developerConnection = 
'scm:git:https://gitbox.apache.org/repos/asf/lucene-solr.git'
   url = 'https://gitbox.apache.org/repos/asf?p=lucene-solr.git'

Review comment:
   Should we fix these two URLs above while we are here?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9802:

Description: 
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** -Top left on all pages-
 ** -Banner-
 ** -Documentation (just for new releases)-
 ** -Favicon-
 ** -Link Previews-
 * -Luke-
 * -JIRA-
 * -Confluence-
 * -Github (README.md)-
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.

  was:
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** -Top left on all pages-
 ** -Banner-
 ** Documentation (just for new releases)
 ** -Favicon-
 ** -Link Previews-
 * Luke
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** -Documentation (just for new releases)-
>  ** -Favicon-
>  ** -Link Previews-
>  * -Luke-
>  * -JIRA-
>  * -Confluence-
>  * -Github (README.md)-
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] dweiss opened a new pull request #10: LUCENE-9375: some build file cleanups.

2021-03-10 Thread GitBox


dweiss opened a new pull request #10:
URL: https://github.com/apache/lucene/pull/10


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] mikemccand merged pull request #9: LUCENE-9802: switch to new logo

2021-03-10 Thread GitBox


mikemccand merged pull request #9:
URL: https://github.com/apache/lucene/pull/9


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] rmuir opened a new pull request #9: LUCENE-9802: switch to new logo

2021-03-10 Thread GitBox


rmuir opened a new pull request #9:
URL: https://github.com/apache/lucene/pull/9


   Replace logo used in generated documentation
   Replace logo used by luke (about box)
   Add logo to README.md
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9802:

Description: 
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** -Top left on all pages-
 ** -Banner-
 ** Documentation (just for new releases)
 ** -Favicon-
 ** -Link Previews-
 * Luke
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.

  was:
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** -Top left on all pages-
 ** -Banner-
 ** Documentation (just for new releases)
 ** -Favicon-
 ** -Link Previews-
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** Documentation (just for new releases)
>  ** -Favicon-
>  ** -Link Previews-
>  * Luke
>  * -JIRA-
>  * -Confluence-
>  * Github (README.md)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9802:

Description: 
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** -Top left on all pages-
 ** -Banner-
 ** Documentation (just for new releases)
 ** -Favicon-
 ** -Link Previews-
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.

  was:
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** Top left on all pages
 ** Banner
 ** Documentation (just for new releases)
 ** Favicon
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** -Top left on all pages-
>  ** -Banner-
>  ** Documentation (just for new releases)
>  ** -Favicon-
>  ** -Link Previews-
>  * -JIRA-
>  * -Confluence-
>  * Github (README.md)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] benediktarnold opened a new issue #236: Change of solrJavaMem is not propagated to the underlying statefulset

2021-03-10 Thread GitBox


benediktarnold opened a new issue #236:
URL: https://github.com/apache/lucene-solr-operator/issues/236


   I have a solrcloud deployed with `solrJavaMem: "-Xmx1G -Xms400M"` and I 
changed that to  "-Xmx2G -Xms400M"`. The change is visible in the solrcloud 
resource but not in the statefulset. The statefulset has still the evironment 
variable set to 1G `SOLR_JAVA_MEM:   -Xmx1G -Xms400M`  whereas the solrcloud 
resource has the expected value of `Solr Java Mem:   -Xmx2G -Xms400M`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] dweiss commented on a change in pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


dweiss commented on a change in pull request #6:
URL: https://github.com/apache/lucene/pull/6#discussion_r591800419



##
File path: .github/workflows/hunspell.yml
##
@@ -3,7 +3,7 @@ name: Hunspell regression tests
 on:
   pull_request:
 branches:
-  - 'master'
+  - 'main'

Review comment:
   I know. And I appreciate. I think it should be downhill from now on 
though - Lucene alone is a much smaller codebase to work with (and very focused 
compared to Solr's ecosystem). Step by step. I'll go through the build files in 
a spare moment too.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15202) Rule-Based Authorization Plugin parameter for core, not just collection, for non-cluster installations

2021-03-10 Thread Jason Gerlowski (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299061#comment-17299061
 ] 

Jason Gerlowski commented on SOLR-15202:


I've made this ticket public since it's discussing an enhancement to RBAP, and 
not a specific vulnerability. (Along with Ken's agreement above of course.)

> Rule-Based Authorization Plugin parameter for core, not just collection, for 
> non-cluster installations
> --
>
> Key: SOLR-15202
> URL: https://issues.apache.org/jira/browse/SOLR-15202
> Project: Solr
>  Issue Type: Wish
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Authorization
>Affects Versions: 8.8.1
> Environment: Debian Buster, openjdk 11, Solr 8.8.1 stand-alone, 
> installed as a service
>Reporter: Ken Liccardo
>Priority: Minor
>
> I was trying to limit access to specific CORES but as I was reading the 
> RuleBasedAuthorizationPlugin documentation I conflated the terms "core" and 
> "collection", and was wondering why configuring permissions by core name used 
> in the collection parameter wasn't working.  I've used Solr for years as 
> stand-alone but somehow this distinction (core vs collection; I understand 
> now that the latter is only used in solr clusters) escaped me while reading 
> the Authorization documentation.  Then I had an "aha" moment when I realized 
> my confusion in terms.  So, I don't know if it is difficult to add 
> authorization by core for us stand-alone users.  Or, perhaps allow the use of 
> full paths, up to the endpoint, such as "solr/core1/select" instead of just 
> "/select", for the "path" parameter.
>  
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (SOLR-15202) Rule-Based Authorization Plugin parameter for core, not just collection, for non-cluster installations

2021-03-10 Thread Jason Gerlowski (Jira)


 [ 
https://issues.apache.org/jira/browse/SOLR-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Gerlowski updated SOLR-15202:
---
Security: Public  (was: Private (Security Issue))

> Rule-Based Authorization Plugin parameter for core, not just collection, for 
> non-cluster installations
> --
>
> Key: SOLR-15202
> URL: https://issues.apache.org/jira/browse/SOLR-15202
> Project: Solr
>  Issue Type: Wish
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Authorization
>Affects Versions: 8.8.1
> Environment: Debian Buster, openjdk 11, Solr 8.8.1 stand-alone, 
> installed as a service
>Reporter: Ken Liccardo
>Priority: Minor
>
> I was trying to limit access to specific CORES but as I was reading the 
> RuleBasedAuthorizationPlugin documentation I conflated the terms "core" and 
> "collection", and was wondering why configuring permissions by core name used 
> in the collection parameter wasn't working.  I've used Solr for years as 
> stand-alone but somehow this distinction (core vs collection; I understand 
> now that the latter is only used in solr clusters) escaped me while reading 
> the Authorization documentation.  Then I had an "aha" moment when I realized 
> my confusion in terms.  So, I don't know if it is difficult to add 
> authorization by core for us stand-alone users.  Or, perhaps allow the use of 
> full paths, up to the endpoint, such as "solr/core1/select" instead of just 
> "/select", for the "path" parameter.
>  
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15211) Set up solr-operator as a sub project

2021-03-10 Thread Jira


[ 
https://issues.apache.org/jira/browse/SOLR-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299025#comment-17299025
 ] 

Jan Høydahl commented on SOLR-15211:


Just decide on where to host the doap file and if in git, make a redirect in 
htaccess. If doap lives in solr-site repo, place it in the content folder and 
it will appear directly.

> Set up solr-operator as a sub project
> -
>
> Key: SOLR-15211
> URL: https://issues.apache.org/jira/browse/SOLR-15211
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Houston Putman
>Priority: Major
>
> * Create DOAP file for it
>  * Find a way to highlight the sub project on Solr webpage (with a link to 
> GitHub)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14341) Move a collection's configSet name to state.json

2021-03-10 Thread Nazerke Seidan (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299009#comment-17299009
 ] 

Nazerke Seidan commented on SOLR-14341:
---

I have written some stuff in this doc 
[https://docs.google.com/document/d/1I9eKlmRXs6aGYCAyZ9Ih956ukC74YUbGpV-WOhkyKIk/edit?usp=sharing]
 in order to get some inputs from you in particular backward compatibility 
concern. 

[~janhoy], [~houston], [~noble.paul] mentioning you as you are a watcher and 
you might have some ideas, thanks. 

> Move a collection's configSet name to state.json
> 
>
> Key: SOLR-14341
> URL: https://issues.apache.org/jira/browse/SOLR-14341
> Project: Solr
>  Issue Type: Improvement
>  Components: SolrCloud
>Reporter: David Smiley
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It's a bit odd that a collection's state.json knows everything about a 
> collection except for perhaps the most important pointer -- the configSet 
> name.  Presently the configSet name is retrieved via 
> {{ZkStateReader.getConfigName(collectionName)}} which looks at the zk path 
> {{/collections/collectionName}} (an intermediate node) interpreted as a 
> trivial JSON object.  Combining the configSet name into state.json is simpler 
> and also more efficient since many calls to grab the configset name _already_ 
> need the state.json (via a DocCollection object).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9802:

Description: 
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** Top left on all pages
 ** Banner
 ** Documentation (just for new releases)
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.

  was:
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** Top left on all pages
 ** Banner
 ** Documentation (just for new releases)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** Top left on all pages
>  ** Banner
>  ** Documentation (just for new releases)
>  * -JIRA-
>  * -Confluence-
>  * Github (README.md)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


 [ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9802:

Description: 
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** Top left on all pages
 ** Banner
 ** Documentation (just for new releases)
 ** Favicon
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.

  was:
Last year we held a competition to create a new logo for Lucene. The vote was 
[tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
 and culminated in [this 
submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
 winning. This issue is to actually deploy the logo where relevant.

The following is a non-exhaustive list of places that need to be handled:
 * Lucene website
 ** Top left on all pages
 ** Banner
 ** Documentation (just for new releases)
 * -JIRA-
 * -Confluence-
 * Github (README.md)
 * Wikipedia

I'm also not sure where the assets should live permanently. I don't believe 
there is a dedicated place the current logo lives, where one could simply 
download it, other than just saving the image from site navigation.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** Top left on all pages
>  ** Banner
>  ** Documentation (just for new releases)
>  ** Favicon
>  * -JIRA-
>  * -Confluence-
>  * Github (README.md)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-15172) Setup Jenkins for new solr repo build

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298995#comment-17298995
 ] 

Uwe Schindler edited comment on SOLR-15172 at 3/10/21, 5:27 PM:


I changed the ASF "Lucene/Lucene-Solr-Check-master" Job as first example:
- Changed Git repo and branch: lucene.git main
- Used "Move/Copy/Promote" to create a "copy without builds" in new Solr folder
- Changed copied job's git repo: solr.git
- In the Solr copy, I changed mail address
- Renamed both jobs: 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-master/ and 
https://ci-builds.apache.org/job/Solr/job/Solr-Check-master/

The effect of this: The original Lucene job preserved history, the solr job has 
no previous builds


was (Author: thetaphi):
I changed the ASF "Lucene/Lucene-Solr-Check-master" Job as first example:
- Changed Git repo and branch: lucene.git main
- Used "Move/Copy/Promote" to create a "copy without builds" in new Solr folder
- Changed copied job's git repo: solr.git
- Renamed both jobs: 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-master/ and 
https://ci-builds.apache.org/job/Solr/job/Solr-Check-master/

The effect of this: The original Lucene job preserved history, the solr job has 
no previous builds

> Setup Jenkins for new solr repo build
> -
>
> Key: SOLR-15172
> URL: https://issues.apache.org/jira/browse/SOLR-15172
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Uwe Schindler
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-15172) Setup Jenkins for new solr repo build

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298995#comment-17298995
 ] 

Uwe Schindler edited comment on SOLR-15172 at 3/10/21, 5:25 PM:


I changed the ASF "Lucene/Lucene-Solr-Check-master" Job as first example:
- Changed Git repo and branch: lucene.git main
- Used "Move/Copy/Promote" to create a "copy without builds" in new Solr folder
- Changed copied job's git repo: solr.git
- Renamed both jobs: 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-master/ and 
https://ci-builds.apache.org/job/Solr/job/Solr-Check-master/

The effect of this: The original Lucene job preserved history, the solr job has 
no previous builds


was (Author: thetaphi):
I changed the ASF "Lucene/Lucene-Solr-Check-master" Job as first example:
- Changed Git repo and branch: lucene.git main
- Used "Move/Copy/Promote" to create a "copy without builds" in new Solr folder
- Changed copied job's git repo: solr.git
- Renamed both jobs: 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-master/ and 
https://ci-builds.apache.org/job/Solr/job/Solr-Check-master/

> Setup Jenkins for new solr repo build
> -
>
> Key: SOLR-15172
> URL: https://issues.apache.org/jira/browse/SOLR-15172
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Uwe Schindler
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15172) Setup Jenkins for new solr repo build

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298995#comment-17298995
 ] 

Uwe Schindler commented on SOLR-15172:
--

I changed the ASF "Lucene/Lucene-Solr-Check-master" Job as first example:
- Changed Git repo and branch: lucene.git main
- Used "Move/Copy/Promote" to create a "copy without builds" in new Solr folder
- Changed copied job's git repo: solr.git
- Renamed both jobs: 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-master/ and 
https://ci-builds.apache.org/job/Solr/job/Solr-Check-master/

> Setup Jenkins for new solr repo build
> -
>
> Key: SOLR-15172
> URL: https://issues.apache.org/jira/browse/SOLR-15172
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Uwe Schindler
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] pawel-bugalski-dynatrace commented on pull request #8: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-10 Thread GitBox


pawel-bugalski-dynatrace commented on pull request #8:
URL: https://github.com/apache/lucene/pull/8#issuecomment-795759823


   This is a continuation of https://github.com/apache/lucene-solr/pull/2429 
that was targeting an old `lucene-solr` repository.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] pawel-bugalski-dynatrace commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-10 Thread GitBox


pawel-bugalski-dynatrace commented on pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-795758595


   I'm closing this pull request as it was replaced by 
https://github.com/apache/lucene/pull/8 that is targeting a new repository.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] pawel-bugalski-dynatrace closed pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-10 Thread GitBox


pawel-bugalski-dynatrace closed pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] pawel-bugalski-dynatrace opened a new pull request #8: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-03-10 Thread GitBox


pawel-bugalski-dynatrace opened a new pull request #8:
URL: https://github.com/apache/lucene/pull/8


   # Description
   
   Removes `scratch1` field in `BytesRefHash` by accessing underlying bytes 
pool directly
   in `equals` method. As a result it is now possible to call 
`BytesRefHash#find`
   concurrently as long as there are no concurrent modifications to 
BytesRefHash instance
   and it is correctly published.
   
   This addresses the concurrency issue with Monitor (aka Luwak) since it
   is using `BytesRefHash#find` concurrently without additional synchronization.
   
   # Solution
   
   Remove unnecessary state from `BytesRefHash` so that non-mutating find 
method behaves similar
   to `HashMap`'s get/containsKey.
   
   # Tests
   
   Added a new unit test that reproduces a problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code 
conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Lucene maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   
   # Issue link
   https://issues.apache.org/jira/browse/LUCENE-9791
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298968#comment-17298968
 ] 

Robert Muir commented on LUCENE-9802:
-

I fixed the wiki as well to have the same square icon for the "space" avatar, 
and I replaced the attachment on the main page:

https://wiki.apache.org/lucene

> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** Top left on all pages
>  ** Banner
>  ** Documentation (just for new releases)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15211) Set up solr-operator as a sub project

2021-03-10 Thread Houston Putman (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298965#comment-17298965
 ] 

Houston Putman commented on SOLR-15211:
---

Thanks for the help [~janhoy]l! I'll get started that asap. It looks like I can 
use URLs that will be available in the future, since there is some information 
in the Solr one that doesn't exist yet (e.g. 
https://gitbox.apache.org/repos/asf?p=solr.git).

> Set up solr-operator as a sub project
> -
>
> Key: SOLR-15211
> URL: https://issues.apache.org/jira/browse/SOLR-15211
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Houston Putman
>Priority: Major
>
> * Create DOAP file for it
>  * Find a way to highlight the sub project on Solr webpage (with a link to 
> GitHub)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-03-10 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298963#comment-17298963
 ] 

Robert Muir commented on LUCENE-9802:
-

As a first step, we can push the logo files to the website just so we can 
reference them by URL in other places. No graphic/html talents needed, just 
upload the files? 

Then we can iteratively cut over places (website, github, etc) to use the new 
logos.

I just applied the new logo to our JIRA project since JIRA wants you to upload 
the image to do that.


> Switch to new logo
> --
>
> Key: LUCENE-9802
> URL: https://issues.apache.org/jira/browse/LUCENE-9802
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Ryan Ernst
>Priority: Trivial
> Attachments: Lucene Logo.zip
>
>
> Last year we held a competition to create a new logo for Lucene. The vote was 
> [tallied|http://mail-archives.apache.org/mod_mbox/lucene-dev/202009.mbox/%3cca+dixd68cwx1-qmm4mdq5ybfbqwwt8gyy8wvyxbmcgmfrrj...@mail.gmail.com%3e],
>  and culminated in [this 
> submission|https://issues.apache.org/jira/browse/LUCENE-9221?focusedCommentId=17080525=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17080525]
>  winning. This issue is to actually deploy the logo where relevant.
> The following is a non-exhaustive list of places that need to be handled:
>  * Lucene website
>  ** Top left on all pages
>  ** Banner
>  ** Documentation (just for new releases)
>  * Wikipedia
> I'm also not sure where the assets should live permanently. I don't believe 
> there is a dedicated place the current logo lives, where one could simply 
> download it, other than just saving the image from site navigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9829) Default github PR merging to "squash"

2021-03-10 Thread Houston Putman (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298955#comment-17298955
 ] 

Houston Putman commented on LUCENE-9829:


This isn't really important since the other two options aren't allowed anymore, 
but for posterity:

You can only specify "allowed" merge strategies, you can't set a default. 
Github will default to the option you used last in the same repo. Since these 
were your first PRs in the new repos, it defaulted to the first allowed option: 
"Merge commit".

> Default github PR merging to "squash"
> -
>
> Key: LUCENE-9829
> URL: https://issues.apache.org/jira/browse/LUCENE-9829
> Project: Lucene - Core
>  Issue Type: Sub-task
>Reporter: Dawid Weiss
>Priority: Major
>
> I think it now creates a merge commit - don't know who did the squash default 
> or how to set it up on Lucene/Solr repos.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15222) Solr should not auto-create the "userfiles" dir

2021-03-10 Thread Houston Putman (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298951#comment-17298951
 ] 

Houston Putman commented on SOLR-15222:
---

Not sure I love requiring people create the directory on their own, but I 
definitely agree it shouldn't be autocreated if the feature isn't used.

Would it be possible to create the directory the first time someone tries to 
upload a file to the "filestore"?

> Solr should not auto-create the "userfiles" dir
> ---
>
> Key: SOLR-15222
> URL: https://issues.apache.org/jira/browse/SOLR-15222
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: David Smiley
>Priority: Major
>
> The "userfiles" feature is relatively obscure and might be subsumed by the 
> "file store".  I don't think an obscure feature should be auto-creating its 
> "userfiles" directory.  Even a popular one; not sure it makes sense.  If a 
> user wants to use this feature, they are welcome to create the directory.  
> Solr has other optional directories, like solr-home/lib that are not 
> auto-created; it's not clear to me why this one is.  I've found the 
> auto-creation of this dir to be annoying in two ways.  One is in Solr's tests 
> – there are existing Jira issues that show stack traces about this even 
> though it's ignored.  Secondly is as a down-stream consumer for 
> running/building Solr plugins that have a Solr home dir pointing somewhere 
> that suddenly has this userfiles dir popping up despite me having no plans to 
> use it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart

2021-03-10 Thread GitBox


HoustonPutman commented on pull request #231:
URL: 
https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-795697523


   No worries at all @chaicesan , I've mainly just been taking care of random 
documentation and licensing issues.
   
   I think this is almost ready to go. I'm going to do some testing first to 
make sure that we don't need to change the Solr operator code at all, and 
everything runs smoothly. I have a bet we will need to do at least one thing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] rmuir commented on a change in pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


rmuir commented on a change in pull request #6:
URL: https://github.com/apache/lucene/pull/6#discussion_r591676924



##
File path: .github/workflows/hunspell.yml
##
@@ -3,7 +3,7 @@ name: Hunspell regression tests
 on:
   pull_request:
 branches:
-  - 'master'
+  - 'main'

Review comment:
   no worries, trust me there is more to fix. i just ran `git grep master` 
and tried to deal with the simplest of them. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15172) Setup Jenkins for new solr repo build

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298943#comment-17298943
 ] 

Uwe Schindler commented on SOLR-15172:
--

Hi,
I already moved the Solr-only Jobs over to new ASF Jenkins folder: 
https://ci-builds.apache.org/job/Solr/
I changed the repository and branch name of all "master" jobs. Finally, I also 
renamed their names: master -> main

> Setup Jenkins for new solr repo build
> -
>
> Key: SOLR-15172
> URL: https://issues.apache.org/jira/browse/SOLR-15172
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Uwe Schindler
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr-operator] chaicesan commented on pull request #231: Add conditional dependency for zk-operator helm chart

2021-03-10 Thread GitBox


chaicesan commented on pull request #231:
URL: 
https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-795679575


   @HoustonPutman Sorry for the delay. I agree that it can be done on release 
so I will remove them today.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591653654



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -102,17 +115,28 @@
 return roots.stream().sorted().collect(Collectors.toList());
   }
 
-  private void filterSuitableEntries(String word, IntsRef forms, 
List> result) {
-result.clear();
-for (int i = 0; i < forms.length; i += dictionary.formStep()) {
-  int entryId = forms.ints[forms.offset + i];
-  if (dictionary.hasFlag(entryId, dictionary.forbiddenword)
-  || dictionary.hasFlag(entryId, dictionary.noSuggest)
-  || dictionary.hasFlag(entryId, Dictionary.HIDDEN_FLAG)
-  || dictionary.hasFlag(entryId, dictionary.onlyincompound)) {
-continue;
+  private static class EntryFilter {
+private final int formStep;
+private final FlagEnumerator.Lookup flagLookup;
+private final char[] excludeFlags;
+
+EntryFilter(Dictionary dic) {
+  formStep = dic.formStep();
+  flagLookup = dic.flagLookup;
+
+  Character[] flags = {HIDDEN_FLAG, dic.noSuggest, dic.forbiddenword, 
dic.onlyincompound};
+  excludeFlags =
+  Dictionary.toSortedCharArray(
+  Stream.of(flags).filter(c -> c != 
FLAG_UNSET).collect(Collectors.toSet()));
+}
+
+int findSuitableFormIndex(IntsRef forms, int start) {
+  for (int i = start; i < forms.length; i += formStep) {
+if (!flagLookup.hasAnyFlag(forms.ints[forms.offset + i], 
excludeFlags)) {

Review comment:
   Here we check up to 4 flags at once





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591653279



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -75,25 +84,29 @@
 return;
   }
 
-  String root = rootChars.toString();
-  filterSuitableEntries(root, forms, entries);
-  if (entries.isEmpty()) return;
+  int suitable = filter.findSuitableFormIndex(forms, 0);
+  if (suitable < 0) return;
 
-  if (ignoreTitleCaseRoots && WordCase.caseOf(rootChars) == 
WordCase.TITLE) {
+  if (ignoreTitleCaseRoots
+  && Character.isUpperCase(rootChars.charAt(0))
+  && WordCase.caseOf(rootChars) == WordCase.TITLE) {
 return;
   }
 
-  String lower = dictionary.toLowerCase(root);
   int sc =
-  automaton.ngramScore(lower)
-  - longerWorsePenalty(word, lower)
-  + commonPrefix(word, root);
+  automaton.ngramScore(rootChars)
+  - longerWorsePenalty(word.length(), rootChars.length)
+  + commonPrefix(word, rootChars);
 
   if (roots.size() == MAX_ROOTS && sc < roots.peek().score) {
 return;
   }
 
-  entries.forEach(e -> roots.add(new Weighted<>(e, sc)));
+  String root = rootChars.toString();

Review comment:
   Only after all checks do we allocate the string and `Root` objects





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591652811



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -75,25 +84,29 @@
 return;
   }
 
-  String root = rootChars.toString();
-  filterSuitableEntries(root, forms, entries);
-  if (entries.isEmpty()) return;
+  int suitable = filter.findSuitableFormIndex(forms, 0);
+  if (suitable < 0) return;
 
-  if (ignoreTitleCaseRoots && WordCase.caseOf(rootChars) == 
WordCase.TITLE) {
+  if (ignoreTitleCaseRoots
+  && Character.isUpperCase(rootChars.charAt(0))
+  && WordCase.caseOf(rootChars) == WordCase.TITLE) {

Review comment:
   `caseOf` walks the entire array, but we don't always need that, e.g. if 
the first letter is lowercase (the majority of entries)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591651869



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -60,9 +63,15 @@
   String word, WordCase originalCase) {
 Comparator>> natural = Comparator.naturalOrder();
 PriorityQueue>> roots = new 
PriorityQueue<>(natural.reversed());
-List> entries = new ArrayList<>();
+EntryFilter filter = new EntryFilter(dictionary);
 boolean ignoreTitleCaseRoots = originalCase == WordCase.LOWER && 
!dictionary.hasLanguage("de");
-TrigramAutomaton automaton = new TrigramAutomaton(word);
+TrigramAutomaton automaton =
+new TrigramAutomaton(word) {
+  @Override
+  char transformChar(char c) {
+return dictionary.caseFold(c);

Review comment:
   We don't lowercase the entire string before calculating ngrams anymore, 
we lowercase each character as we process it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591651352



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -60,9 +63,15 @@
   String word, WordCase originalCase) {
 Comparator>> natural = Comparator.naturalOrder();
 PriorityQueue>> roots = new 
PriorityQueue<>(natural.reversed());
-List> entries = new ArrayList<>();
+EntryFilter filter = new EntryFilter(dictionary);

Review comment:
   and to check for suitability, we create a special object





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591650945



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -60,9 +63,15 @@
   String word, WordCase originalCase) {
 Comparator>> natural = Comparator.naturalOrder();
 PriorityQueue>> roots = new 
PriorityQueue<>(natural.reversed());
-List> entries = new ArrayList<>();

Review comment:
   We don't allocate Root now until we're sure they're suitable, and then 
we add them directly to the PriorityQueue above





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591650328



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/FlagEnumerator.java
##
@@ -79,6 +79,36 @@ boolean hasFlag(int entryId, char flag) {
   return false;
 }
 
+boolean hasAnyFlag(int entryId, char[] sortedFlags) {

Review comment:
   We can check presence of any flag of the given sorted set faster than N 
`hasFlag` calls by walking two sorted arrays simultaneously.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-10 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298925#comment-17298925
 ] 

Robert Muir commented on LUCENE-9827:
-

So for the index sorting case it would be like an "insertion" against a block 
as opposed to "deletion"? 
Maybe the same mechanism could support both, allowing a limited number of 
"patches" against the already-compressed-block. 

For the shorter-term, I wonder if we can tweak the existing logic in the 
meantime, adding a lower-bound on the number of dirty chunks before 
recompressing. Let's start with the minimum possible value (N=2), and then go 
from there? So it is just {{candidate.getNumDirtyChunks() > 1 && ...}}

So it avoids the case where we recompress 1 dirty chunk and potentially produce 
another dirty chunk as a result. There must be at least 2 :) 

something like this:
{code}
  /**
   * Returns true if we should recompress this reader, even though we could 
bulk merge compressed
   * data
   *
   * The last chunk written for a segment is typically incomplete, so 
without recompressing, in
   * some worst-case situations (e.g. frequent reopen with tiny flushes), over 
time the compression
   * ratio can degrade. This is a safety switch.
   */
  boolean tooDirty(Lucene90CompressingStoredFieldsReader candidate) {
// more than 1% dirty, or more than hard limit of 1024 dirty chunks
return candidate.getNumDirtyChunks() > 1024
|| (candidate.getNumDirtyChunks() > 1 && candidate.getNumDirtyDocs() * 
100 > candidate.getNumDocs());
  }
{code}

> Small segments are slower to merge due to stored fields since 8.7
> -
>
> Key: LUCENE-9827
> URL: https://issues.apache.org/jira/browse/LUCENE-9827
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: total-merge-time-by-num-docs-on-small-segments.png
>
>
> [~dm] and [~dimitrisli] looked into an interesting case where indexing slowed 
> down after upgrading to 8.7. After digging we identified that this was due to 
> the merging of stored fields, which had become slower on average.
> This is due to changes to stored fields, which now have top-level blocks that 
> are then split into sub-blocks and compressed using shared dictionaries (one 
> dictionary per top-level block). As the top-level blocks are larger than they 
> were before, segments are more likely to be considered "dirty" by the merging 
> logic. Dirty segments are segments were 1% of the data or more consists of 
> incomplete blocks. For large segments, the size of blocks doesn't really 
> affect the dirtiness of segments: if you flush a segment that has 100 blocks 
> or more, it will never be considered dirty as only the last block may be 
> incomplete. But for small segments it does: for instance if your segment is 
> only 10 blocks, it is very likely considered dirty given that the last block 
> is always incomplete. And the fact that we increased the top-level block size 
> means that segments that used to be considered clean might now be considered 
> dirty.
> And indeed benchmarks reported that while large stored fields merges became 
> slightly faster after upgrading to 8.7, the smaller merges actually became 
> slower. See attached chart, which gives the total merge time as a function of 
> the number of documents in the segment.
> I don't know how we can address this, this is a natural consequence of the 
> larger block size, which is needed to achieve better compression ratios. But 
> I wanted to open an issue about it in case someone has a bright idea how we 
> could make things better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-10 Thread Bruno Roustant (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298918#comment-17298918
 ] 

Bruno Roustant commented on SOLR-15170:
---

PR for the fix added. I plan to backport the fix in branch 8.9 (not in 7.7.2 
where the issue was detected).

> Elevation file in data dir not working in Solr Cloud
> 
>
> Key: SOLR-15170
> URL: https://issues.apache.org/jira/browse/SOLR-15170
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 7.7.2
>Reporter: Monica Marrero
>Assignee: Bruno Roustant
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When using elevation, it is not possible to store the _elevate.xml_ file in 
> the data folder instead of in the configuration folder in Solr Cloud. It is 
> only possible in standalone mode.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15172) Setup Jenkins for new solr repo build

2021-03-10 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298902#comment-17298902
 ] 

Uwe Schindler commented on SOLR-15172:
--

I will work on this a bit later. It's all prepared.

Currently I am waiting for a "solr" folder on ASF Jenkins. I asked for it 
yesterday on builds@ao.

Uwe

> Setup Jenkins for new solr repo build
> -
>
> Key: SOLR-15172
> URL: https://issues.apache.org/jira/browse/SOLR-15172
> Project: Solr
>  Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Uwe Schindler
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] dweiss commented on a change in pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


dweiss commented on a change in pull request #6:
URL: https://github.com/apache/lucene/pull/6#discussion_r591610911



##
File path: .github/workflows/hunspell.yml
##
@@ -3,7 +3,7 @@ name: Hunspell regression tests
 on:
   pull_request:
 branches:
-  - 'master'
+  - 'main'

Review comment:
   ah, damn. missed this and I looked at it!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler merged pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


uschindler merged pull request #6:
URL: https://github.com/apache/lucene/pull/6


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] iverase closed pull request #2446: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-03-10 Thread GitBox


iverase closed pull request #2446:
URL: https://github.com/apache/lucene-solr/pull/2446


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] iverase opened a new pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-03-10 Thread GitBox


iverase opened a new pull request #7:
URL: https://github.com/apache/lucene/pull/7


   See https://issues.apache.org/jira/browse/LUCENE-9820
  https://issues.apache.org/jira/browse/LUCENE-9619. 
   
   This PR introduces a BKDIndexInput abstraction that encapsulates all the 
methods that we need to read the KD index. It introduces a LeafIterator as 
well, which is something we were using already when merging 1 dimensional 
points, but it is formalise now.
   
   The new interface is heavily based on the cursor-style API defined in 
LUCENE-9619. Performance test show the same speed with this approach:
   
   ```
   ||Approach||Shape||M hits/sec  ||QPS||Hit count  ||
||Dev||Base ||Diff||Dev||Base||Diff||Dev||Base||Diff||
   |points|polyRussia|16.26|16.34|-0%|4.63|4.66|-0%|3508846|3508846| 0%|
   |points|polyMedium|9.20|9.05| 2%|112.71|110.84| 2%|2693559|2693559| 0%|
   |points|poly 10|87.81|87.83|-0%|55.53|55.54|-0%|355809475|355809475| 0%|
   |points|box|83.04|83.08|-0%|84.50|84.54|-0%|221118844|221118844| 0%|
   |points|distance|85.57|85.56| 0%|50.31|50.31| 0%|382688713|382688713| 0%|
   |points|nearest 10|0.03|0.03|-1%|2690.61|2727.41|-1%|60844404|60844404| 0%|
   |geo3d|polyRussia|0.66|0.66| 1%|0.19|0.19| 1%|3508671|3508671| 0%|
   |geo3d|polyMedium|0.70|0.71|-0%|8.62|8.66|-0%|2693541|2693541| 0%|
   |geo3d|poly 10|54.23|54.26|-0%|34.29|34.31|-0%|355855227|355855227| 0%|
   |geo3d|box|58.52|59.75|-2%|59.55|60.80|-2%|221118844|221118844| 0%|
   |geo3d|distance|74.51|75.06|-1%|43.73|44.05|-1%|383371904|383371904| 0%|
   |shapes|polyRussia|10.20|10.16| 0%|2.91|2.90| 0%|3508846|3508846| 0%|
   |shapes|polyMedium|3.53|3.65|-3%|43.20|44.74|-3%|2693559|2693559| 0%|
   |shapes|poly 10|42.03|43.66|-4%|26.58|27.61|-4%|355809475|355809475| 0%|
   |shapes|box|43.86|43.88|-0%|44.63|44.65|-0%|221118844|221118844| 0%|
   |shapes|distance|44.58|44.55| 0%|26.19|26.18| 0%|382961957|382961957| 0%|
   ```
   
   This separation is important in order of versioning the codec. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


uschindler commented on pull request #6:
URL: https://github.com/apache/lucene/pull/6#issuecomment-795557750


   I also merged in changes from @rmuir PR #5: The PR template was also adapted 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


uschindler commented on pull request #6:
URL: https://github.com/apache/lucene/pull/6#issuecomment-795554883


   I just copypasted the BUILD.md from lucene, but that was outdated, too.
   
   No more occurences of Solr in the Toplevel README



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on a change in pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


uschindler commented on a change in pull request #6:
URL: https://github.com/apache/lucene/pull/6#discussion_r591593627



##
File path: README.md
##
@@ -31,69 +31,83 @@ comprehensive documentation, visit:
 
 ## Building with Gradle
 
-### Building Lucene
+### Basic steps:
+  
+  0. Install OpenJDK 11 (or greater)
+  1. Download Lucene/Solr from Apache and unpack it
+  2. Connect to the top-level of your installation (parent of the lucene 
top-level directory)
+  3. Install JavaCC (optional)
+  4. Run gradle
 
-See [lucene/BUILD.md](./lucene/BUILD.md).
-
-### Building Solr
-
-Firstly, you need to set up your development environment (OpenJDK 11 or 
greater).
+### Step 0) Set up your development environment (OpenJDK 11 or greater)
 
 We'll assume that you know how to get and set up the JDK - if you
 don't, then we suggest starting at https://www.oracle.com/java/ and learning
-more about Java, before returning to this README. Solr runs with
+more about Java, before returning to this README. Lucene runs with
 Java 11 and later.
 
-As of 9.0, Lucene/Solr uses [Gradle](https://gradle.org/) as the build
-system. Ant build support has been removed.
+Lucene uses [Gradle](https://gradle.org/) for build control.
 
-To build Lucene and Solr, run (`./` can be omitted on Windows):
+NOTE: When Solr moves to a Top Level Project, it will no longer
+be necessary to download Solr to build Lucene. You can track
+progress at: https://issues.apache.org/jira/browse/SOLR-14497 
 
-`./gradlew assemble`
+NOTE: Lucene changed from Ant to Gradle as of release 9.0. Prior releases
+still use Ant.
 
-NOTE: DO NOT use `gradle` command that is already installed on your machine 
(unless you know what you'll do).
-The "gradle wrapper" (gradlew) does the job - downloads the correct version of 
it, setups necessary configurations.
+### Step 1) Checkout/Download Lucene source code
 
-The first time you run Gradle, it will create a file "gradle.properties" that
-contains machine-specific settings. Normally you can use this file as-is, but 
it
-can be modified if necessary.
+We'll assume you already did this, or you wouldn't be reading this
+file. However, you might have received this file by some alternate
+route, or you might have an incomplete copy of the Lucene, so: you 
+can directly checkout the source code from GitHub:
+
+  https://github.com/apache/lucene
+  
+Or Lucene source archives at particlar releases are available as part of 
Lucene downloads:
 
-The command above packages a full distribution of Solr server; the 
-package can be located at:
+  https://lucene.apache.org/core/downloads.html
 
-`solr/packaging/build/solr-*`
+Download either a zip or a tarred/gzipped version of the archive, and
+uncompress it into a directory of your choice.
 
-Note that the gradle build does not create or copy binaries throughout the
-source repository so you need to switch to the packaging output folder above;
-the rest of the instructions below remain identical. The packaging directory 
-is rewritten on each build. 
+### Step 2) Change directory (cd) into the top-level directory of the source 
tree
 
-For development, especially when you have created test indexes etc, use
-the `./gradlew dev` task which will copy binaries to 
`./solr/packaging/build/dev`
-but _only_ overwrite the binaries which will preserve your test setup.
+The parent directory for both Lucene and Solr contains the base configuration
+file for the combined build. By default, you do not need to change any of
+the settings in this file, but you do need to run Gradle from this location so 
+it knows where to find the necessary configurations.
 
-If you want to build the documentation, type `./gradlew -p solr documentation`.
+### Step 4) Run Gradle
 
-## Running Solr
+Assuming you can exectue "./gradlew help" should show you the main tasks that
+can be executed to show help sub-topics.
 
-After [building Solr](#building-lucene-solr), the server can be started using
-the `bin/solr` control scripts.  Solr can be run in either standalone or
-distributed (SolrCloud mode).
+If you want to build Lucene, type:
 
-To run Solr in standalone mode, run the following command from the `solr/`
-directory:
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use `gradle` command that is already installed on your machine 
(unless you know what you'll do).
+The "gradle wrapper" (gradlew) does the job - downloads the correct version of 
it, setups necessary configurations.
+
+The first time you run Gradle, it will create a file "gradle.properties" that
+contains machine-specific settings. Normally you can use this file as-is, but 
it
+can be modified if necessary.
 
-`bin/solr start`
+`./gradlew check` will assemble Lucene/Solr and run all validation

Review comment:
   done

##
File path: README.md
##
@@ -31,69 +31,83 @@ comprehensive documentation, visit:
 
 ## Building with Gradle
 
-### Building Lucene
+### Basic steps:
+  
+  0. Install OpenJDK 11 (or greater)
+  

[GitHub] [lucene] uschindler commented on pull request #5: docs cleanup: README.md and PR template

2021-03-10 Thread GitBox


uschindler commented on pull request #5:
URL: https://github.com/apache/lucene/pull/5#issuecomment-795548073


   I merged your changes into my PR. Closing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler closed pull request #5: docs cleanup: README.md and PR template

2021-03-10 Thread GitBox


uschindler closed pull request #5:
URL: https://github.com/apache/lucene/pull/5


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] janhoy commented on a change in pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


janhoy commented on a change in pull request #6:
URL: https://github.com/apache/lucene/pull/6#discussion_r591580213



##
File path: README.md
##
@@ -31,25 +31,63 @@ comprehensive documentation, visit:
 
 ## Building with Gradle
 
-### Building Lucene
+### Basic steps:
+  
+  0. Install OpenJDK 11 (or greater)
+  1. Download Lucene/Solr from Apache and unpack it

Review comment:
   Download lucene... (well, we don't yet have a release with only 
lucene...)
   
   Also on line 30  -don't need Lucene: as prefix

##
File path: README.md
##
@@ -31,69 +31,83 @@ comprehensive documentation, visit:
 
 ## Building with Gradle
 
-### Building Lucene
+### Basic steps:
+  
+  0. Install OpenJDK 11 (or greater)
+  1. Download Lucene/Solr from Apache and unpack it
+  2. Connect to the top-level of your installation (parent of the lucene 
top-level directory)
+  3. Install JavaCC (optional)
+  4. Run gradle
 
-See [lucene/BUILD.md](./lucene/BUILD.md).
-
-### Building Solr
-
-Firstly, you need to set up your development environment (OpenJDK 11 or 
greater).
+### Step 0) Set up your development environment (OpenJDK 11 or greater)
 
 We'll assume that you know how to get and set up the JDK - if you
 don't, then we suggest starting at https://www.oracle.com/java/ and learning
-more about Java, before returning to this README. Solr runs with
+more about Java, before returning to this README. Lucene runs with
 Java 11 and later.
 
-As of 9.0, Lucene/Solr uses [Gradle](https://gradle.org/) as the build
-system. Ant build support has been removed.
+Lucene uses [Gradle](https://gradle.org/) for build control.
 
-To build Lucene and Solr, run (`./` can be omitted on Windows):
+NOTE: When Solr moves to a Top Level Project, it will no longer
+be necessary to download Solr to build Lucene. You can track
+progress at: https://issues.apache.org/jira/browse/SOLR-14497 
 
-`./gradlew assemble`
+NOTE: Lucene changed from Ant to Gradle as of release 9.0. Prior releases
+still use Ant.
 
-NOTE: DO NOT use `gradle` command that is already installed on your machine 
(unless you know what you'll do).
-The "gradle wrapper" (gradlew) does the job - downloads the correct version of 
it, setups necessary configurations.
+### Step 1) Checkout/Download Lucene source code
 
-The first time you run Gradle, it will create a file "gradle.properties" that
-contains machine-specific settings. Normally you can use this file as-is, but 
it
-can be modified if necessary.
+We'll assume you already did this, or you wouldn't be reading this
+file. However, you might have received this file by some alternate
+route, or you might have an incomplete copy of the Lucene, so: you 
+can directly checkout the source code from GitHub:
+
+  https://github.com/apache/lucene
+  
+Or Lucene source archives at particlar releases are available as part of 
Lucene downloads:
 
-The command above packages a full distribution of Solr server; the 
-package can be located at:
+  https://lucene.apache.org/core/downloads.html
 
-`solr/packaging/build/solr-*`
+Download either a zip or a tarred/gzipped version of the archive, and
+uncompress it into a directory of your choice.
 
-Note that the gradle build does not create or copy binaries throughout the
-source repository so you need to switch to the packaging output folder above;
-the rest of the instructions below remain identical. The packaging directory 
-is rewritten on each build. 
+### Step 2) Change directory (cd) into the top-level directory of the source 
tree
 
-For development, especially when you have created test indexes etc, use
-the `./gradlew dev` task which will copy binaries to 
`./solr/packaging/build/dev`
-but _only_ overwrite the binaries which will preserve your test setup.
+The parent directory for both Lucene and Solr contains the base configuration

Review comment:
   Solr is removed from this repo...

##
File path: README.md
##
@@ -31,25 +31,63 @@ comprehensive documentation, visit:
 
 ## Building with Gradle
 
-### Building Lucene
+### Basic steps:
+  
+  0. Install OpenJDK 11 (or greater)
+  1. Download Lucene/Solr from Apache and unpack it
+  2. Connect to the top-level of your installation (parent of the lucene 
top-level directory)
+  3. Install JavaCC (optional)
+  4. Run gradle
 
-See [lucene/BUILD.md](./lucene/BUILD.md).
-
-### Building Solr
-
-Firstly, you need to set up your development environment (OpenJDK 11 or 
greater).
+### Step 0) Set up your development environment (OpenJDK 11 or greater)
 
 We'll assume that you know how to get and set up the JDK - if you
 don't, then we suggest starting at https://www.oracle.com/java/ and learning
-more about Java, before returning to this README. Solr runs with
+more about Java, before returning to this README. Lucene runs with
 Java 11 and later.
 
-As of 9.0, Lucene/Solr uses [Gradle](https://gradle.org/) as the build
-system. Ant build support has been removed.
+Lucene uses 

[GitHub] [lucene] rmuir commented on pull request #5: docs cleanup: README.md and PR template

2021-03-10 Thread GitBox


rmuir commented on pull request #5:
URL: https://github.com/apache/lucene/pull/5#issuecomment-795537318


   maybe just take the pull request template changes from here and fold into 
your branch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #5: docs cleanup: README.md and PR template

2021-03-10 Thread GitBox


uschindler commented on pull request #5:
URL: https://github.com/apache/lucene/pull/5#issuecomment-795533153


   looks like a duplicate to mine: #6 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15242) Consolidate README.md with solr/README.md

2021-03-10 Thread Jira
Jan Høydahl created SOLR-15242:
--

 Summary: Consolidate README.md with solr/README.md
 Key: SOLR-15242
 URL: https://issues.apache.org/jira/browse/SOLR-15242
 Project: Solr
  Issue Type: Sub-task
Reporter: Jan Høydahl


We have now [https://github.com/apache/solr/blob/main/README.md] and 
[https://github.com/apache/solr/blob/main/solr/README.md] that both try to 
introduce Solr.

While we will keep the solr/ folder for some time for easier patch backport to 
8.x, we can consolidate the README's. Perhaps re-write a smashing good one from 
scratch.

Remember that some users view our github page as the project's homepage, so it 
should give a really good first introduction, without going too deep or 
becoming too long.

See also SOLR-15241 about mentioning Docker



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler opened a new pull request #6: Cleanup readme file and copy build instructions from lucene subfolder…

2021-03-10 Thread GitBox


uschindler opened a new pull request #6:
URL: https://github.com/apache/lucene/pull/6


   …. Also update doap files, remove script clearly used for solr (more to come 
later)
   
   
   
   
   # Description
   
   Please provide a short description of the changes you're making with this 
pull request.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your 
solution.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15241) Mention Docker in main README file

2021-03-10 Thread Jira
Jan Høydahl created SOLR-15241:
--

 Summary: Mention Docker in main README file
 Key: SOLR-15241
 URL: https://issues.apache.org/jira/browse/SOLR-15241
 Project: Solr
  Issue Type: Sub-task
  Security Level: Public (Default Security Level. Issues are Public)
  Components: documentation
Reporter: Jan Høydahl


Our main README.md file that is displayed on github should mention that Solr 
can be run in Docker, through local install or on k8s.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15240) Website: Mention docker

2021-03-10 Thread Jira
Jan Høydahl created SOLR-15240:
--

 Summary: Website: Mention docker
 Key: SOLR-15240
 URL: https://issues.apache.org/jira/browse/SOLR-15240
 Project: Solr
  Issue Type: Sub-task
  Security Level: Public (Default Security Level. Issues are Public)
  Components: website
Reporter: Jan Høydahl


On the Solr website, we should highlight somewhere on the frontpage that Solr 
runs both natively, on Docker and in Kubernetes.

On the downloads page it is also natural to add a link to docker hub and 
solr-operator as ways to "download" solr (convenience binary releases).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (SOLR-14790) Migrate solr/docker usage documentation to the ref-guide

2021-03-10 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SOLR-14790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-14790:
---
Parent: SOLR-15239
Issue Type: Sub-task  (was: Improvement)

> Migrate solr/docker usage documentation to the ref-guide
> 
>
> Key: SOLR-14790
> URL: https://issues.apache.org/jira/browse/SOLR-14790
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Docker, documentation
>Affects Versions: master (9.0)
>Reporter: Houston Putman
>Priority: Major
>
> Documentation of the Solr docker image usage is currently provided in 
> markdown files under solr/docker. These were mainly copied from the 
> [https://github.com/docker-solr/docker-solr] repository.
> This documentation should be modernized and migrated to live in the ref guide 
> so that users have easy access to the information.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Updated] (SOLR-11410) A ref guide page on running solr on docker

2021-03-10 Thread Jira


 [ 
https://issues.apache.org/jira/browse/SOLR-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-11410:
---
Parent: SOLR-15239
Issue Type: Sub-task  (was: Improvement)

> A ref guide page on running solr on docker
> --
>
> Key: SOLR-11410
> URL: https://issues.apache.org/jira/browse/SOLR-11410
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: documentation
>Reporter: Varun Thacker
>Priority: Major
>
> A dedicated ref guide page on run solr on docker
> At the end we could even link to 
> http://lucene.apache.org/solr/guide/6_6/taking-solr-to-production.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (SOLR-15239) Document running Solr on Docker

2021-03-10 Thread Jira
Jan Høydahl created SOLR-15239:
--

 Summary: Document running Solr on Docker
 Key: SOLR-15239
 URL: https://issues.apache.org/jira/browse/SOLR-15239
 Project: Solr
  Issue Type: Improvement
  Security Level: Public (Default Security Level. Issues are Public)
  Components: documentation, website
Reporter: Jan Høydahl


Umbrella issue for adding Docker and k8s as a first-class way of running Solr.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] rmuir opened a new pull request #5: docs cleanup: README.md and PR template

2021-03-10 Thread GitBox


rmuir opened a new pull request #5:
URL: https://github.com/apache/lucene/pull/5


   Just doing the minimal to make these accurate and reflect Lucene



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] janhoy commented on pull request #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin

2021-03-10 Thread GitBox


janhoy commented on pull request #1362:
URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-795483051


   Following up on this. Unfortunately we switched to new git repo today, so 
you'll have to re-open a PR over at https://github.com/apache/solr from this 
branch.
   
   The easiest is perhaps to fork the new repo, then push your branch 
ravowlga123:SOLR-13768 to that fork (it has all the history), and open a new PR 
linking to this one. Or you can export this as a patch (by adding .patch to the 
URL) and then `git apply`..



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15237) Distributed search with index sharding is not working with basic authentication plugin enabled

2021-03-10 Thread Samir Huremovic (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298856#comment-17298856
 ] 

Samir Huremovic commented on SOLR-15237:


In our case it is more about backwards-compatibility. The last few versions 
were updated painlessly and since initially traditional distributed search was 
used, it was kept that way.

Of course if there is some limitation, then it should be documented. For many 
systems this would of course be a big deal (if they cannot use basic auth), but 
at least the situation is clear.

Currently though, it looks more like a bug. And after I had a look at some 
other, similar issues across almost all major versions, it seems that this part 
of the code is a bit fragile.

> Distributed search with index sharding is not working with basic 
> authentication plugin enabled
> --
>
> Key: SOLR-15237
> URL: https://issues.apache.org/jira/browse/SOLR-15237
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Authentication
>Affects Versions: 7.7.3, 8.7, 8.8.1
>Reporter: Samir Huremovic
>Priority: Critical
>  Labels: Authentication
>
> Issue confirmed for 7.7.3, 8.7 and 8.8.1.
> Steps to reproduce are:
> 1. Following the docs for setting up distributed search 
> (https://solr.apache.org/guide/8_8/distributed-search-with-index-sharding.html).
> 1.1 Stop both nodes after confirming that distributed search works without 
> basic auth (last step).
> 2. Enable basic authentication plugin for both nodes, example for node1 
> {{example/nodes/node1/security.json}}:
> {noformat}
> "authentication":{ 
>"blockUnknown": true, 
>"class":"solr.BasicAuthPlugin",
>"credentials":{"solr":"IV0EHq1OnNrj6gvRCwvFwTrZ1+z1oBbnQdiVC3otuq0= 
> Ndd7LKvVBAaZIF0QAVi1ekCfAJXr1GGfLtRUXhgrF8c="}, 
>"realm":"My Solr users", 
>"forwardCredentials": false 
> }}
> {noformat}
> 3. Configure {{shardsWhitelist}} in {{solr.xml}} for both nodes, example for 
> node1 {{example/nodes/node1/solr.xml}}
> {noformat}
>  class="HttpShardHandlerFactory">
> ${socketTimeout:60}
> ${connTimeout:6}
> localhost:8984,localhost:8985
>   
> {noformat}
> 4. Start both nodes.
> 5. Confirm that searching on one node with basic auth works with {{curl 
> --user solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=xml=true"}}
> 6. Confirm that searching on both nodes does not work with {{curl --user 
> solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=true=localhost:8985/solr/core1,localhost:8984/solr/core1=id,name=xml"}}
> Error:
> {noformat}
> ❯ curl --user solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=true=localhost:8985/solr/core1,localhost:8984/solr/core1=id,name=xml;
> 
> 
> 
>   401
>   173
>   
> *:*
>  name="shards">localhost:8985/solr/core1,localhost:8984/solr/core1
> true
> id,name
> xml
>   
> 
> 
>   
>  name="error-class">org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException
>  name="root-error-class">org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException
>   
>   Error from server at null: Expected mime type 
> application/octet-stream but got text/html. html
> head
> meta http-equiv="Content-Type" content="text/html;charset=utf-8"/
> titleError 401 require authentication/title
> /head
> bodyh2HTTP ERROR 401 require authentication/h2
> table
> trthURI:/thtd/solr/core1/select/td/tr
> trthSTATUS:/thtd401/td/tr
> trthMESSAGE:/thtdrequire 
> authentication/td/tr
> trthSERVLET:/thtddefault/td/tr
> /table
> /body
> /html
> 
>   401
> 
> 
> {noformat}
> See also SOLR-14569 that seems similar, but the patch provided does not help 
> after I applied it to 8.8.1, therefore I think this is not the same issue.
> Adjust priority as necessary. For cases where basic auth is required this 
> means we cannot use Solr as of now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] janhoy commented on pull request #1435: SOLR-14410: Switch from SysV init script to systemd service file

2021-03-10 Thread GitBox


janhoy commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-795466909


   Hi @mhitza, this has fallen a bit behind. If you want to have it merged, 
please open a new PR against the new repo https://github.com/apache/solr, 
adding a link to this PR. Then I think there is not much work left to get it in 
to the 9.0 release.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter opened a new pull request #4: LUCENE-9831: Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread GitBox


donnerpeter opened a new pull request #4:
URL: https://github.com/apache/lucene/pull/4


   
   
   
   # Description
   
   Yet another attempt to slim down the CPU usage for each enumerated word
   
   # Solution
   
   Mostly it's avoiding excessive method calls and moving allocations as late 
as possible
   
   # Tests
   
   No new tests, ~5-10% speedup in `TestPerformance.de_suggest`
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##
@@ -63,17 +75,14 @@
*   VINT: a delta pointer to the entry for the same word without the 
last character.
*   Precisely, it's the difference of this entry's start and the 
prefix's entry start. 0 for
*   single-character entries
-   *   Optional, for non-leaf entries only:
+   *   (Optional, for hash-colliding entries only)

Review comment:
   I've moved collision info before the `forms` data to avoid skipping over 
vInts on mismatches





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##
@@ -63,17 +75,14 @@
*   VINT: a delta pointer to the entry for the same word without the 
last character.
*   Precisely, it's the difference of this entry's start and the 
prefix's entry start. 0 for
*   single-character entries
-   *   Optional, for non-leaf entries only:
+   *   (Optional, for hash-colliding entries only)

Review comment:
   I've moved collision pointers before the `forms` data to avoid skipping 
over vInts on mismatches





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##
@@ -63,17 +75,14 @@
*   VINT: a delta pointer to the entry for the same word without the 
last character.
*   Precisely, it's the difference of this entry's start and the 
prefix's entry start. 0 for
*   single-character entries
-   *   Optional, for non-leaf entries only:
+   *   (Optional, for hash-colliding entries only)

Review comment:
   I've moved this before the `forms` data to avoid skipping over vInts on 
mismatches





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591532603



##
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -65,6 +65,7 @@
 TrigramAutomaton automaton = new TrigramAutomaton(word);
 
 dictionary.words.processAllWords(
+Math.max(1, word.length() - 4),

Review comment:
   We now pass minLength in addition to maxLength





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (LUCENE-9831) Hunspell GeneratingSuggester: faster flag & case checks, less allocations

2021-03-10 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9831:


 Summary: Hunspell GeneratingSuggester: faster flag & case checks, 
less allocations
 Key: LUCENE-9831
 URL: https://issues.apache.org/jira/browse/LUCENE-9831
 Project: Lucene - Core
  Issue Type: Sub-task
Reporter: Peter Gromov






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter commented on pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter commented on pull request #3:
URL: https://github.com/apache/lucene/pull/3#issuecomment-795440529


   Solr references probably should be removed from the checklist above



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] donnerpeter opened a new pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread GitBox


donnerpeter opened a new pull request #3:
URL: https://github.com/apache/lucene/pull/3


   
   
   
   # Description
   
   Word length could be checked before more materializing the whole word
   
   # Solution
   
   Use the spare bits in the hash table `int` and collision `byte` to encode 
word length, if it's short enough (almost always).
   
   # Tests
   
   No new tests, 10-15% speedup in `TestPerformance.de_suggest`.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-15237) Distributed search with index sharding is not working with basic authentication plugin enabled

2021-03-10 Thread David Eric Pugh (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298840#comment-17298840
 ] 

David Eric Pugh commented on SOLR-15237:


I was looking at your issue, and one thought is that you may be swimming a bit 
upstream...   I wish 
[https://solr.apache.org/guide/8_8/distributed-search-with-index-sharding.html#limitations-to-distributed-search]
 was a bit more emphatic.   Old "Distributed Search" is okay when you need 
extra copies of a single core collection to handle query load.  

However, once you start sharding, I think you really ought to look again at 
using SolrCloud.  For example, this issue you are facing...  Maybe it's a bug, 
however maybe it's a limitation that ought to be added to the Ref Guide!??   

I feel like these types of issues get a lot more attention in the SolrCloud 
varient versus traditional Distributed Search.

> Distributed search with index sharding is not working with basic 
> authentication plugin enabled
> --
>
> Key: SOLR-15237
> URL: https://issues.apache.org/jira/browse/SOLR-15237
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Authentication
>Affects Versions: 7.7.3, 8.7, 8.8.1
>Reporter: Samir Huremovic
>Priority: Critical
>  Labels: Authentication
>
> Issue confirmed for 7.7.3, 8.7 and 8.8.1.
> Steps to reproduce are:
> 1. Following the docs for setting up distributed search 
> (https://solr.apache.org/guide/8_8/distributed-search-with-index-sharding.html).
> 1.1 Stop both nodes after confirming that distributed search works without 
> basic auth (last step).
> 2. Enable basic authentication plugin for both nodes, example for node1 
> {{example/nodes/node1/security.json}}:
> {noformat}
> "authentication":{ 
>"blockUnknown": true, 
>"class":"solr.BasicAuthPlugin",
>"credentials":{"solr":"IV0EHq1OnNrj6gvRCwvFwTrZ1+z1oBbnQdiVC3otuq0= 
> Ndd7LKvVBAaZIF0QAVi1ekCfAJXr1GGfLtRUXhgrF8c="}, 
>"realm":"My Solr users", 
>"forwardCredentials": false 
> }}
> {noformat}
> 3. Configure {{shardsWhitelist}} in {{solr.xml}} for both nodes, example for 
> node1 {{example/nodes/node1/solr.xml}}
> {noformat}
>  class="HttpShardHandlerFactory">
> ${socketTimeout:60}
> ${connTimeout:6}
> localhost:8984,localhost:8985
>   
> {noformat}
> 4. Start both nodes.
> 5. Confirm that searching on one node with basic auth works with {{curl 
> --user solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=xml=true"}}
> 6. Confirm that searching on both nodes does not work with {{curl --user 
> solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=true=localhost:8985/solr/core1,localhost:8984/solr/core1=id,name=xml"}}
> Error:
> {noformat}
> ❯ curl --user solr:SolrRocks 
> "http://localhost:8984/solr/core1/select?q=*:*=true=localhost:8985/solr/core1,localhost:8984/solr/core1=id,name=xml;
> 
> 
> 
>   401
>   173
>   
> *:*
>  name="shards">localhost:8985/solr/core1,localhost:8984/solr/core1
> true
> id,name
> xml
>   
> 
> 
>   
>  name="error-class">org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException
>  name="root-error-class">org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException
>   
>   Error from server at null: Expected mime type 
> application/octet-stream but got text/html. html
> head
> meta http-equiv="Content-Type" content="text/html;charset=utf-8"/
> titleError 401 require authentication/title
> /head
> bodyh2HTTP ERROR 401 require authentication/h2
> table
> trthURI:/thtd/solr/core1/select/td/tr
> trthSTATUS:/thtd401/td/tr
> trthMESSAGE:/thtdrequire 
> authentication/td/tr
> trthSERVLET:/thtddefault/td/tr
> /table
> /body
> /html
> 
>   401
> 
> 
> {noformat}
> See also SOLR-14569 that seems similar, but the patch provided does not help 
> after I applied it to 8.8.1, therefore I think this is not the same issue.
> Adjust priority as necessary. For cases where basic auth is required this 
> means we cannot use Solr as of now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] donnerpeter closed pull request #2434: LUCENE-9813: Add a convenience constructor IntsRef(int[])

2021-03-10 Thread GitBox


donnerpeter closed pull request #2434:
URL: https://github.com/apache/lucene-solr/pull/2434


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] donnerpeter commented on pull request #2434: LUCENE-9813: Add a convenience constructor IntsRef(int[])

2021-03-10 Thread GitBox


donnerpeter commented on pull request #2434:
URL: https://github.com/apache/lucene-solr/pull/2434#issuecomment-795428309


   OK, if nobody wants this :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (LUCENE-9830) Hunspell: store word length for faster dictionary lookup/enumeration

2021-03-10 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9830:


 Summary: Hunspell: store word length for faster dictionary 
lookup/enumeration
 Key: LUCENE-9830
 URL: https://issues.apache.org/jira/browse/LUCENE-9830
 Project: Lucene - Core
  Issue Type: Sub-task
Reporter: Peter Gromov






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



  1   2   >