mocobeta commented on PR #284:
URL: https://github.com/apache/lucene/pull/284#issuecomment-1120336452
I'm sorry for the late reply, looks good to me, thanks @jimczi !
There are conflicts due to the recent refactoring #805, would you mind if I
adjust this and merge to main?
Now old
[
https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533378#comment-17533378
]
Tomoko Uchida commented on LUCENE-10059:
bq. I am also working on a separate PR to apply the
[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10561:
---
Summary: Reduce class/member visibility of ArabicStemmer, ArabicNormalizer,
and
[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533306#comment-17533306
]
Robert Muir commented on LUCENE-10561:
--
you can just make the entire classes package private.
mocobeta commented on PR #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1120231855
@NightOwl888 I opened https://issues.apache.org/jira/browse/LUCENE-10561 for
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10561:
---
Description:
This is a spin-off of [LUCENE-10312].
Constants and methods in those classes
Tomoko Uchida created LUCENE-10561:
--
Summary: Reduce member visibility of ArabicStemmer,
ArabicNormalizer, and PersianNormalizer
Key: LUCENE-10561
URL: https://issues.apache.org/jira/browse/LUCENE-10561
[ https://issues.apache.org/jira/browse/LUCENE-10397 ]
Lu Xugang deleted comment on LUCENE-10397:
was (Author: chrislu):
Hi [~msoko...@gmail.com] Could we back to use PriorityQueue, and add an Entry
as below to do comparison:
{code:java}
[
https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10312:
---
Attachment: image.png
> Add PersianStemmer
> --
>
> Key:
NightOwl888 commented on PR #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1120222883
@mocobeta - Thanks for merging this. Please let me know the Jira issue
number(s) for the related work on `ArabicStemmer`, `ArabicNormalizer`, and
`PersianNormalizer`.
--
This is an
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120209168
The favicon looks good to me as is, thanks and sorry for the noise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120195919
OK changed it. The transparent one is not good for the headshot icon in the
black bar (the color of bar is defined by jenkins and not easy to change). The
Image is injected by the
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120193605
I think this version is more suitable for small icons if you like this.
(transparent)
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120188747
Oh, thanks!
Yes I filled the hand with white (without border) to put batler's gloves on
Duke.
Maybe Lucene's logo should be larger for a favicon. Let me adjust it.
--
This is an
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120187130
I replaced the logo: https://jenkins.thetaphi.de/
The favicon needs to be transparent, have to figure out how to do this.
Problem are the hands have no border.
--
This is an
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120186289
...and here's the Unicode Policeman version (final). Sorry again I need
something while I'm waiting for a time-consuming batch.
[
https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10312.
Fix Version/s: 10.0 (main)
9.2
Resolution: Fixed
> Add
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120164101
@uschindler Sure, please feel free to download and use it anywhere. It's a
collage of images from [Duke Project
(BSD)](https://wiki.openjdk.java.net/display/duke), Lucene Logo (AL2), and
[
https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533225#comment-17533225
]
ASF subversion and git services commented on LUCENE-10312:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533222#comment-17533222
]
ASF subversion and git services commented on LUCENE-10312:
--
Commit
mocobeta merged PR #540:
URL: https://github.com/apache/lucene/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta commented on PR #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1120161904
I just made a small change on it
https://github.com/apache/lucene/pull/540/commits/050cbf107dbd58a8d82275056a2831e746294afb.
Looks great, thank you @raminmjj and @NightOwl888! I'm
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120159975
Do you allow to place this image on the Policeman Jenkins Server as Logo
instead of the old picture?
--
This is an automated message from the Apache Git Service.
To respond to the
raminmjj commented on PR #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1120148724
Sorry for the delay in responding.
@mocobeta, I applied some changes based on your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message,
24 matches
Mail list logo
