[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933758206 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth +sujitpal,sujitpal,Sujit Pal +befehl,befehl,Bernd Fehling +kmccammon,kmccammon,Keiron McCammon +haydenmuhl,haydenmuhl,Hayden Muhl +ehaubert,ehaubert,Elizabeth Haubert +joeshaw,joeshaw,Joe Shaw Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933758130 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth +sujitpal,sujitpal,Sujit Pal +befehl,befehl,Bernd Fehling +kmccammon,kmccammon,Keiron McCammon +haydenmuhl,haydenmuhl,Hayden Muhl +ehaubert,ehaubert,Elizabeth Haubert Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933758059 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth +sujitpal,sujitpal,Sujit Pal +befehl,befehl,Bernd Fehling +kmccammon,kmccammon,Keiron McCammon +haydenmuhl,haydenmuhl,Hayden Muhl Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933758037 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth +sujitpal,sujitpal,Sujit Pal +befehl,befehl,Bernd Fehling +kmccammon,kmccammon,Keiron McCammon Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757992 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth +sujitpal,sujitpal,Sujit Pal +befehl,befehl,Bernd Fehling Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757913 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne +mdodsworth,mdodsworth,Michael Dodsworth Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757827 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan +klangman,klangman,Kevin Langman +dbyrne,dbyrne,David Byrne Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757768 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor +amdonov,amdonov,Aaron Donovan Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757753 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts +alexvigdor,alexvigdor,Alex Vigdor Review Comment: no activity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757682 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck +jstuyts,jstuyts,Johan Stuyts Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757631 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls +rlauck,rlauck,Ryan Lauck Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757600 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala +muralikpbhat,muralikpbhat,Murali Krishna P +mariusneo,mariusneo,Marius Grama +tsmorton,tsmorton,Tom Morton +jsurls,jsurls,Joey Surls Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757550 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek +emaijala,emaijala,Ere Maijala Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757523 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker +lewismc,lewismc,Lewis John McGibbney +whoschek,whoschek,Wolfgang Hoschek Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757361 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral +nhooey,nhooey,Neil Hooey +steff1193,steff1193,Per Steffensen +hgadre,hgadre,Hrishikesh Gadre +stevenschlansker,stevenschlansker,Steven Schlansker Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757196 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme +alioral,alioral,Ali Oral Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757128 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont +itsadok,itsadok,Israel Tsadok +jaywoo123,jaywoo123,Jaewoo Kim +athoune,athoune,Mathieu Lecarme Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933757020 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun +amccurry,amccurry,Aaron McCurry +mreutegg,mreutegg,Marcel Reutegger +hani,hani,Hani Suleiman +zabetak,zabetak,Stamatis Zampetakis +curtispd,curtispd,Curtis d'Entremont Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756817 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge +wonlay,wonlay,Lei Wang +niqueco,niqueco,Nicolás Lichtmaier +s4ke,s4ke,Martin Braun Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756650 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm +tsturge,tsturge,Tim Sturge Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756613 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard +hlavki,hlavki,Michal Hlavac +dadoonet,dadoonet,David Pilato +oobles,oobles,David Ryan +michael-o,michael-o,Michael Osipov +timmsc,timmsc,Sean Timm Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756426 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella +bleskes,bleskes,Boaz Leskes +ddillard,ddillard,David Dillard Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756364 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera +tdunning,tdunning,Ted Dunning +svella,svella,Shon Vella Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756302 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz +wheijke,wheijke,Wouter Heijke +joecabrera,joecabrera,Joe Cabrera Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756252 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau +adamwalz,adamwalz,Adam Walz Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756237 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman +ofavre,ofavre,Olivier Favre +marklassau,marklassau,Mark Lassau Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756201 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov +jvolkman,jvolkman,Jeremy Volkman Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756139 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt +softwaredoug,softwaredoug,Doug Turnbull +dejannenov,dejannenov,Dejan Nenov Review Comment: no activities -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933756078 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah +shikhar,shikhar,Shikhar Bhushan +iuliux,iuliux,Iulius Curt Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755910 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain +tkrah,tkrah,Torsten Krah Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755862 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski +dakrone,dakrone,Lee Hinman +khitrin,khitrin,Nikolay Khitrin +johtani,johtani,Jun Ohtani +arcadius,arcadius,Arcadius Ahouansou +sstults,sstults,Scott Stults +rnewson,rnewson,Robert Newson +ejain,ejain,Eric Jain Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755640 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El +djelinski,djelinski,Daniel Jelinski Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755582 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li +nyh,nyh,Nadav Har'El Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755522 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith +ningli,ningli,Ning Li Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755477 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves +shebiki,shebiki,Terry Smith Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933755432 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley +iorixxx,iorixxx,Ahmet Arslan +kimchy,kimchy,Shay Banon +lafa,lafa,Luis Alves Review Comment: can't determine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933753981 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch +ryantxu,ryantxu,Ryan McKinley Review Comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta commented on code in PR #87: URL: https://github.com/apache/lucene-jira-archive/pull/87#discussion_r933753794 ## migration/mappings-data/account-map.csv.20220722.verified: ## @@ -179,3 +178,389 @@ wwm1994,wuwm,Weiming Wu hypothesisx86,Tony-X,Tony Xu msfroh,msfroh,Michael Froh nitiraj,nitirajrathore,Nitiraj Rathore +michaelbusch,michaelbusch,Michael Busch Review Comment: no activity in github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #87: Add account mapping where (jira id == github id) && (jira fullname == github fullname)
mocobeta opened a new pull request, #87: URL: https://github.com/apache/lucene-jira-archive/pull/87 These accounts have the same id and full name in both Jira and GitHub. Will do quick manual verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #86: Fix regex capturing mentions
mocobeta merged PR #86: URL: https://github.com/apache/lucene-jira-archive/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #86: Fix regex capturing mentions
mocobeta opened a new pull request, #86: URL: https://github.com/apache/lucene-jira-archive/pull/86 Current regex fails to capture mentions at the beginning of the line.  should be  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #85: Convert jira emojis only when it is preceded and followed by a space character
mocobeta merged PR #85: URL: https://github.com/apache/lucene-jira-archive/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #85: Convert jira emojis only when it is preceded and followed by a space character
mocobeta opened a new pull request, #85: URL: https://github.com/apache/lucene-jira-archive/pull/85 Fixes wrong conversions of Jira emojis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #1: Fix markup conversion error
mocobeta commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1200068772 All issues (LUCENE-1 to LUCENE-10664) were successfully migrated into https://github.com/mocobeta/forks-migration-test/issues I'll manually check if there are major conversion errors and if it looks fine, will open an INFRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573181#comment-17573181
]
Dawid Weiss commented on LUCENE-10662:
--
> Why is it necessary to break the inheritance in order to achieve what is
> wanted here?
I think it's because static imports won't be resolved properly in a subclass if
there's an "assertThat" method in a superclass, which would require the kind of
delegation trickery you mentioned, Mike.
I'm a bit torn on this one, actually. I like aspectj but it does seem like
changing LuceneTestCase's inheritance may be too invasive for both Lucene and
existing downstream projects that rely on it.
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10670) Add Filter class to Codec Writer/Producer/Reader/Consumer/Format
Yuan Xiao created LUCENE-10670: -- Summary: Add Filter class to Codec Writer/Producer/Reader/Consumer/Format Key: LUCENE-10670 URL: https://issues.apache.org/jira/browse/LUCENE-10670 Project: Lucene - Core Issue Type: Wish Reporter: Yuan Xiao Lucene has applied filter pattern to *Path*, *Codec*, Reader etc(FilterPath, FilterCodec, FilterReader) , we should do the same for Writer/Producer/Reader/Consumer/Format(postings, points, doc values, vectors, stored fields, live docs, term vectors) under Codec. One use case is enabling probe the merge time of different file format by making a FilterCodec that overrides the merge method of each Codec format writer through these filters. It will allow downstream to add any additional functionality to those classes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10670) Add Filter class to Codec Writer/Producer/Reader/Consumer/Format
[ https://issues.apache.org/jira/browse/LUCENE-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Xiao updated LUCENE-10670: --- Description: Lucene has applied filter pattern to *Path*, *Codec*, *Reader* etc(FilterPath, FilterCodec, FilterReader) , we should do the same for Writer/Producer/Reader/Consumer/Format(postings, points, doc values, vectors, stored fields, live docs, term vectors) under Codec. One use case is enabling probe the merge time of different file format by making a FilterCodec that overrides the merge method of each Codec format writer through these filters. It will allow downstream to add any additional functionality to those classes. was: Lucene has applied filter pattern to *Path*, *Codec*, Reader etc(FilterPath, FilterCodec, FilterReader) , we should do the same for Writer/Producer/Reader/Consumer/Format(postings, points, doc values, vectors, stored fields, live docs, term vectors) under Codec. One use case is enabling probe the merge time of different file format by making a FilterCodec that overrides the merge method of each Codec format writer through these filters. It will allow downstream to add any additional functionality to those classes. > Add Filter class to Codec Writer/Producer/Reader/Consumer/Format > > > Key: LUCENE-10670 > URL: https://issues.apache.org/jira/browse/LUCENE-10670 > Project: Lucene - Core > Issue Type: Wish >Reporter: Yuan Xiao >Priority: Major > > Lucene has applied filter pattern to *Path*, *Codec*, *Reader* > etc(FilterPath, FilterCodec, FilterReader) , we should do the same for > Writer/Producer/Reader/Consumer/Format(postings, points, doc values, vectors, > stored fields, live docs, term vectors) under Codec. > One use case is enabling probe the merge time of different file format by > making a FilterCodec that overrides the merge method of each Codec format > writer through these filters. > It will allow downstream to add any additional functionality to those > classes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573163#comment-17573163
]
Marios Trivyzas edited comment on LUCENE-10662 at 7/29/22 8:24 PM:
---
Correct me if I'm wrong, but with your suggestion the `MyLuceneTestCase` is
still extending from `org.junit.Assert` and you would need to define in it [all
the different variants of `assertThat`
|https://www.javadoc.io/doc/org.assertj/assertj-core/3.8.0/org/assertj/core/api/Assertions.html]
and also keep this class in sync when you update the assertj lib (probably not
an issues as those methods are pretty much stable).
I'm not trying to force this change to Lucene, we can live with a workaround.
My thoughts though, are that it would be nice, for Lucene as well, to remove
this hard dependency and be able to use different libraries for assertions (if
it's not assertj maybe something even better in the future).
was (Author: matriv):
Correct me if I'm wrong, but with your suggestion the `MyLuceneTestCase` is
still extending from `org.junit.Assert` and you would need to define in it [all
the different variants of `assertThat`
|https://www.javadoc.io/doc/org.assertj/assertj-core/3.8.0/org/assertj/core/api/Assertions.html]
and also keep this class in sync when you update the assertj lib (probably not
an issues as those methods are pretty much stable).
I'm not trying to force this change to Lucene, we can live with a workaround,
my thoughts though are that it would be nice for Lucene as well to remove this
hard dependency and be able to use different libraries for assertions (if it's
not assertj maybe something even better in the future).
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573163#comment-17573163
]
Marios Trivyzas commented on LUCENE-10662:
--
Correct me if I'm wrong, but with your suggestion the `MyLuceneTestCase` is
still extending from `org.junit.Assert` and you would need to define in it [all
the different variants of `assertThat`
|https://www.javadoc.io/doc/org.assertj/assertj-core/3.8.0/org/assertj/core/api/Assertions.html]
and also keep this class in sync when you update the assertj lib (probably not
an issues as those methods are pretty much stable).
I'm not trying to force this change to Lucene, we can live with a workaround,
my thoughts though are that it would be nice for Lucene as well to remove this
hard dependency and be able to use different libraries for assertions (if it's
not assertj maybe something even better in the future).
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10504) KnnGraphTester should use KnnVectorQuery
[ https://issues.apache.org/jira/browse/LUCENE-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573155#comment-17573155 ] ASF subversion and git services commented on LUCENE-10504: -- Commit 2cb0e26075559e4ce38d2fa9765bcccaa187ce0d in lucene's branch refs/heads/branch_9x from Michael Sokolov [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=2cb0e260755 ] LUCENE-10504: KnnGraphTester to use KnnVectorQuery (#796) * LUCENE-10504: KnnGraphTester to use KnnVectorQuery > KnnGraphTester should use KnnVectorQuery > > > Key: LUCENE-10504 > URL: https://issues.apache.org/jira/browse/LUCENE-10504 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Michael Sokolov >Assignee: Michael Sokolov >Priority: Major > Fix For: 10.0 (main) > > Time Spent: 1h 40m > Remaining Estimate: 0h > > to get a more realistic picture, and to track developments in the query > implementation, the tester should use that rather than implementing its own > per-segment search and merging logic. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10663) KnnVectorQuery explain incorrect when multiple segments
[ https://issues.apache.org/jira/browse/LUCENE-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573154#comment-17573154 ] ASF subversion and git services commented on LUCENE-10663: -- Commit 1559de836ce347a8fd8e5ffbbb51fda14f8c16cf in lucene's branch refs/heads/branch_9x from Shiming Li [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=1559de836ce ] LUCENE-10663: Fix KnnVectorQuery explain with multiple segments (#1050) If there are multiple segments. KnnVectorQuery explain has a bug in locating the doc ID. This is because the doc ID in explain is the docBase without the segment. In KnnVectorQuery.DocAndScoreQuery docs docid is increased in each segment of the docBase. So, in the 'DocAndScoreQuery.explain', needs to be added with the segment's docBase. Co-authored-by: Julie Tibshirani > KnnVectorQuery explain incorrect when multiple segments > --- > > Key: LUCENE-10663 > URL: https://issues.apache.org/jira/browse/LUCENE-10663 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: 9.0, 9.1, 9.2 >Reporter: Shiming Li >Priority: Major > Fix For: 9.4 > > Time Spent: 1h > Remaining Estimate: 0h > > If there are multiple segments. KnnVectorQuery explain has a bug in locating > docid. > This is because the docid in explain, which is the docBase without the > segment. > In KnnVectorQuery.DocAndScoreQuery docs docid is increased in each segment of > the docBase. > The two docid are not in the same dimension. > So, in the 'DocAndScoreQuery.explain', needs to be added with the segment's > docBase. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10559) Add preFilter/postFilter options to KnnGraphTester
[ https://issues.apache.org/jira/browse/LUCENE-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573156#comment-17573156 ] ASF subversion and git services commented on LUCENE-10559: -- Commit 33d5ab96f266447b228833baee3489b12bdc3a68 in lucene's branch refs/heads/branch_9x from Kaival Parikh [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=33d5ab96f26 ] LUCENE-10559: Add Prefilter Option to KnnGraphTester (#932) Added a `prefilter` and `filterSelectivity` argument to KnnGraphTester to be able to compare pre and post-filtering benchmarks. `filterSelectivity` expresses the selectivity of a filter as proportion of passing docs that are randomly selected. We store these in a FixedBitSet and use this to calculate true KNN as well as in HNSW search. In case of post-filter, we over-select results as `topK / filterSelectivity` to get final hits close to actual requested `topK`. For pre-filter, we wrap the FixedBitSet in a query and pass it as prefilter argument to KnnVectorQuery. > Add preFilter/postFilter options to KnnGraphTester > -- > > Key: LUCENE-10559 > URL: https://issues.apache.org/jira/browse/LUCENE-10559 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Michael Sokolov >Priority: Major > Fix For: 9.4 > > Time Spent: 6h 40m > Remaining Estimate: 0h > > We want to be able to test the efficacy of pre-filtering in KnnVectorQuery: > if you (say) want the top K nearest neighbors subject to a constraint Q, are > you better off over-selecting (say 2K) top hits and *then* filtering > (post-filtering), or incorporating the filtering into the query > (pre-filtering). How does it depend on the selectivity of the filter? > I think we can get a reasonable testbed by generating a uniform random filter > with some selectivity (that is consistent and repeatable). Possibly we'd also > want to try filters that are correlated with index order, but it seems they'd > be unlikely to be correlated with vector values in a way that the graph > structure would notice, so random is a pretty good starting point for this. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573147#comment-17573147 ] ASF subversion and git services commented on LUCENE-10633: -- Commit 7c9d3cd6ff6c6af153ee756a983dc323133f33c7 in lucene's branch refs/heads/main from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=7c9d3cd6ff6 ] LUCENE-10633: Fix handling of missing values in reverse sorts. > Dynamic pruning for queries sorted by SORTED(_SET) field > > > Key: LUCENE-10633 > URL: https://issues.apache.org/jira/browse/LUCENE-10633 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Fix For: 9.4 > > Time Spent: 20m > Remaining Estimate: 0h > > LUCENE-9280 introduced the ability to dynamically prune non-competitive hits > when sorting by a numeric field, by leveraging the points index to skip > documents that do not compare better than the top of the priority queue > maintained by the field comparator. > However queries sorted by a SORTED(_SET) field still look at all hits, which > is disappointing. Could we leverage the terms index to skip hits? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573148#comment-17573148 ] ASF subversion and git services commented on LUCENE-10633: -- Commit 6366cf2e7ad37dd4f14bb5b7facd3477124073fc in lucene's branch refs/heads/branch_9x from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=6366cf2e7ad ] LUCENE-10633: Fix handling of missing values in reverse sorts. > Dynamic pruning for queries sorted by SORTED(_SET) field > > > Key: LUCENE-10633 > URL: https://issues.apache.org/jira/browse/LUCENE-10633 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Fix For: 9.4 > > Time Spent: 20m > Remaining Estimate: 0h > > LUCENE-9280 introduced the ability to dynamically prune non-competitive hits > when sorting by a numeric field, by leveraging the points index to skip > documents that do not compare better than the top of the priority queue > maintained by the field comparator. > However queries sorted by a SORTED(_SET) field still look at all hits, which > is disappointing. Could we leverage the terms index to skip hits? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] navneet1v commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape
navneet1v commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r933546695
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.document;
+
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.analysis.TokenStream;
+import org.apache.lucene.document.ShapeField.DecodedTriangle.TYPE;
+import org.apache.lucene.document.ShapeField.QueryRelation;
+import org.apache.lucene.geo.Geometry;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.IndexableFieldType;
+import org.apache.lucene.search.Query;
+
+/**
+ * A doc values field for {@link LatLonShape} and {@link XYShape} that uses
{@link ShapeDocValues}
+ * as the underlying binary doc value format.
+ *
+ * Note that this class cannot be instantiated directly due to different
encodings {@link
+ * org.apache.lucene.geo.XYEncodingUtils} and {@link
org.apache.lucene.geo.GeoEncodingUtils}
+ *
+ * Concrete Implementations include: {@link LatLonShapeDocValuesField} and
{@link
+ * XYShapeDocValuesField}
+ *
+ * @lucene.experimental
+ */
+abstract class ShapeDocValuesField extends Field {
Review Comment:
ctor can remain protected but the class `ShapeDocValuesField ` should be
made public so that it can be used.
Or do we want clients to use only the concrete implementation
`LatLonShapeDocValuesField ` and not the abstract class `ShapeDocValuesField`?
The problem with current thing is, a client has to do this:
```
LatLonShapeDocValuesField latLonShapeDocValueField =
(LatLonShapeDocValuesField) LatLonShape.createDocValueField("line", line);
```
rather than this
```
ShapeDocValuesField latLonShapeDocValueField =
LatLonShape.createDocValueField("line", line);
```
Please let me know if I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] navneet1v commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape
navneet1v commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r933546695
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.document;
+
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.analysis.TokenStream;
+import org.apache.lucene.document.ShapeField.DecodedTriangle.TYPE;
+import org.apache.lucene.document.ShapeField.QueryRelation;
+import org.apache.lucene.geo.Geometry;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.IndexableFieldType;
+import org.apache.lucene.search.Query;
+
+/**
+ * A doc values field for {@link LatLonShape} and {@link XYShape} that uses
{@link ShapeDocValues}
+ * as the underlying binary doc value format.
+ *
+ * Note that this class cannot be instantiated directly due to different
encodings {@link
+ * org.apache.lucene.geo.XYEncodingUtils} and {@link
org.apache.lucene.geo.GeoEncodingUtils}
+ *
+ * Concrete Implementations include: {@link LatLonShapeDocValuesField} and
{@link
+ * XYShapeDocValuesField}
+ *
+ * @lucene.experimental
+ */
+abstract class ShapeDocValuesField extends Field {
Review Comment:
ctor can remain protected but the class `ShapeDocValuesField ` should be
made public so that it can be used.
Or do we want clients to use only the concrete implementation
`LatLonShapeDocValuesField ` and not the abstract class `ShapeDocValuesField`?
The problem with current thing is, a client has to do this:
```
LatLonShapeDocValuesField latLonShapeDocValueField =
(LatLonShapeDocValuesField) LatLonShape.createDocValueField("line", line);
```
rather than this
```
ShapeDocValuesField latLonShapeDocValueField =
LatLonShape.createDocValueField("line", line);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tang-hi commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1199833310 @rmuir @dweiss I have added comment in `gradle/generation/moman/createLevAutomata.py` and auto generate the `LevXXXParametricDescription.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tang-hi commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1199831427 @mikemccand I have added the dead state back to method `toDot.` I will first record all state need to be checked. Then bfs the smallest state which hasn't been checked until we have met all state . So, I didn't add a check to find whether the number of states emitted is equal to the number of states in the incoming automaton ,because when the loop has finished, they will be the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-10559) Add preFilter/postFilter options to KnnGraphTester
[ https://issues.apache.org/jira/browse/LUCENE-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-10559. --- Fix Version/s: 9.4 Resolution: Fixed > Add preFilter/postFilter options to KnnGraphTester > -- > > Key: LUCENE-10559 > URL: https://issues.apache.org/jira/browse/LUCENE-10559 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Michael Sokolov >Priority: Major > Fix For: 9.4 > > Time Spent: 6h 40m > Remaining Estimate: 0h > > We want to be able to test the efficacy of pre-filtering in KnnVectorQuery: > if you (say) want the top K nearest neighbors subject to a constraint Q, are > you better off over-selecting (say 2K) top hits and *then* filtering > (post-filtering), or incorporating the filtering into the query > (pre-filtering). How does it depend on the selectivity of the filter? > I think we can get a reasonable testbed by generating a uniform random filter > with some selectivity (that is consistent and repeatable). Possibly we'd also > want to try filters that are correlated with index order, but it seems they'd > be unlikely to be correlated with vector values in a way that the graph > structure would notice, so random is a pretty good starting point for this. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10559) Add preFilter/postFilter options to KnnGraphTester
[ https://issues.apache.org/jira/browse/LUCENE-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573103#comment-17573103 ] ASF subversion and git services commented on LUCENE-10559: -- Commit 1ad28a3136fceb248ef55f2a09e77e7797bef51e in lucene's branch refs/heads/main from Kaival Parikh [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=1ad28a3136f ] LUCENE-10559: Add Prefilter Option to KnnGraphTester (#932) Added a `prefilter` and `filterSelectivity` argument to KnnGraphTester to be able to compare pre and post-filtering benchmarks. `filterSelectivity` expresses the selectivity of a filter as proportion of passing docs that are randomly selected. We store these in a FixedBitSet and use this to calculate true KNN as well as in HNSW search. In case of post-filter, we over-select results as `topK / filterSelectivity` to get final hits close to actual requested `topK`. For pre-filter, we wrap the FixedBitSet in a query and pass it as prefilter argument to KnnVectorQuery. > Add preFilter/postFilter options to KnnGraphTester > -- > > Key: LUCENE-10559 > URL: https://issues.apache.org/jira/browse/LUCENE-10559 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Michael Sokolov >Priority: Major > Time Spent: 6h 40m > Remaining Estimate: 0h > > We want to be able to test the efficacy of pre-filtering in KnnVectorQuery: > if you (say) want the top K nearest neighbors subject to a constraint Q, are > you better off over-selecting (say 2K) top hits and *then* filtering > (post-filtering), or incorporating the filtering into the query > (pre-filtering). How does it depend on the selectivity of the filter? > I think we can get a reasonable testbed by generating a uniform random filter > with some selectivity (that is consistent and repeatable). Possibly we'd also > want to try filters that are correlated with index order, but it seems they'd > be unlikely to be correlated with vector values in a way that the graph > structure would notice, so random is a pretty good starting point for this. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jtibshirani merged pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
jtibshirani merged PR #932: URL: https://github.com/apache/lucene/pull/932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msokolov commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
msokolov commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r933513046
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +794,61 @@ protected int comparePivot(int j) {
return Float.compare(score[pivot], score[j]);
}
}
+
+ private static class SelectiveQuery extends Query {
+
+public float selectivity = 1f;
+private FixedBitSet selectedBits;
+private long cost;
+
+@SuppressForbidden(reason = "Uses Math.random()")
Review Comment:
yes, fine to follow up separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tang-hi commented on a diff in pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
tang-hi commented on code in PR #1016:
URL: https://github.com/apache/lucene/pull/1016#discussion_r933509398
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -589,8 +589,15 @@ public String toDot() {
}
Transition t = new Transition();
-
-for (int state = 0; state < numStates; state++) {
+Queue queue = new ArrayDeque<>();
+Set meet = new HashSet<>();
+queue.add(0);
+while (!queue.isEmpty()) {
Review Comment:
ok, I have changed it from `!` to `== false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10666) Multi-Value Support for Binary DocValues
[ https://issues.apache.org/jira/browse/LUCENE-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573092#comment-17573092 ] Navneet Verma commented on LUCENE-10666: Hi, I was following on the [PR|https://github.com/apache/lucene/pull/1017] and I would like to work on Multi-Value Support for Binary DocValues issue(LUCENE-10666) and was wondering if there are any concerns. > Multi-Value Support for Binary DocValues > > > Key: LUCENE-10666 > URL: https://issues.apache.org/jira/browse/LUCENE-10666 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Nick Knize >Priority: Major > > LUCENE-10654 introduces a binary doc value format for shapes. Since the > geometries are decomposed into triangles the binary docvalue encoding can > technically support multi shapes and geometry collections in a single doc > value format, however it feels this is hacking around the limitation of > supporting multi-values for binary doc values. With multi-value binary > individual geometries can be stored in their own binary doc value w/ multiple > binary per doc. I'd like to open this issue to explore adding multi-value > support to binary doc values. Are there concerns, limitations, traps? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
dweiss commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1199756970 I filed #1053 to perhaps help people in figuring out where the source/target files are. Resource regeneration is a mess but we've talked about it before - it's not quite trivial to implement what we want in gradle. :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10669) The build should be more helpful when generated resources are touched
[
https://issues.apache.org/jira/browse/LUCENE-10669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573059#comment-17573059
]
Dawid Weiss commented on LUCENE-10669:
--
PR is at: [https://github.com/apache/lucene/pull/1053]
Essentially it prints the inputs and outputs of the regeneration task (from
which checksums are computed). It won't help if the sources for generation are
non-files (only properties) but it's better than before?
{code}
> Task :lucene:core:utilGenPackedChecksumCheck FAILED
FAILURE: Build failed with an exception.
* Where:
Script 'C:\Work\apache\lucene\main\gradle\generation\regenerate.gradle' line:
186
* What went wrong:
Execution failed for task ':lucene:core:utilGenPackedChecksumCheck'.
> Checksums mismatch for derived resources; you might have modified a generated
> resource (regenerate task: utilGenPacked):
Current:
lucene/core/src/java/org/apache/lucene/util/packed/Packed64SingleBlock.java=14326081c8c6a281051f9ffe94695d2a467f3db8
Expected:
lucene/core/src/java/org/apache/lucene/util/packed/Packed64SingleBlock.java=2680e0a7c7207ddf615f50fd22465c809904ac42
Input files for this task are:
C:\Work\apache\lucene\main\gradle\generation\moman\gen_BulkOperation.py
C:\Work\apache\lucene\main\gradle\generation\moman\gen_Packed64SingleBlock.py
Files generated by this task are:
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperation.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked1.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked10.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked11.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked12.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked13.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked14.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked15.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked16.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked17.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked18.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked19.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked2.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked20.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked21.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked22.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked23.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked24.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked3.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked4.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked5.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked6.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked7.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked8.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPacked9.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\BulkOperationPackedSingleBlock.java
C:\Work\apache\lucene\main\lucene\core\src\java\org\apache\lucene\util\packed\Packed64SingleBlock.java
{code}
> The build should be more helpful when generated resources are touched
> -
>
> Key: LUCENE-10669
> URL: https://issues.apache.org/jira/browse/LUCENE-10669
> Project: Lucene - Core
> Issue Type: Improvement
>Affects Versions: 10.0 (main)
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
>
> As per discussion at
[jira] [Created] (LUCENE-10669) The build should be more helpful when generated resources are touched
Dawid Weiss created LUCENE-10669: Summary: The build should be more helpful when generated resources are touched Key: LUCENE-10669 URL: https://issues.apache.org/jira/browse/LUCENE-10669 Project: Lucene - Core Issue Type: Improvement Affects Versions: 10.0 (main) Reporter: Dawid Weiss Assignee: Dawid Weiss As per discussion at [https://github.com/apache/lucene/pull/1016,] it'd be good if a build failure could point at the sources and generated files of the task for which checksums are mismatched (signaling either modified templates or accidentally modified generated files). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
jtibshirani commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r933450082
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +794,61 @@ protected int comparePivot(int j) {
return Float.compare(score[pivot], score[j]);
}
}
+
+ private static class SelectiveQuery extends Query {
+
+public float selectivity = 1f;
+private FixedBitSet selectedBits;
+private long cost;
+
+@SuppressForbidden(reason = "Uses Math.random()")
Review Comment:
Sure, we also allow just opening GitHub PRs now with no corresponding JIRA
issue (if that's more convenient).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape
nknize commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r933439887
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.document;
+
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.analysis.TokenStream;
+import org.apache.lucene.document.ShapeField.DecodedTriangle.TYPE;
+import org.apache.lucene.document.ShapeField.QueryRelation;
+import org.apache.lucene.geo.Geometry;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.IndexableFieldType;
+import org.apache.lucene.search.Query;
+
+/**
+ * A doc values field for {@link LatLonShape} and {@link XYShape} that uses
{@link ShapeDocValues}
+ * as the underlying binary doc value format.
+ *
+ * Note that this class cannot be instantiated directly due to different
encodings {@link
+ * org.apache.lucene.geo.XYEncodingUtils} and {@link
org.apache.lucene.geo.GeoEncodingUtils}
+ *
+ * Concrete Implementations include: {@link LatLonShapeDocValuesField} and
{@link
+ * XYShapeDocValuesField}
+ *
+ * @lucene.experimental
+ */
+abstract class ShapeDocValuesField extends Field {
Review Comment:
`LatLonShapeDocValuesField` modifier is now set to public. The ctor is still
protected so `LatLonShape` is used as the factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573029#comment-17573029
]
Michael Sokolov commented on LUCENE-10662:
--
> They can do of course, if LuceneTestCase doesn't extend org.junit.Assert, one
> can easily define an intermediate abstract class between LuceneTestCase and
> their actual test classes and
Why is it necessary to break the inheritance in order to achieve what is wanted
here? Can't we leave LuceneTestCase alone, and define MyLuceneTestCase extends
LuceneTestCase which implements its own static methods `assertWhatever` that is
defined to explicitly call `assertj` implementation. Then implementers of
`MyLuceneTestCase` can get the definition they want, and no changes are
required in Lucene. Maybe if you are not currently inheriting from
LuceneTestCase, you must change to inherit from MyLuceneTestCase, but that is a
small change compared to what is contemplated here.
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-10668) Should we deprecate/remove DocValuesTermsQuery in sandbox?
[
https://issues.apache.org/jira/browse/LUCENE-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10668.
--
Resolution: Won't Fix
> Should we deprecate/remove DocValuesTermsQuery in sandbox?
> --
>
> Key: LUCENE-10668
> URL: https://issues.apache.org/jira/browse/LUCENE-10668
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/sandbox
>Reporter: Greg Miller
>Priority: Minor
>
> I came across the sandbox {{DocValuesTermsQuery}} and it sure looks a lot
> like {{TermInSetQuery}}. I wonder if we ought to deprecate and remove it? Any
> reason to keep this around?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery
[
https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573027#comment-17573027
]
Greg Miller commented on LUCENE-10207:
--
I also just came across {{DocValuesTermsQuery}} in the sandbox module. Once we
see this work through (adding doc value rewrite support to TermInSet), we can
deprecate/remove this.
> Make TermInSetQuery usable with IndexOrDocValuesQuery
> -
>
> Key: LUCENE-10207
> URL: https://issues.apache.org/jira/browse/LUCENE-10207
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Adrien Grand
>Assignee: Greg Miller
>Priority: Minor
> Attachments: LUCENE-10207_multitermquery.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> IndexOrDocValuesQuery is very useful to pick the right execution mode for a
> query depending on other bits of the query tree.
> We would like to be able to use it to optimize execution of TermInSetQuery.
> However IndexOrDocValuesQuery only works well if the "index" query can give
> an estimation of the cost of the query without doing anything expensive (like
> looking up all terms of the TermInSetQuery in the terms dict). Maybe we could
> implement it for primary keys (terms.size() == sumDocFreq) by returning the
> number of terms of the query? Another idea is to multiply the number of terms
> by the average postings length, though this could be dangerous if the field
> has a zipfian distribution and some terms have a much higher doc frequency
> than the average.
> [~romseygeek] and I were discussing this a few weeks ago, and more recently
> [~mikemccand] and [~gsmiller] again independently. So it looks like there is
> interest in this. Here is an email thread where this was recently discussed:
> https://lists.apache.org/thread.html/re3b20a486c9a4e66b2ca4a2646e2d3be48535a90cdd95911a8445183%40%3Cdev.lucene.apache.org%3E.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10668) Should we deprecate/remove DocValuesTermsQuery in sandbox?
[
https://issues.apache.org/jira/browse/LUCENE-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573026#comment-17573026
]
Greg Miller commented on LUCENE-10668:
--
Ha, oops... right [~jpountz]. I've been working on
[LUCENE-10207|https://issues.apache.org/jira/browse/LUCENE-10207] again and had
the new doc value based implementation in the brain. I'll just mention over in
LUCENE-10207 that we can deprecate {{DocValuesTermsQuery}} when we see that
work through. My mistake.
> Should we deprecate/remove DocValuesTermsQuery in sandbox?
> --
>
> Key: LUCENE-10668
> URL: https://issues.apache.org/jira/browse/LUCENE-10668
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/sandbox
>Reporter: Greg Miller
>Priority: Minor
>
> I came across the sandbox {{DocValuesTermsQuery}} and it sure looks a lot
> like {{TermInSetQuery}}. I wonder if we ought to deprecate and remove it? Any
> reason to keep this around?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573022#comment-17573022
]
Marios Trivyzas commented on LUCENE-10662:
--
The changes are imports of the static `org.junit.Assert.xxx` methods, not real
code.
[~rcmuir] I don't get your concern regarding mandatory IDE to write tests,
could you please explain?
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10589) Fix corner case in TestKnnVectorQuery.testRandomWithFilter
[
https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10589:
---
Fix Version/s: (was: 10.0 (main))
(was: 9.4)
> Fix corner case in TestKnnVectorQuery.testRandomWithFilter
> --
>
> Key: LUCENE-10589
> URL: https://issues.apache.org/jira/browse/LUCENE-10589
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Tomoko Uchida
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{TestKnnVectorQuery.testRandomWithFilter}} can fail with
> java.lang.UnsupportedOperationException.
> Reproducible command
> {code:java}
> ./gradlew test --tests TestKnnVectorQuery.testRandomWithFilter
> -Dtests.seed=1DA39B92702DAC45 -Dtests.multiplier=3
> {code}
> {code:java}
> org.apache.lucene.search.TestKnnVectorQuery > testRandomWithFilter FAILED
> java.lang.UnsupportedOperationException: exact search is not supported
> at
> __randomizedtesting.SeedInfo.seed([1DA39B92702DAC45:6BEAC2197AD96AE0]:0)
> at
> org.apache.lucene.search.TestKnnVectorQuery$ThrowingKnnVectorQuery.exactSearch(TestKnnVectorQuery.java:715)
> at
> org.apache.lucene.search.KnnVectorQuery.searchLeaf(KnnVectorQuery.java:151)
> at
> org.apache.lucene.search.KnnVectorQuery.rewrite(KnnVectorQuery.java:108)
> at
> org.apache.lucene.search.ConstantScoreQuery.rewrite(ConstantScoreQuery.java:44)
> at
> org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:789)
> at
> org.apache.lucene.tests.search.AssertingIndexSearcher.rewrite(AssertingIndexSearcher.java:69)
> at
> org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:803)
> at
> org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:685)
> at
> org.apache.lucene.search.IndexSearcher.searchAfter(IndexSearcher.java:667)
> at
> org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:584)
> at
> org.apache.lucene.search.TestKnnVectorQuery.testRandomWithFilter(TestKnnVectorQuery.java:556)
> {code}
> In some edge cases (depending on the random seed),
> [KnnVectorQuery.java#147|https://github.com/apache/lucene/blob/fe9d26178d033f585c08a5e86708063ac0ec0c9e/lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java#L147]
> becomes false, and then `exactSearch()` is called.
> The upper bound of [the test range query
> (filter)|https://github.com/apache/lucene/blob/fe9d26178d033f585c08a5e86708063ac0ec0c9e/lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java#L554]
> could be 200 (the max value of "tag" field + 1) instead of lower + 150 to
> make it "unrestrictive"?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz closed pull request #886: LUCENE-10560: Reduce the number of bytes compared while constructing an OrdinalMap.
jpountz closed pull request #886: LUCENE-10560: Reduce the number of bytes compared while constructing an OrdinalMap. URL: https://github.com/apache/lucene/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #886: LUCENE-10560: Reduce the number of bytes compared while constructing an OrdinalMap.
jpountz commented on PR #886: URL: https://github.com/apache/lucene/pull/886#issuecomment-1199263386 Superseded by #1052. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz closed pull request #875: LUCENE-10560: Speed up OrdinalMap construction a bit.
jpountz closed pull request #875: LUCENE-10560: Speed up OrdinalMap construction a bit. URL: https://github.com/apache/lucene/pull/875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #875: LUCENE-10560: Speed up OrdinalMap construction a bit.
jpountz commented on PR #875: URL: https://github.com/apache/lucene/pull/875#issuecomment-1199262844 Superseded by #1052. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz opened a new pull request, #1052: LUCENE-10560: Faster merging of TermsEnum
jpountz opened a new pull request, #1052: URL: https://github.com/apache/lucene/pull/1052 This commit adds a new `TermsEnumIndex` abstraction in `oal.index` that wraps a `TermsEnum` and an index of the segment that it belongs to, and can be used to create priority queues that merge TermsEnum instances (either from the inverted index or from doc values). In either case, a long that holds the first 8 bytes of the term is computed in order to speed up comparisons. In the doc-values case, `OrdinalMap` also leverages seek-by-ord capabilities to reason about shared prefixes across entire windows of terms to not compare shared prefixes whenever re-ordering the queue, this should especially help with fields that may share long common prefixes like URLs. On luceneutil's `OrdinalMap` benchmark, construction time reduced by 30.5% for the `id` field and by 17.5% for the `name` field. JIRA: [LUCENE-10560](https://issues.apache.org/jira/browse/LUCENE-10560) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a diff in pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
mikemccand commented on code in PR #1016:
URL: https://github.com/apache/lucene/pull/1016#discussion_r933168964
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -616,7 +621,7 @@ public String toDot() {
appendCharString(t.max, b);
}
b.append("\"]\n");
-// System.out.println(" t=" + t);
+queue.add(t.dest);
}
}
Review Comment:
Could we add a simple check at the end of this, confirming that the number
of states emitted is exactly equal to the total number of states in the
incoming automaton?
This would catch accidental bugs in the future that might hide states in
disconnected graphs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a diff in pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata
mikemccand commented on code in PR #1016:
URL: https://github.com/apache/lucene/pull/1016#discussion_r933148269
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -589,8 +589,15 @@ public String toDot() {
}
Transition t = new Transition();
-
-for (int state = 0; state < numStates; state++) {
+Queue queue = new ArrayDeque<>();
+Set meet = new HashSet<>();
+queue.add(0);
+while (!queue.isEmpty()) {
Review Comment:
Could we use `== false` instead of `!`, for better verbosity to reduce the
risk of accidental future bugs on refactoring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572929#comment-17572929
]
Robert Muir commented on LUCENE-10662:
--
I think, when we first exported the test-framework, there may have been some
discussion. But these test classes are *ours* for testing lucene and we also
happen to ship them in case they are useful to someone else.
Somehow the priorities now got inverted where we'll hurt lucene itself to help
some third party, this is wrong.
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572927#comment-17572927
]
Robert Muir commented on LUCENE-10662:
--
I don't really understand the benefit of this change to our codebase. instead
it adds thousands of lines of code, and seems to make it impossible to write
tests without using an IDE :(
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r933082450
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +794,61 @@ protected int comparePivot(int j) {
return Float.compare(score[pivot], score[j]);
}
}
+
+ private static class SelectiveQuery extends Query {
+
+public float selectivity = 1f;
+private FixedBitSet selectedBits;
+private long cost;
+
+@SuppressForbidden(reason = "Uses Math.random()")
Review Comment:
The latest commit incorporates the suggestions. As for the refactor, should
it be a separate issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r933076894
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +794,61 @@ protected int comparePivot(int j) {
return Float.compare(score[pivot], score[j]);
}
}
+
+ private static class SelectiveQuery extends Query {
+
+public float selectivity = 1f;
+private FixedBitSet selectedBits;
+private long cost;
+
+@SuppressForbidden(reason = "Uses Math.random()")
Review Comment:
We currently use command line arguments to pass the configuration
parameters, and hence will be unable to use `RandomizedRunner` (because of
`main` having static context)
Using a `RandomizedRunner` will be beneficial, as we can save on the true
KNN compute step (as we can reproduce the random setting of bits across runs).
The current code does not cache the true KNN results for selective filters
(since it is random and won't produce deterministic results)
This true KNN step takes up bulk of the search time for selective searches
We can:
- Manually add some parameter for the seed, and enable caching of true KNN
results
- Extend `LuceneTestCase` and shift to individual tests (indexing,
searching, etc). This might clean up the code, and make it more readable in
general, but needs a major refactor in my opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r933065705
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -192,6 +207,18 @@ private void run(String... args) throws Exception {
case "-forceMerge":
forceMerge = true;
break;
+case "-prefilter":
+ prefilter = true;
+ break;
+case "-filterSelectivity":
+ if (iarg == args.length - 1) {
+throw new IllegalArgumentException("-filterSelectivity requires a
following float");
+ }
+ selectivity = Float.parseFloat(args[++iarg]);
Review Comment:
Sure, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10633. --- Fix Version/s: 9.4 Resolution: Fixed > Dynamic pruning for queries sorted by SORTED(_SET) field > > > Key: LUCENE-10633 > URL: https://issues.apache.org/jira/browse/LUCENE-10633 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Fix For: 9.4 > > Time Spent: 20m > Remaining Estimate: 0h > > LUCENE-9280 introduced the ability to dynamically prune non-competitive hits > when sorting by a numeric field, by leveraging the points index to skip > documents that do not compare better than the top of the priority queue > maintained by the field comparator. > However queries sorted by a SORTED(_SET) field still look at all hits, which > is disappointing. Could we leverage the terms index to skip hits? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572880#comment-17572880 ] ASF subversion and git services commented on LUCENE-10633: -- Commit 261db55806cd352520e406d5e5a684ce45afa9f4 in lucene's branch refs/heads/branch_9x from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=261db55806c ] LUCENE-10633: Dynamic pruning for sorting on SORTED(_SET) fields. (#1023) This commit enables dynamic pruning for queries sorted on SORTED(_SET) fields by using postings to filter competitive documents. > Dynamic pruning for queries sorted by SORTED(_SET) field > > > Key: LUCENE-10633 > URL: https://issues.apache.org/jira/browse/LUCENE-10633 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > LUCENE-9280 introduced the ability to dynamically prune non-competitive hits > when sorting by a numeric field, by leveraging the points index to skip > documents that do not compare better than the top of the priority queue > maintained by the field comparator. > However queries sorted by a SORTED(_SET) field still look at all hits, which > is disappointing. Could we leverage the terms index to skip hits? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572873#comment-17572873 ] ASF subversion and git services commented on LUCENE-10633: -- Commit eb7b7791ba615dfb52d25fb7e542aab539be293e in lucene's branch refs/heads/main from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=eb7b7791ba6 ] LUCENE-10633: Dynamic pruning for sorting on SORTED(_SET) fields. (#1023) This commit enables dynamic pruning for queries sorted on SORTED(_SET) fields by using postings to filter competitive documents. > Dynamic pruning for queries sorted by SORTED(_SET) field > > > Key: LUCENE-10633 > URL: https://issues.apache.org/jira/browse/LUCENE-10633 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > LUCENE-9280 introduced the ability to dynamically prune non-competitive hits > when sorting by a numeric field, by leveraging the points index to skip > documents that do not compare better than the top of the priority queue > maintained by the field comparator. > However queries sorted by a SORTED(_SET) field still look at all hits, which > is disappointing. Could we leverage the terms index to skip hits? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #1023: LUCENE-10633: Dynamic pruning for sorting on SORTED(_SET) fields.
jpountz merged PR #1023: URL: https://github.com/apache/lucene/pull/1023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572859#comment-17572859
]
Adrien Grand commented on LUCENE-10544:
---
I guess my only concern about this is that there are likely users who rely on
the fact that ExitableDirectoryReader doesn't wrap postings in order to get
good performance for their queries (by not adding a wrapper on every postings
list) while still enabling timeouts via a collector or BulkScorer approach
(e.g. Elasticsearch is in this case).
I would suggest that we wait for IndexSearcher's timeout support to be more
complete (LUCENE-10641) before doing this, so that users never have to wrap
with ExitableDirectoryReader themselves and can instead rely fully on
IndexSearcher doing the right thing.
> Should ExitableTermsEnum wrap postings and impacts?
> ---
>
> Key: LUCENE-10544
> URL: https://issues.apache.org/jira/browse/LUCENE-10544
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Reporter: Greg Miller
>Priority: Major
>
> While looking into options for LUCENE-10151, I noticed that
> {{ExitableDirectoryReader}} doesn't actually do any timeout checking once you
> start iterating postings/impacts. It *does* create a {{ExitableTermsEnum}}
> wrapper when loading a {{{}TermsEnum{}}}, but that wrapper doesn't do
> anything to wrap postings or impacts. So timeouts will be enforced when
> moving to the "next" term, but not when iterating the postings/impacts
> associated with a term.
> I think we ought to wrap the postings/impacts as well with some form of
> timeout checking so timeouts can be enforced on long-running queries. I'm not
> sure why this wasn't done originally (back in 2014), but it was questioned
> back in 2020 on the original Jira SOLR-5986. Does anyone know of a good
> reason why we shouldn't enforce timeouts in this way?
> Related, we may also want to wrap things like {{seekExact}} and {{seekCeil}}
> given that only {{next}} is being wrapped currently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10668) Should we deprecate/remove DocValuesTermsQuery in sandbox?
[
https://issues.apache.org/jira/browse/LUCENE-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572854#comment-17572854
]
Adrien Grand commented on LUCENE-10668:
---
It is like TermInSetQuery except that it operates on doc values instead of the
inverted index?
> Should we deprecate/remove DocValuesTermsQuery in sandbox?
> --
>
> Key: LUCENE-10668
> URL: https://issues.apache.org/jira/browse/LUCENE-10668
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/sandbox
>Reporter: Greg Miller
>Priority: Minor
>
> I came across the sandbox {{DocValuesTermsQuery}} and it sure looks a lot
> like {{TermInSetQuery}}. I wonder if we ought to deprecate and remove it? Any
> reason to keep this around?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data
jpountz commented on PR #987: URL: https://github.com/apache/lucene/pull/987#issuecomment-1199008526 Thanks for running these tests, let's remove `readNBytes` and switch to a shared byte[] that we call `DataInput#readBytes` on instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10589) Fix corner case in TestKnnVectorQuery.testRandomWithFilter
[
https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-10589:
--
Fix Version/s: 9.4
(was: 9.3)
> Fix corner case in TestKnnVectorQuery.testRandomWithFilter
> --
>
> Key: LUCENE-10589
> URL: https://issues.apache.org/jira/browse/LUCENE-10589
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Tomoko Uchida
>Priority: Minor
> Fix For: 10.0 (main), 9.4
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{TestKnnVectorQuery.testRandomWithFilter}} can fail with
> java.lang.UnsupportedOperationException.
> Reproducible command
> {code:java}
> ./gradlew test --tests TestKnnVectorQuery.testRandomWithFilter
> -Dtests.seed=1DA39B92702DAC45 -Dtests.multiplier=3
> {code}
> {code:java}
> org.apache.lucene.search.TestKnnVectorQuery > testRandomWithFilter FAILED
> java.lang.UnsupportedOperationException: exact search is not supported
> at
> __randomizedtesting.SeedInfo.seed([1DA39B92702DAC45:6BEAC2197AD96AE0]:0)
> at
> org.apache.lucene.search.TestKnnVectorQuery$ThrowingKnnVectorQuery.exactSearch(TestKnnVectorQuery.java:715)
> at
> org.apache.lucene.search.KnnVectorQuery.searchLeaf(KnnVectorQuery.java:151)
> at
> org.apache.lucene.search.KnnVectorQuery.rewrite(KnnVectorQuery.java:108)
> at
> org.apache.lucene.search.ConstantScoreQuery.rewrite(ConstantScoreQuery.java:44)
> at
> org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:789)
> at
> org.apache.lucene.tests.search.AssertingIndexSearcher.rewrite(AssertingIndexSearcher.java:69)
> at
> org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:803)
> at
> org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:685)
> at
> org.apache.lucene.search.IndexSearcher.searchAfter(IndexSearcher.java:667)
> at
> org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:584)
> at
> org.apache.lucene.search.TestKnnVectorQuery.testRandomWithFilter(TestKnnVectorQuery.java:556)
> {code}
> In some edge cases (depending on the random seed),
> [KnnVectorQuery.java#147|https://github.com/apache/lucene/blob/fe9d26178d033f585c08a5e86708063ac0ec0c9e/lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java#L147]
> becomes false, and then `exactSearch()` is called.
> The upper bound of [the test range query
> (filter)|https://github.com/apache/lucene/blob/fe9d26178d033f585c08a5e86708063ac0ec0c9e/lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java#L554]
> could be 200 (the max value of "tag" field + 1) instead of lower + 150 to
> make it "unrestrictive"?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10662) Make LuceneTestCase to not extend from org.junit.Assert
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572805#comment-17572805
]
Marios Trivyzas commented on LUCENE-10662:
--
They can do of course, if LuceneTestCase doesn't extend org.junit.Assert, one
can easily define an intermediate abstract class between LuceneTestCase and
their actual test classes and
define their one static assertXXX methods.
> Make LuceneTestCase to not extend from org.junit.Assert
> ---
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
>Reporter: Marios Trivyzas
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r932953915
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -91,6 +101,9 @@ public class KnnGraphTester {
private int beamWidth;
private int maxConn;
private VectorSimilarityFunction similarityFunction;
+ private FixedBitSet matchDocs;
+ private float selectivity;
+ private boolean prefilter;
@SuppressForbidden(reason = "uses Random()")
Review Comment:
Sure, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] navneet1v commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape
navneet1v commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r932902145
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.document;
+
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.analysis.TokenStream;
+import org.apache.lucene.document.ShapeField.DecodedTriangle.TYPE;
+import org.apache.lucene.document.ShapeField.QueryRelation;
+import org.apache.lucene.geo.Geometry;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.IndexableFieldType;
+import org.apache.lucene.search.Query;
+
+/**
+ * A doc values field for {@link LatLonShape} and {@link XYShape} that uses
{@link ShapeDocValues}
+ * as the underlying binary doc value format.
+ *
+ * Note that this class cannot be instantiated directly due to different
encodings {@link
+ * org.apache.lucene.geo.XYEncodingUtils} and {@link
org.apache.lucene.geo.GeoEncodingUtils}
+ *
+ * Concrete Implementations include: {@link LatLonShapeDocValuesField} and
{@link
+ * XYShapeDocValuesField}
+ *
+ * @lucene.experimental
+ */
+abstract class ShapeDocValuesField extends Field {
Review Comment:
Shouldn't the access modifier for this interface and its concrete
implementations should be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
