[GitHub] [lucene] rmuir merged pull request #12087: Graduate DocValuesNumbersQuery from lucene/sandbox to newSlowSetQuery()
rmuir merged PR #12087: URL: https://github.com/apache/lucene/pull/12087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #12087: Graduate DocValuesNumbersQuery from lucene/sandbox to newSlowSetQuery()
rmuir commented on code in PR #12087:
URL: https://github.com/apache/lucene/pull/12087#discussion_r1071265859
##
lucene/core/src/java/org/apache/lucene/document/NumericDocValuesField.java:
##
@@ -97,6 +97,27 @@ SortedNumericDocValues getValues(LeafReader reader, String
field) throws IOExcep
};
}
+ /**
+ * Create a query matching any of the specified values.
+ *
+ * NOTE: Such queries cannot efficiently advance to the next
match, which makes them
+ * slow if they are not ANDed with a selective query. As a consequence, they
are best used wrapped
+ * in an {@link IndexOrDocValuesQuery}, alongside a set query that executes
on points, such as
+ * {@link LongPoint#newSetQuery}.
Review Comment:
oh, duh, thank you. will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on a diff in pull request #12087: Graduate DocValuesNumbersQuery from lucene/sandbox to newSlowSetQuery()
jpountz commented on code in PR #12087:
URL: https://github.com/apache/lucene/pull/12087#discussion_r1071254421
##
lucene/core/src/java/org/apache/lucene/document/NumericDocValuesField.java:
##
@@ -97,6 +97,27 @@ SortedNumericDocValues getValues(LeafReader reader, String
field) throws IOExcep
};
}
+ /**
+ * Create a query matching any of the specified values.
+ *
+ * NOTE: Such queries cannot efficiently advance to the next
match, which makes them
+ * slow if they are not ANDed with a selective query. As a consequence, they
are best used wrapped
+ * in an {@link IndexOrDocValuesQuery}, alongside a set query that executes
on points, such as
+ * {@link LongPoint#newSetQuery}.
Review Comment:
Maybe link to LongField and other similar fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek commented on pull request #12088: Don't throw UOE when highlighting FieldExistsQuery
romseygeek commented on PR #12088: URL: https://github.com/apache/lucene/pull/12088#issuecomment-1383932158 Thanks for the review @mkhludnev! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #12088: Don't throw UOE when highlighting FieldExistsQuery
romseygeek merged PR #12088: URL: https://github.com/apache/lucene/pull/12088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek opened a new pull request, #12088: Don't throw UOE when highlighting FieldExistsQuery
romseygeek opened a new pull request, #12088: URL: https://github.com/apache/lucene/pull/12088 WeightedSpanTermExtractor will try to rewrite queries that it doesn't know about, to see if they end up as something it does know about and that it can extract terms from. To support field merging, it rewrites against a delegating leaf reader that does not support `getFieldInfos()`. FieldExistsQuery uses `getFieldInfos()` in its rewrite, which means that if one is passed to WeightedSpanTermExtractor, we get an UnsupportedOperationException thrown. This commit makes WeightedSpanTermExtractor aware of FieldExistsQuery, so that it can just ignore it and avoid throwing an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
