[GitHub] [lucene] gsmiller commented on pull request #12054: Introduce a new `KeywordField`.
gsmiller commented on PR #12054: URL: https://github.com/apache/lucene/pull/12054#issuecomment-1421143189 > You can make it new IndexOrDocValuesQuery(new TermInSetQuery, SortedSetDocValuesField.newSlowSetQuery()) right now and it performs better than what is on that PR. +1 to using `IndexOrDocValues` for now. Given the feedback in #12089, I'm going to see if I can come up with a way to help `IndexOrDocValuesQuery` make a better decision between postings/doc values for the case it currently doesn't handle well, as opposed to changing the guts of `TermInSetQuery`. I'll benchmark a couple different ideas for that and post a separate PR with what I'm able to come up with. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12054: Introduce a new `KeywordField`.
gsmiller commented on PR #12054: URL: https://github.com/apache/lucene/pull/12054#issuecomment-1385952712 Somewhat related to this PR, I've been experimenting with the idea of a "self optimizing" `TermInSetQuery` implementation that toggles between using postings and doc values based on index statistics, etc. I wanted to link that idea here as it's a bit related (requires indexing both postings and dv, which this PR makes easy). This is just an early idea, but I'll link an early draft here in case anyone is curious or has thoughts: #12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12054: Introduce a new `KeywordField`.
gsmiller commented on PR #12054: URL: https://github.com/apache/lucene/pull/12054#issuecomment-1370089520 +1 to adding this new field definition. Looks like the new test failed in the precommit checks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
