gsmiller opened a new pull request #122:
URL: https://github.com/apache/lucene/pull/122


   # Description
   
   Automatically detect single- vs. multi-value cases instead of asking the 
user to specify.
   
   NOTE: Contains "nocommit" questions in comments that I'd like to resolve 
before modifying tests. Will not pass `check` task yet because of this.
   
   # Solution
   
   Use DocValues helper methods to automatically determine the underlying field 
type.
   
   # Tests
   
   Haven't added anything new yet. All existing tests pass but I plan to 
refresh the unit tests to work against the new ctors if we agree on the 
implementation.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code 
conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Lucene maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to