chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687329334
I withdraw all outstanding concerns. Verbosity,
clunkiness/ineffectiveness/misplacement of configuration
etc are all my "perceptions" that I don't want to come in
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686355702
> @noblepaul & @chatman I find the tone of your latest comments offensive -
that's no way to build a consensus. Please think twice before posting and calm
down - if
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686808345
> Wow. I'm not even sure that would be polite to say to a junior engineer
(that may be presumed to not know concurrency) than a very senior one here.
I don't
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686380223
I broadly agree with those principals, and I'm sure everyone does.
>1. placement plugin writing is easy,
Agree, but not at the cost of complicated
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686320915
> Yeah, the solution to API surface area problem is to make them inner
classes/interfaces. This is such a elegant & simple proposition. We should try
the same in
