[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-25 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r495230006 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -156,36 +155,31 @@ public void submit(final

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-16 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r489203281 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -862,15 +1011,32 @@ public

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-10 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r486657172 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -862,15 +1011,32 @@ public

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-10 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r486536304 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java ## @@ -260,18 +260,13 @@ public final T process(SolrClient client)

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-09 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r486065813 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -537,40 +541,100 @@ public void

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-01 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r481171793 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java ## @@ -112,95 +112,106 @@ public void onFailure(Exception

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-09-01 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r480417292 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -537,40 +541,100 @@ public void

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-08-29 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r479687914 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java ## @@ -82,18 +81,19 @@ protected SolrClient

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-08-23 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r475342747 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ## @@ -853,6 +858,18 @@ public RouteException(ErrorCode

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture

2020-08-20 Thread GitBox
dsmiley commented on a change in pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r474412138 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -156,36 +155,31 @@ public void submit(final