[GitHub] [lucene-solr] shalinmangar commented on a change in pull request #1512: SOLR-13325: Add a collection selector to ComputePlanAction

[GitBox]

shalinmangar commented on a change in pull request #1512:
URL: https://github.com/apache/lucene-solr/pull/1512#discussion_r429042522



##
File path: solr/solr-ref-guide/src/solrcloud-autoscaling-trigger-actions.adoc
##
@@ -29,12 +29,13 @@ commands which can re-balance the cluster in response to 
trigger events.
 The following parameters are configurable:
 
 `collections`::
-A comma-separated list of collection names. If this list is not empty then
-the computed operations will only calculate collection operations that affect
-listed collections and ignore any other collection operations for collections
+A comma-separated list of collection names. This can also be a selector on the 
collection property e.g. `collections: {'policy': 'my_custom_policy'}` will 
match all collections which use the policy named `my_customer_policy`.

Review comment:
   Thanks. I had reworded the description so the `my_custom_policy` and 
`my_customer_policy` are both replaced with `my_policy` everywhere. I'll keep 
the example here because it conveys how to use more than one key/value pair.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] shalinmangar commented on a change in pull request #1512: SOLR-13325: Add a collection selector to ComputePlanAction

[GitBox]

shalinmangar commented on a change in pull request #1512:
URL: https://github.com/apache/lucene-solr/pull/1512#discussion_r426438350



##
File path: 
solr/core/src/java/org/apache/solr/cloud/autoscaling/ComputePlanAction.java
##
@@ -17,38 +17,28 @@
 
 package org.apache.solr.cloud.autoscaling;
 
-import java.io.IOException;
-import java.lang.invoke.MethodHandles;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.concurrent.atomic.AtomicInteger;
-
 import org.apache.solr.client.solrj.SolrRequest;
 import org.apache.solr.client.solrj.cloud.SolrCloudManager;
-import org.apache.solr.client.solrj.cloud.autoscaling.AutoScalingConfig;
-import org.apache.solr.client.solrj.cloud.autoscaling.NoneSuggester;
-import org.apache.solr.client.solrj.cloud.autoscaling.Policy;
-import org.apache.solr.client.solrj.cloud.autoscaling.PolicyHelper;
-import org.apache.solr.client.solrj.cloud.autoscaling.Suggester;
-import org.apache.solr.client.solrj.cloud.autoscaling.UnsupportedSuggester;
+import org.apache.solr.client.solrj.cloud.autoscaling.*;
 import org.apache.solr.common.SolrException;
 import org.apache.solr.common.cloud.ClusterState;
 import org.apache.solr.common.cloud.DocCollection;
 import org.apache.solr.common.cloud.Replica;
 import org.apache.solr.common.params.AutoScalingParams;
 import org.apache.solr.common.params.CollectionParams;
-import org.apache.solr.common.params.CoreAdminParams;
 import org.apache.solr.common.util.Pair;
 import org.apache.solr.common.util.StrUtils;
 import org.apache.solr.core.SolrResourceLoader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.util.*;

Review comment:
   I just imported the project in idea using the gradle scripts. precommit 
also seems happy. I don't recall a rule about wildcards import?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] shalinmangar commented on a change in pull request #1512: SOLR-13325: Add a collection selector to ComputePlanAction

[GitBox]

shalinmangar commented on a change in pull request #1512:
URL: https://github.com/apache/lucene-solr/pull/1512#discussion_r426437892



##
File path: solr/solr-ref-guide/src/solrcloud-autoscaling-trigger-actions.adoc
##
@@ -29,12 +29,13 @@ commands which can re-balance the cluster in response to 
trigger events.
 The following parameters are configurable:
 
 `collections`::
-A comma-separated list of collection names. If this list is not empty then
-the computed operations will only calculate collection operations that affect
-listed collections and ignore any other collection operations for collections
+A comma-separated list of collection names. This can also be a selector on the 
collection property e.g. `collections: {'policy': 'my_custom_policy'}` will 
match all collections which use the policy named `my_customer_policy`.

Review comment:
   Thanks. I expanded the description a bit. I added another example that I 
am not really happy with -- I cannot think of a use-case where something other 
than policy might be useful especially given the fact that values must match 
exactly. Suggestions welcome.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org