[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-12 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176555#comment-17176555 ] Dawid Weiss commented on LUCENE-9439: - It does, doesn't it? I am in favor of your suggestion to

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-12 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176468#comment-17176468 ] Alan Woodward commented on LUCENE-9439: --- This looks fantastic [~dweiss]! We should probably

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-12 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176127#comment-17176127 ] Dawid Weiss commented on LUCENE-9439: - Let me know once you take a peek at it, Alan. No rush. >

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175519#comment-17175519 ] Dawid Weiss commented on LUCENE-9439: - Seems to pass all tests and checks. Works for me in a

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175481#comment-17175481 ] Dawid Weiss commented on LUCENE-9439: - A cleaned up version in the PR. Running tests and checks now.

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172186#comment-17172186 ] Dawid Weiss commented on LUCENE-9439: - Hi Alan. Thank you for your feedback. Works like a charm. The

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168916#comment-17168916 ] Dawid Weiss commented on LUCENE-9439: - Aha! I was hoping for bright insights like this one! I'm

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-31 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168905#comment-17168905 ] Alan Woodward commented on LUCENE-9439: --- Hi Dawid, this looks really interesting.  I think this

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168613#comment-17168613 ] Dawid Weiss commented on LUCENE-9439: - Hi Alan. I've added a patch that shows the PoC highlighter.

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165520#comment-17165520 ] Dawid Weiss commented on LUCENE-9439: - Ok, I see your point now. An iterator returning -1 for both

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165112#comment-17165112 ] Dawid Weiss commented on LUCENE-9439: - Let me return to it on Monday, Alan. I am away for the

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-25 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165049#comment-17165049 ] Alan Woodward commented on LUCENE-9439: --- I wouldn't call it useless data, it works in the same way

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164957#comment-17164957 ] Dawid Weiss commented on LUCENE-9439: - Hmmm. I don't think it is a good idea. If a given query

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-25 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164855#comment-17164855 ] Alan Woodward commented on LUCENE-9439: --- If the issue is just for term queries against fields

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164213#comment-17164213 ] Dawid Weiss commented on LUCENE-9439: - Jim ([~jimczi]) - you were also actively involved in matches

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163384#comment-17163384 ] Dawid Weiss commented on LUCENE-9439: - I tried to make it minimally intrusive and still functional

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162863#comment-17162863 ] Dawid Weiss commented on LUCENE-9439: - Ok, I have a better understanding of the problems here.

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162797#comment-17162797 ] Dawid Weiss commented on LUCENE-9439: - Thanks Alan. Let me see if I can make it work. > Matches

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-22 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162790#comment-17162790 ] Alan Woodward commented on LUCENE-9439: --- +1 - I did try something like this originally, but added