[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163829#comment-17163829 ] Erick Erickson commented on SOLR-13939: --- [~munendrasn] When I was cleaning up a few things in SOLR-13939 I noticed that the method was deprecated in the superclass so I added the annotation. So it was deliberate on my part, whether it it was correct may be debatable ;) > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163740#comment-17163740 ] Munendra S N commented on SOLR-13939: - [~erickerickson] While looking into SOLR-14678, I saw that, this [method|https://github.com/apache/lucene-solr/blob/03a03b34a468f8095c7f0b87ceeaf4ba0d4aeaec/solr/solrj/src/java/org/apache/solr/common/SolrDocument.java#L411] is deprecated. The change was done as part of this JIRA. I couldn't find if it was intended change so, just check it here. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159112#comment-17159112
]
Uwe Schindler commented on SOLR-13939:
--
Hi,
Windows is happy again. I responded to mailing list, here again:
{quote}
In Zookeeper alls paths are forward slashes (as it is a "path" inside the
zookeeper environment). If you replace that with a NIO Windows Path it creates
backslashes. This makes Zookeeper fail (of course).
Actually using the Hadoop class is broken workaround, it may be better to use
the more abstract java.net.URI class for correct "path" transformations. The
risk with java.nio.file.Path is also that if the path exists in file system it
handles the resolving different. So if some user has for some reason a local
path exactly looking like a zookeper node path it would use different behaviour.
So my suggestion: Use java.net.URI to build the path and use URI.getPath() or
similar to make a String out of it. The alternative to replace all backslashes
in the path to forwards slashes is a bad idea for the reasons I explained
before.
{quote}
BTW, Windows is happy again! So you fix helped. Now we should replace the
hadoop class IMHO by java.net.URI.
> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from
> gradle effort
> -
>
> Key: SOLR-13939
> URL: https://issues.apache.org/jira/browse/SOLR-13939
> Project: Solr
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Erick Erickson
>Priority: Major
> Fix For: 8.7
>
> Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158971#comment-17158971 ] Dawid Weiss commented on SOLR-13939: > I think it's wrong to rely on this behavior from org.apache.hadoop.fs.Path in > a class having nothing at all to do with hdfs, (we're constructing Zookeeper > paths) but in the interest of getting Windows working again I'll just revert > that file. I've added comments so we won't trip up here again unknowingly. This seems entirely wrong. File an issue. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158959#comment-17158959 ] Uwe Schindler commented on SOLR-13939: -- Thanks Erick, I reenabled the Windows job. Let's see if it is fixed. Maybe the running out of disk space is caused by this code in the following way (correct me if I am wrong): - The change from Hadoop Path to JDK Path caused all tests related to Zookeeper to fail on windows - As failed tests do not cleanup their output directory, it piled up like 400 worker directories with test data (for "debugging"). - At some point the VM ran out of space If this fixes the issue, I think we should try to replace the HDFS Path by some Zookeeper compatible variant. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158825#comment-17158825 ] ASF subversion and git services commented on SOLR-13939: Commit b394bf7d2d69647a5d414a35c0cf4de5b314b449 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b394bf7 ] SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort. Attmept to fix Windows disk full issues > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158826#comment-17158826 ] ASF subversion and git services commented on SOLR-13939: Commit 9c2e7819eecca48230ba623ab34cb9baf64901f5 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9c2e781 ] SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort. Attmept to fix Windows disk full issues > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158792#comment-17158792 ] Erick Erickson commented on SOLR-13939: --- As per the mailing list response, I think I've found the "smoking gun", I'll push a change in a bit. In ShardLeaderElectionContextBase.java a number of calls like: new Path(leaderPath).getParent().toString(); were replaced with Paths.get(leaderPath).getParent().toString(); But the first is a call to a hadoop class that has special Windows handling to add a leading slash (not even a backslash!) and the nio Paths class doesn't do anything similar. I think it's wrong to rely on this behavior from org.apache.hadoop.fs.Path in a class having nothing at all to do with hdfs, (we're constructing Zookeeper paths) but in the interest of getting Windows working again I'll just revert that file. I've added comments so we won't trip up here again unknowingly. Since I don't have a Windows machine to test with, I'll fix/push and we'll have to see tomorrow whether it's really the fix. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158746#comment-17158746 ] Erick Erickson commented on SOLR-13939: --- [~uschindler] I just looked over that code and don't see any changes I can imagine caused this. That may just mean I lack imagination though. The changes are several, but almost all annotations (SuppressWarnings and Deprecated). The other major change is using Collections.emptyList() rather than Collections.EMPTY_LIST which avoids unchecked warnings. Unfortunately I don't have a Windows box to test on, but I'll see what I can see by backing up to the commit before either of these and examining the size of the output as I add them back in. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158725#comment-17158725 ] Uwe Schindler commented on SOLR-13939: -- Hi, since c346881ad6a4ff61d6776a2a41e5c506f217ef2c was committed it looks like all windows builds fail to finish and instead consume all disk space of the virtual machine. The master branch starting from that commit, but also the 8.x branch consume all available space and then fail with tons of errors. There was a second commit done on the same day, so I am not which one is the cause, but tons of failed tests and 18 Gigabytes of checkout on Windows is a desaster. I had to stop Jenkins Windows builds. Would it be possible to revert this as a test? Or maybe you have an idea. Ideally, please test the build on Windows 10 (with ANT). > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Fix For: 8.7 > > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158608#comment-17158608 ] David Smiley commented on SOLR-13939: - Do not change XmlOffsetCorrector. That's related to SOLR-13990 (move to Alto XML) which is it's own issue and will happen when it's ready. I recommend disregarding little one-off changes from Mark's old branch. I don't like miscellaneous change issues/PR that have no real focus / subject. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158188#comment-17158188 ] Dawid Weiss commented on SOLR-13939: I didn't write this and I don't know why he removed it - it's testing something and it works, right? I'd leave it in. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158157#comment-17158157 ] ASF subversion and git services commented on SOLR-13939: Commit 481f9d1624e5a774668bc031f6ea74293759bed5 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=481f9d1 ] SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort (thread leaks) > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158156#comment-17158156 ] ASF subversion and git services commented on SOLR-13939: Commit f3de646560eefaf2d4f6bf7d9e147e7a84181e91 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f3de646 ] SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort (thread leaks) > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157322#comment-17157322 ] Erick Erickson commented on SOLR-13939: --- Thanks Dawid: I totally agree that having the threads actually not leak is preferable, but we don't always have control in which case they're just noise that distracts from things we actually can fix. I've been wondering about how we test to see if leak problems are fixed in, say, HDFS rather than just accumulate forever. For instance, there's a specific case for a problem with Java9 that will shortly be obsolete when the minimum version is 11... There's also a specific exception for log4j2 etc. But I'll leave that discussion for another time. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157210#comment-17157210 ] Dawid Weiss commented on SOLR-13939: Hi Erick. This annotation (and others from randomizedtesting) is inherited by subclasses but is not cumulative. So you could have one annotation on the top class (which would be most convenient) but you can't "add or remove" filters in subclasses - the redefinition in a subclass is complete. The best way would be for all of those custom thread filters to be removed... The whole point of thread leak detection is to signal that something is wrong... once you let threads slip between test cases you can no longer be sure of the consistency of behavior. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157071#comment-17157071
]
Erick Erickson commented on SOLR-13939:
---
[~dweiss] For once a non-Gradle question I'd like your input on. The PR 1668
adds exceptions to thread leak detection, but some of the same ones are in
superclasses, are the ones in subclasses redundant?
The class hierarchy in one case is:
SolrTestCase
SolrTestCaseJ4
SolrCloudTestCase
CollectionsAPIDistributedZkTest
HdfsCollectionsAPIDistributedZkTest
SolrTestCase has:
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class })
{code}
SolrTestCaseJ4 has
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class,
QuickPatchThreadsFilter.class
})
{code}
and HdfsCollectionsAPIDistributedZkTest
has:
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class,
QuickPatchThreadsFilter.class,
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
})
{code}
Is the inclusion of SolrIgnoredThreadFilter.class and
QuickPatchTHreadsFilter.class redundant given those are in the superclasses?
For that matter, is the SolrIgnoredThreadsFilter also redundant in
SolrTestCaseJ4?
What I have in mind is putting SolrIgnoredThreadsFilter.class and
QuickPatchThradsFilter.class in SolrTestCase and removing them everywhere else
that inherits from SolrTestCase and making other appropriate adjustments. That
depends on multiple @ThreadLeakFilters annotations being additive.
Thanks!
> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from
> gradle effort
> -
>
> Key: SOLR-13939
> URL: https://issues.apache.org/jira/browse/SOLR-13939
> Project: Solr
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Erick Erickson
>Priority: Major
> Attachments: SOLR-13939.patch, eoe_merged.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156444#comment-17156444 ] ASF subversion and git services commented on SOLR-13939: Commit 1ee54905176118eecef600bbb037da42d73215f4 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1ee5490 ] SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156445#comment-17156445 ] ASF subversion and git services commented on SOLR-13939: Commit 1ee54905176118eecef600bbb037da42d73215f4 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1ee5490 ] SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156447#comment-17156447 ] ASF subversion and git services commented on SOLR-13939: Commit c346881ad6a4ff61d6776a2a41e5c506f217ef2c in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c346881 ] SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156448#comment-17156448 ] ASF subversion and git services commented on SOLR-13939: Commit c346881ad6a4ff61d6776a2a41e5c506f217ef2c in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c346881 ] SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156364#comment-17156364 ] Erick Erickson commented on SOLR-13939: --- I'm starting to go through this now. There are three categories, and I'll treat them as separate commits/pushes rather than ask people to wade through a mass of changes, I'll try to group them either logically or in bite-sized chunks. 1> rote stuff. This includes SuppressWarnings, a neat thing Mark found with Collections.emptyList() rather than Collections.EMPTY_LIST not generating unchecked warnings, very minor code cleanups and the like. I'll push this as soon as it passes gw check, ant precommit and ant test.. Some of the changes here have to do with suppressing deprecation warnings, and I'm not including them. First, there aren't very many and second there's a much larger effort under way that should incorporate them all. There are a few annotations that have been added as well as some documentation about what to use instead that I _am_ including. 2> There are about 32 changed files that look to be about thread leaks that we can't do anything about. Many having to do with HDFS but some others scattered about. I'll put them all in a single PR after <1> is done and ask for comments. 3> everything else. There are only about 4 other files that have changed, and all I've done so far is put them on the back burner. When I get to dealing with these, I'll look more carefully and report either here or via a PR. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113407#comment-17113407 ] Erick Erickson commented on SOLR-13939: --- Ah, good point. I'll leave it open then and assign it to myself to get to "sometime" > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113203#comment-17113203
]
Dawid Weiss commented on SOLR-13939:
{quote}bq. Solr test-related fixes (thread leaks, minor changes to zk stuff I
have no idea about).
{quote}
There could be some code/ ideas taken from the above but I'm not able to do it
- I don't know anything about zookeeper. Gradle wise I don't think we can
extract anything more from that branch.
D.
> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from
> gradle effort
> -
>
> Key: SOLR-13939
> URL: https://issues.apache.org/jira/browse/SOLR-13939
> Project: Solr
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Priority: Major
> Attachments: SOLR-13939.patch, eoe_merged.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113193#comment-17113193 ] Erick Erickson commented on SOLR-13939: --- [~dweiss] Should I close this? I think it's totally obsolete > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976157#comment-16976157 ] Dawid Weiss commented on SOLR-13939: Hi Erick. I think many of the changes are worth keeping – I think they should be extracted from the current gradle branch (as a patch) and applied to master, then merged back to this branch. This should be conflict-free. Unfortunately it also has to be a manual process (because you need to take a look at what's been changed and why). Take a look at the patch attached; it's by large just compiler suppression and reverts of things that seem like automatic refactorings (fully qualified names instead of static imports, etc.). Some of this is valuable but it obscures the view of what's really important to the task at hand. If we can somehow declutter the gradle part I think it'd be much better. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Dawid Weiss >Priority: Major > Attachments: SOLR-13939.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976094#comment-16976094 ] Dawid Weiss commented on SOLR-13939: Mark applied many small changes throughout the codebase that deviate the gradle effort from master branch – this complicates looking at what is really the gradle-related stuff and what is not. There are three axes of changes: * gradle-related (build files, dependencies, etc.), * deprecation annotations and other compiler-warning related fixes, * Solr test-related fixes (thread leaks, minor changes to zk stuff I have no idea about). It is really crucial to have these isolated from the gradle branch because it facilitates merging against master and just provides a clearer view of what really is related to the gradle build effort. Deprecation annotations should be applied to the master branch, then merged back to gradle branch. Solr test-related efforts – I have no idea. I don't know that code and test instability is something not related to gradle so I don't think these concerns should be mixed. > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > - > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
