[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220531#comment-17220531
]
Atri Sharma commented on SOLR-14354:
Is this no longer a blocker?
> HttpShardHandler send requests
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220313#comment-17220313
]
Cao Manh Dat commented on SOLR-14354:
-
Done on reverting, thank you [~dsmiley]
> HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220308#comment-17220308
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219994#comment-17219994
]
Mark Robert Miller commented on SOLR-14354:
---
It’s likely a decent improvement, the issue is
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219975#comment-17219975
]
Varun Thacker commented on SOLR-14354:
--
Whenever we've taken flamegraphs (
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219649#comment-17219649
]
David Smiley commented on SOLR-14354:
-
FYI I did last night and +1'ed it.
BUILD SUCCESSFUL
Total
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219012#comment-17219012
]
Cao Manh Dat commented on SOLR-14354:
-
[~dsmiley] can you review the PR that I just pushed?
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219010#comment-17219010
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219008#comment-17219008
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218982#comment-17218982
]
David Smiley commented on SOLR-14354:
-
I started to revert but there are some difficult merge
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217033#comment-17217033
]
Mark Robert Miller commented on SOLR-14354:
---
My main concern would go away with some good
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216748#comment-17216748
]
Ishan Chattopadhyaya commented on SOLR-14354:
-
Oh, and I withdraw my veto.
>
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216744#comment-17216744
]
Ishan Chattopadhyaya commented on SOLR-14354:
-
I think a major non optional change like this
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216711#comment-17216711
]
Cao Manh Dat commented on SOLR-14354:
-
Let's do a vote here, shall we?
I'm +1 with keeping this as
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216677#comment-17216677
]
David Smiley commented on SOLR-14354:
-
What's blocking is that it needs to be reverted from 8.7.
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216596#comment-17216596
]
Atri Sharma commented on SOLR-14354:
Where are we with this issue? This is marked as a blocker for
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204236#comment-17204236
]
Mark Robert Miller commented on SOLR-14354:
---
I don’t think master does much connection reuse or
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202700#comment-17202700
]
Amrit Sarkar commented on SOLR-14354:
-
Hi [~caomanhdat], absolutely. Allow me to catch up with the
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201437#comment-17201437
]
Cao Manh Dat commented on SOLR-14354:
-
[~ichattopadhyaya] sorry but I gave solr-bench a shot and it
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201179#comment-17201179
]
Cao Manh Dat commented on SOLR-14354:
-
Thank Mark for your nice words.
[~ichattopadhyaya] I will
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201067#comment-17201067
]
Ishan Chattopadhyaya commented on SOLR-14354:
-
This doesn't have associated performance
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199558#comment-17199558
]
David Smiley commented on SOLR-14354:
-
It's nice to see you participating in other issues, Mark ;-)
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198892#comment-17198892
]
Mark Robert Miller commented on SOLR-14354:
---
Okay, I'm not really going to be able to give an
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198648#comment-17198648
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198574#comment-17198574
]
Mark Robert Miller commented on SOLR-14354:
---
Good stuff Dat! Great list of issues you have
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179297#comment-17179297
]
Noble Paul commented on SOLR-14354:
---
Let's keep this open till the perf runs are complete. This is a
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175118#comment-17175118
]
Cao Manh Dat commented on SOLR-14354:
-
[~rishisankar] sure, if you can also do the benchmark that
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175025#comment-17175025
]
Rishi Sankar commented on SOLR-14354:
-
[~caomanhdat] I am interested in this work as well, I am down
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174236#comment-17174236
]
Cao Manh Dat commented on SOLR-14354:
-
Ok then I will try my best to run it.
> HttpShardHandler send
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174234#comment-17174234
]
Ishan Chattopadhyaya commented on SOLR-14354:
-
bq. Ishan Chattopadhyaya, fair enough, do you
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174224#comment-17174224
]
Cao Manh Dat commented on SOLR-14354:
-
[~ichattopadhyaya], fair enough, do you want to do the
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174221#comment-17174221
]
Ishan Chattopadhyaya commented on SOLR-14354:
-
For a change like this, I would like to see
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174184#comment-17174184
]
Cao Manh Dat commented on SOLR-14354:
-
Hi [~dsmiley], I will try my best to spend sometime to do
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171757#comment-17171757
]
David Smiley commented on SOLR-14354:
-
It seems there is reasonable consensus on my proposal.
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169136#comment-17169136
]
David Smiley commented on SOLR-14354:
-
My (long) message with proposal:
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169049#comment-17169049
]
David Smiley commented on SOLR-14354:
-
I think public API changes (includes additions) to the
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155870#comment-17155870
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155836#comment-17155836
]
Cao Manh Dat commented on SOLR-14354:
-
Thank you [~erickerickson], I gonna push a fix for this soon.
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155825#comment-17155825
]
Erick Erickson commented on SOLR-14354:
---
[~caomanhdat] This is failing 8x compilations on Jenkins
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155084#comment-17155084
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152629#comment-17152629
]
Noble Paul commented on SOLR-14354:
---
{quote}HttpShardHandler still send requests in async manner, so no
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152611#comment-17152611
]
Cao Manh Dat commented on SOLR-14354:
-
Hi [~noble.paul] your comment is true but here are few things
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152540#comment-17152540
]
Noble Paul commented on SOLR-14354:
---
A lot of requests made by HttpShardHandler are synchronous
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152435#comment-17152435
]
Cao Manh Dat commented on SOLR-14354:
-
The commit end up with solution 1 and letting further
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152430#comment-17152430
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151939#comment-17151939
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148374#comment-17148374
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146187#comment-17146187
]
ASF subversion and git services commented on SOLR-14354:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146178#comment-17146178
]
ASF subversion and git services commented on SOLR-14354:
Commit
49 matches
Mail list logo
