[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242833#comment-17242833 ] Noble Paul commented on SOLR-14613: --- (y) > Provide a clean API for pluggable replica assignment

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241685#comment-17241685 ] Andrzej Bialecki commented on SOLR-14613: - [~noble.paul] tests are added in SOLR-15004. [~ilan] I

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201915#comment-17201915 ] Noble Paul commented on SOLR-14613: --- The 2nd parameter is a varargs parameter.  so, you can set a

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201378#comment-17201378 ] Ilan Ginzburg commented on SOLR-14613: -- [~noble.paul] could we change {{setClusterProperty(String

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201326#comment-17201326 ] ASF subversion and git services commented on SOLR-14613: Commit

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201315#comment-17201315 ] Noble Paul commented on SOLR-14613: --- [~ilan] you are doing multiple ZK write operations in

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197956#comment-17197956 ] ASF subversion and git services commented on SOLR-14613: Commit

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197672#comment-17197672 ] ASF subversion and git services commented on SOLR-14613: Commit

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197261#comment-17197261 ] ASF subversion and git services commented on SOLR-14613: Commit

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192552#comment-17192552 ] Ilan Ginzburg commented on SOLR-14613: -- New PR [https://github.com/apache/lucene-solr/pull/1845]

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191890#comment-17191890 ] Noble Paul commented on SOLR-14613: --- I think we have addressed the API surface area issue. The only

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188084#comment-17188084 ] Noble Paul commented on SOLR-14613: --- We are making a Frankenstein framework which is getting harder day

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187110#comment-17187110 ] Ilan Ginzburg commented on SOLR-14613: -- Latest commit groups implementation classes for property

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187107#comment-17187107 ] Ilan Ginzburg commented on SOLR-14613: -- Placement plugins need access to global cloud configuration

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187004#comment-17187004 ] Ilan Ginzburg commented on SOLR-14613: -- ??Why can't "existing placement strategies" also be a

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187000#comment-17187000 ] Ilan Ginzburg commented on SOLR-14613: -- The question here is do we want plugin code to get the

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186986#comment-17186986 ] Ishan Chattopadhyaya commented on SOLR-14613: - bq. Assign.createAssignStrategy() picks

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186985#comment-17186985 ] Ishan Chattopadhyaya commented on SOLR-14613: - bq. About half changed classes in this PR are

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186978#comment-17186978 ] Erick Erickson commented on SOLR-14613: --- I was hoping some generics magic would make it less

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186938#comment-17186938 ] Ilan Ginzburg commented on SOLR-14613: -- I would definitely love to have more eyeballs on this

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186936#comment-17186936 ] Ilan Ginzburg commented on SOLR-14613: -- How is the number of files a measure of anything? Why not

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186896#comment-17186896 ] Ishan Chattopadhyaya commented on SOLR-14613: - bq. bq. using a strongly typed approach

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186893#comment-17186893 ] Ishan Chattopadhyaya commented on SOLR-14613: - I think the problem is with this unnecessary

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186891#comment-17186891 ] Noble Paul commented on SOLR-14613: --- -1 for this to merge into core. There are 108 files. This should

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170222#comment-17170222 ] Ilan Ginzburg commented on SOLR-14613: -- I do have the unpleasant impression since I started work on

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170108#comment-17170108 ] Noble Paul commented on SOLR-14613: --- {quote}Would be happy to get a bit more context on the value this

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170070#comment-17170070 ] Ilan Ginzburg commented on SOLR-14613: -- This is feedback on [~noble.paul]'s [PR for alternate

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169661#comment-17169661 ] Ilan Ginzburg commented on SOLR-14613: -- I'm getting closer to being happy with the interfaces. Will

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169617#comment-17169617 ] Ilan Ginzburg commented on SOLR-14613: -- In [PR 1684|https://github.com/apache/lucene-solr/pull/1684]

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164590#comment-17164590 ] Ilan Ginzburg commented on SOLR-14613: -- I did a few minor changes in the PR

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164040#comment-17164040 ] Ilan Ginzburg commented on SOLR-14613: -- I have updated the PR 

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162864#comment-17162864 ] Ilan Ginzburg commented on SOLR-14613: -- BTW, as part of that clean API for plugins, in my opinion we