[ 
https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julie Tibshirani updated LUCENE-9628:
-------------------------------------
    Description: 
I noticed a few places where we are directly check the {{ScoreMode}} type that 
should perhaps be generalized. These could affect whether numeric sort 
optimization is applied:
 * In {{BooleanWeight#bulkScorer}}, we check if score mode is {{TOP_SCORES}} 
and if so, force non-bulk scoring. Should we expand this to include modes like 
{{TOP_DOCS}}?
 * In {{ConstantScoreQuery}}, we create the delegate weight with a hardcoded 
{{COMPLETE_NO_SCORES}}. I'm not sure it actually causes problems, but it seems 
like this doesn't handle {{TOP_DOCS}} correctly.

Apologies this issue isn’t more precise – I am not up-to-speed on the numeric 
sort optimization but wanted to raise these in case they’re helpful.

  was:
I noticed a few places where we are directly check the {{ScoreMode}} type that 
should perhaps be generalized. These could affect whether numeric sort 
optimization is applied:
 * In {{BooleanWeight#bulkScorer}}, we check if score mode is {{TOP_SCORES}} 
and if so, force non-bulk scoring. Should we expand this to include modes like 
{{TOP_DOCS}}?
 * In {{ConstantScoreQuery}}, we create the delegate weight with a hardcoded 
{{COMPLETE_NO_SCORES}}. I'm not sure this has a real effect, but it seems like 
this doesn't handle {{TOP_DOCS}} correctly.

Apologies this issue isn’t more precise – I am not up-to-speed on the numeric 
sort optimization but wanted to raise these in case they’re helpful.


> Make sure to account for ScoreMode.TOP_DOCS in queries
> ------------------------------------------------------
>
>                 Key: LUCENE-9628
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9628
>             Project: Lucene - Core
>          Issue Type: Test
>          Components: core/search
>            Reporter: Julie Tibshirani
>            Priority: Minor
>
> I noticed a few places where we are directly check the {{ScoreMode}} type 
> that should perhaps be generalized. These could affect whether numeric sort 
> optimization is applied:
>  * In {{BooleanWeight#bulkScorer}}, we check if score mode is {{TOP_SCORES}} 
> and if so, force non-bulk scoring. Should we expand this to include modes 
> like {{TOP_DOCS}}?
>  * In {{ConstantScoreQuery}}, we create the delegate weight with a hardcoded 
> {{COMPLETE_NO_SCORES}}. I'm not sure it actually causes problems, but it 
> seems like this doesn't handle {{TOP_DOCS}} correctly.
> Apologies this issue isn’t more precise – I am not up-to-speed on the numeric 
> sort optimization but wanted to raise these in case they’re helpful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to