[GitHub] [maven] caidezhi commented on issue #284: [refactor] use utility method of Objects to simplify code

2019-09-10 Thread GitBox
caidezhi commented on issue #284: [refactor] use utility method of Objects to simplify code URL: https://github.com/apache/maven/pull/284#issuecomment-530247079 @rfscholte I am sorry that the pull request cause some inconveniences (forget that my IDEA setting is "-Dcheckstyle.skip=true").

[jira] [Resolved] (MNG-6761) 3.6.2 builds are unsigned

2019-09-10 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MNG-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved MNG-6761. -- Resolution: Fixed We have fixed the KEYS file > 3.6.2 builds are unsigned >

[jira] [Assigned] (MNG-6761) 3.6.2 builds are unsigned

2019-09-10 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MNG-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned MNG-6761: Assignee: Enrico Olivelli > 3.6.2 builds are unsigned > - > >

[jira] [Commented] (MNG-6656) Introduce base for build/consumer pom

2019-09-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926875#comment-16926875 ] Hudson commented on MNG-6656: - Build unstable in Jenkins: Maven TLP » maven » MNG-6656 #12 See

[jira] [Commented] (MNG-6747) Generalize 'resume from' message when build reactor fails

2019-09-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926873#comment-16926873 ] Hudson commented on MNG-6747: - Build unstable in Jenkins: Maven TLP » maven » MNG-6656 #12 See

[jira] [Commented] (MNG-6760) [REGRESSION] ExclusionArtifactFilter result invalid when wildcard exclusion is followed by other exclusions

2019-09-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926874#comment-16926874 ] Hudson commented on MNG-6760: - Build unstable in Jenkins: Maven TLP » maven » MNG-6656 #12 See

[jira] [Commented] (MNG-6695) Improve speed in collection merging

2019-09-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926872#comment-16926872 ] Hudson commented on MNG-6695: - Build unstable in Jenkins: Maven TLP » maven » MNG-6656 #12 See

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-09-10 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-530054837 @jon-bell @Col-E Thx for reply. I am busy this week and my colleagues have been busy too. I will try to have

[GitHub] [maven-surefire] jon-bell commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-09-10 Thread GitBox
jon-bell commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-530045715 @Tibor17 do you have any thoughts about refactoring `toClassMethdoNameWithoutPlan`?

[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible

2019-09-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926785#comment-16926785 ] Robert Scholte commented on MCOMPILER-397: -- The {{jpms.args}} was introduced

[GitHub] [maven] rfscholte commented on issue #284: [refactor] use utility method of Objects to simplify code

2019-09-10 Thread GitBox
rfscholte commented on issue #284: [refactor] use utility method of Objects to simplify code URL: https://github.com/apache/maven/pull/284#issuecomment-530018937 @caidezhi next time please run `mvn verify` on the project before creating a PR. You would have noticed that checkstyle would ha

[jira] [Commented] (MNG-6761) 3.6.2 builds are unsigned

2019-09-10 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MNG-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926682#comment-16926682 ] Enrico Olivelli commented on MNG-6761: -- [~michael-o] I am sorry, it seems that I never

[jira] [Comment Edited] (MNG-6275) ServiceLoaderFactory can't find implementations via ClassRealm

2019-09-10 Thread Matthias Hild (Jira)
[ https://issues.apache.org/jira/browse/MNG-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926655#comment-16926655 ] Matthias Hild edited comment on MNG-6275 at 9/10/19 1:47 PM: - T

[jira] [Comment Edited] (MNG-6761) 3.6.2 builds are unsigned

2019-09-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926642#comment-16926642 ] Michael Osipov edited comment on MNG-6761 at 9/10/19 1:45 PM: --

[jira] [Comment Edited] (SCM-883) ScmFileSet DEFAULT_EXCLUDES too restrictive

2019-09-10 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SCM-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926651#comment-16926651 ] Konrad Windszus edited comment on SCM-883 at 9/10/19 1:44 PM: --

[jira] [Comment Edited] (MNG-6275) ServiceLoaderFactory can't find implementations via ClassRealm

2019-09-10 Thread Matthias Hild (Jira)
[ https://issues.apache.org/jira/browse/MNG-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926655#comment-16926655 ] Matthias Hild edited comment on MNG-6275 at 9/10/19 1:42 PM: - T

[jira] [Commented] (MNG-6275) ServiceLoaderFactory can't find implementations via ClassRealm

2019-09-10 Thread Matthias Hild (Jira)
[ https://issues.apache.org/jira/browse/MNG-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926655#comment-16926655 ] Matthias Hild commented on MNG-6275: This is issue is rightfully marked as critical and

[jira] [Commented] (SCM-883) ScmFileSet DEFAULT_EXCLUDES too restrictive

2019-09-10 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SCM-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926651#comment-16926651 ] Konrad Windszus commented on SCM-883: - Why is changing the default excludes problematic?

[jira] [Commented] (MNG-6761) 3.6.2 builds are unsigned

2019-09-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926642#comment-16926642 ] Michael Osipov commented on MNG-6761: - [~eolivelli], did you upload yuor public GPG key

[jira] [Commented] (SUREFIRE-1694) Surefire silently skips tests in presence of transitive dependency

2019-09-10 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926626#comment-16926626 ] Tibor Digana commented on SUREFIRE-1694: [~allenevans] I cannot say what you a

[jira] [Created] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible

2019-09-10 Thread Emmanuel Bourg (Jira)
Emmanuel Bourg created MCOMPILER-397: Summary: Use relative paths in jpms.args to make the builds reproducible Key: MCOMPILER-397 URL: https://issues.apache.org/jira/browse/MCOMPILER-397 Project: