[GitHub] [maven-surefire] Tibor17 merged pull request #263: Use Surefire's StringUtils instead of JUnit's

2020-01-20 Thread GitBox
Tibor17 merged pull request #263: Use Surefire's StringUtils instead of JUnit's URL: https://github.com/apache/maven-surefire/pull/263 This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Updated] (MCHECKSTYLE-388) Update internal dependencies with low impact

2020-01-20 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated MCHECKSTYLE-388: Fix Version/s: 3.1.1 > Update internal dependencies with low impact >

[jira] [Comment Edited] (MCHECKSTYLE-384) Incompatibility to Checkstyle version >= 8.24

2020-01-20 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019868#comment-17019868 ] Benjamin Marwell edited comment on MCHECKSTYLE-384 at 1/21/20 5:59 AM: ---

[jira] [Commented] (MCHECKSTYLE-384) Incompatibility to Checkstyle version >= 8.24

2020-01-20 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019868#comment-17019868 ] Benjamin Marwell commented on MCHECKSTYLE-384: -- Can you link the be iss

[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576521256 Yes I did it offline. We aren't using github api or the 'merge button'

[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
hazendaz commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-576475632 I now believe the original concern is in-line support for new items. That should be opened as a separate tic

[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b…

2020-01-20 Thread GitBox
hazendaz commented on issue #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b… URL: https://github.com/apache/maven-checkstyle-plugin/pull/25#issuecomment-576475139 I don't know of a better option here and it was extremely time consuming testing back and forth wit

[GitHub] [maven-checkstyle-plugin] hazendaz opened a new pull request #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b…

2020-01-20 Thread GitBox
hazendaz opened a new pull request #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b… URL: https://github.com/apache/maven-checkstyle-plugin/pull/25 …ack to 'null' default The severity setting even on original logic is incorrect. It must remain null if it i

[jira] [Created] (MCHECKSTYLE-389) MCHECKSTYLE-365 introduces regression with 'rules' aggregate count section on report

2020-01-20 Thread Jeremy Landis (Jira)
Jeremy Landis created MCHECKSTYLE-389: - Summary: MCHECKSTYLE-365 introduces regression with 'rules' aggregate count section on report Key: MCHECKSTYLE-389 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE

[jira] [Commented] (MCHECKSTYLE-384) Incompatibility to Checkstyle version >= 8.24

2020-01-20 Thread Jeremy Landis (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019765#comment-17019765 ] Jeremy Landis commented on MCHECKSTYLE-384: --- I'm going to open a new issue

[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576450685 @eolivelli No inconvenience. Everything is there. I always double check before pushing back up to my remo

[GitHub] [maven-surefire] sormuras opened a new pull request #266: Upgrade JUnit to 5.6 and JQwik to 1.2.2

2020-01-20 Thread GitBox
sormuras opened a new pull request #266: Upgrade JUnit to 5.6 and JQwik to 1.2.2 URL: https://github.com/apache/maven-surefire/pull/266 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576432689 @hazendaz I have squashed all of the commits into one. Do you think I lost some of them? Can y

[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576429045 @eolivelli Question for you. I've never seen a rebase seemingly appear to no longer have commits. Is this

[GitHub] [maven-checkstyle-plugin] hazendaz closed pull request #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
hazendaz closed pull request #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23 This is an automated message from the Apache Git Service. To res

[GitHub] [maven-filtering] khmarbaise commented on issue #4: [MRESOURCES-250] - Add ability to flatten folder structure into target directory when copying resources

2020-01-20 Thread GitBox
khmarbaise commented on issue #4: [MRESOURCES-250] - Add ability to flatten folder structure into target directory when copying resources URL: https://github.com/apache/maven-filtering/pull/4#issuecomment-576402624 So first we check what our CI says... https://builds.apache.org/view/M-R/v

[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
hazendaz commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-576381801 I'm not sure I entirely follow. Everyone is already told to override checkstyle for updates and adjust conf

[jira] [Commented] (MNGSITE-388) Need to change "property" to "system property" in POM Reference

2020-01-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019654#comment-17019654 ] Robert Scholte commented on MNGSITE-388: They are not the same. And Maven makes

[jira] [Commented] (MCHECKSTYLE-388) Update internal dependencies with low impact

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019630#comment-17019630 ] Hudson commented on MCHECKSTYLE-388: Build failed in Jenkins: Maven TLP » maven-

[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-576349042 I am not sure we should merge this change now that we are cutting 3.1.1 this release wants to open the way

[jira] [Assigned] (MCHECKSTYLE-388) Update internal dependencies with low impact

2020-01-20 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned MCHECKSTYLE-388: --- Assignee: Enrico Olivelli > Update internal dependencies with low impac

[jira] [Resolved] (MCHECKSTYLE-388) Update internal dependencies with low impact

2020-01-20 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved MCHECKSTYLE-388. - Resolution: Fixed committed to master branch, thank you [~hazendaz] > Updat

[GitHub] [maven-surefire] marcphilipp opened a new pull request #265: Delete is{Not}Blank from internal StringUtils

2020-01-20 Thread GitBox
marcphilipp opened a new pull request #265: Delete is{Not}Blank from internal StringUtils URL: https://github.com/apache/maven-surefire/pull/265 Use org.apache.maven.surefire.shared.utils.StringUtils instead. This is an autom

[GitHub] [maven-checkstyle-plugin] rnveach commented on a change in pull request #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
rnveach commented on a change in pull request #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#discussion_r368561399 ## File path: src/it/MCHECKSTYLE-357/pom.xml ## @@ -55,9 +60,7 @@

[GitHub] [maven-surefire] marcphilipp commented on issue #263: Use Surefire's StringUtils instead of JUnit's

2020-01-20 Thread GitBox
marcphilipp commented on issue #263: Use Surefire's StringUtils instead of JUnit's URL: https://github.com/apache/maven-surefire/pull/263#issuecomment-576267507 I changed it, please take another look! This is an automated mes

[jira] [Created] (MRELEASE-1038) releaseProfiles get overriden by exec.pomFileName

2020-01-20 Thread Benoit MESSAGER (Jira)
Benoit MESSAGER created MRELEASE-1038: - Summary: releaseProfiles get overriden by exec.pomFileName Key: MRELEASE-1038 URL: https://issues.apache.org/jira/browse/MRELEASE-1038 Project: Maven Release

[GitHub] [maven-checkstyle-plugin] eolivelli commented on a change in pull request #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
eolivelli commented on a change in pull request #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#discussion_r368428045 ## File path: src/it/MCHECKSTYLE-357/pom.xml ## @@ -55,9 +60,7 @@

[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact

2020-01-20 Thread GitBox
eolivelli commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576172288 waiting for https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-388/