[GitHub] [maven-surefire] akomakom edited a comment on pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom edited a comment on pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#issuecomment-620308686 @Tibor17 this is based on the 288 branch, I'll rebase after that's merged. ~~I couldn't figure out how to test this... I'd have to mock File.isFile() which

[GitHub] [maven-surefire] akomakom commented on pull request #289: SUREFIRE-1784 Set java home from jvm

2020-04-27 Thread GitBox
akomakom commented on pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#issuecomment-620308686 @Tibor17 this is based on the 288 branch, I'll rebase after that's merged. I couldn't figure out how to test this... I'd have to mock File.isFile() which seems

[jira] [Updated] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-27 Thread Akom (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akom updated SUREFIRE-1784: --- External issue URL: https://github.com/apache/maven-surefire/pull/289 > Fork JVM defined by jvm parameter

[jira] [Updated] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-27 Thread Akom (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akom updated SUREFIRE-1784: --- Affects Version/s: 3.0.0-M5 > Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven

[jira] [Updated] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-27 Thread Akom (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akom updated SUREFIRE-1784: --- Affects Version/s: (was: 3.0.0-M5) 3.0.0-M4 > Fork JVM defined by jvm

[GitHub] [maven-surefire] akomakom opened a new pull request #289: SUREFIRE-1784 Set java home from jvm

2020-04-27 Thread GitBox
akomakom opened a new pull request #289: URL: https://github.com/apache/maven-surefire/pull/289 Similar to #288 but for the jvm parameter. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-27 Thread Akom (Jira)
Akom created SUREFIRE-1784: -- Summary: Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process Key: SUREFIRE-1784 URL: https://issues.apache.org/jira/browse/SUREFIRE-1784 Project:

[GitHub] [maven-surefire] akomakom commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620267640 Good to know, will open a separate PR This is an automated message from the Apache Git Service. To

[jira] [Updated] (MRESOURCES-257) property from list element in pom model

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOURCES-257: -- Fix Version/s: 3.1.1 > property from list element in pom model >

[jira] [Commented] (MRESOURCES-257) property from list element in pom model

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093977#comment-17093977 ] Michael Osipov commented on MRESOURCES-257: --- This works with 3.1.1-SNAPSHOT flawlessly. >

[jira] [Moved] (MRESOURCES-257) property from list element in pom model

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MNG-6356 to MRESOURCES-257: Fix Version/s: (was: wontfix-candidate)

[jira] [Commented] (MNG-2478) add "resources-filtered" filtered resource directories to super POM

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093975#comment-17093975 ] Hudson commented on MNG-2478: - Build succeeded in Jenkins: Maven TLP » maven » master #404 See

[jira] [Closed] (MNG-6217) Creating a WARNING by using executions in pluginManagement

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6217. --- > Creating a WARNING by using executions in pluginManagement >

[jira] [Closed] (MNG-2478) add "resources-filtered" filtered resource directories to super POM

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-2478. --- Resolution: Fixed Fixed with

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
Tibor17 edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620240243 We have a

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620240243 We have a

[GitHub] [maven-surefire] akomakom edited a comment on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620230177 > @akomakom but the people would expect some service from us. They normally do not look into our code forcing the jvm this way. We can set the JAVA_HOME unless

[GitHub] [maven-surefire] akomakom commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620230177 > @akomakom but the people would expect some service from us. They normally do not look into our code forcing the jvm this way. We can set the JAVA_HOME unless already

[GitHub] [maven-surefire] akomakom commented on a change in pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom commented on a change in pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#discussion_r416141616 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -47,7 +49,7 @@

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
Tibor17 commented on a change in pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#discussion_r416140830 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -47,7 +49,7 @@ *

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620223653 @akomakom but the people would expect some service from us. They normally do not look into our code forcing the jvm this way. We can set the JAVA_HOME unless already set,

[GitHub] [maven-surefire] akomakom commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
akomakom commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620221768 > We have the same problem in the option when [if ( isNotEmpty( jvm )

[GitHub] [maven-assembly-plugin] elharo opened a new pull request #19: [MASSEMBLY-935] fix JDOM dependencies

2020-04-27 Thread GitBox
elharo opened a new pull request #19: URL: https://github.com/apache/maven-assembly-plugin/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (MASSEMBLY-935) remove unused dependencies

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MASSEMBLY-935: --- Assignee: Elliotte Rusty Harold > remove unused dependencies >

[jira] [Assigned] (MNG-2478) add "resources-filtered" filtered resource directories to super POM

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-2478: --- Assignee: Michael Osipov > add "resources-filtered" filtered resource directories to super

[jira] [Updated] (MNG-2478) add "resources-filtered" filtered resource directories to super POM

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-2478: Fix Version/s: (was: needing-scrub-3.4.0-fallout) 3.7.0 > add

[jira] [Updated] (MNG-6054) Remove super POM plugin management section

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6054: Fix Version/s: 4.0.x-candidate > Remove super POM plugin management section >

[jira] [Assigned] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-5577: --- Assignee: (was: Michael Osipov) > Convert the core to use JSR 330 and remove the use of

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: [SUREFIRE-1783] Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620202503 We have the same problem in the option when [if ( isNotEmpty( jvm )

[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093882#comment-17093882 ] Michael Osipov commented on DOXIA-540: -- As for the external resources, I am quite certain they are

[GitHub] [maven-surefire] Tibor17 commented on pull request #287: SUREFIRE-1782 Exclude explicitly configured env vars

2020-04-27 Thread GitBox
Tibor17 commented on pull request #287: URL: https://github.com/apache/maven-surefire/pull/287#issuecomment-620187228 @akomakom Thx for contributing again  This is an automated message from the Apache Git Service. To

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620186330 Here is the Jira ticket created. https://issues.apache.org/jira/browse/SUREFIRE-1783 This is an

[jira] [Created] (SUREFIRE-1783) Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process

2020-04-27 Thread Tibor Digana (Jira)
Tibor Digana created SUREFIRE-1783: -- Summary: Fork JVM defined by Toolchain should not inherit JAVA_HOME from Maven process Key: SUREFIRE-1783 URL: https://issues.apache.org/jira/browse/SUREFIRE-1783

[jira] [Closed] (SUREFIRE-1782) Configured Environment Variables do not take effect unless also added to excludedEnvironmentVariables

2020-04-27 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1782. -- Resolution: Fixed

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620182261 I forgot to ask you for a unit test. it;s easy. Just prepare the `DefaultJavaToolChain` and call it with `Whitebox.invokeMethod`. We should expect a path in the assertion.

[jira] [Commented] (MNG-6672) Upgrade Maven Resolver to 1.4.2

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093859#comment-17093859 ] Hudson commented on MNG-6672: - Build succeeded in Jenkins: Maven TLP » maven » master #403 See

[GitHub] [maven-surefire] akomakom commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
akomakom commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620170999 I'm no stranger to force pushing :) This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620169605 I will merge #287 but then you have to override this PR. The first two commits will be in conflict with one squashed commit.

[jira] [Commented] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093837#comment-17093837 ] Michael Osipov commented on MNG-5577: - Moved fix version to 3.7.x because we likely won't be able to

[jira] [Updated] (MNG-6898) Convert DefaultLifecyclePluginAnalyzer to JSR 330

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6898: Parent: MNG-5577 Issue Type: Sub-task (was: Improvement) > Convert

[jira] [Updated] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5577: Fix Version/s: (was: 3.7.0) 3.7.x-candidate > Convert the core to use JSR 330

[jira] [Updated] (MNG-6898) Convert DefaultLifecyclePluginAnalyzer to JSR 330

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6898: Affects Version/s: 3.6.3 > Convert DefaultLifecyclePluginAnalyzer to JSR 330 >

[jira] [Closed] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6737. --- Resolution: Fixed MNG-6672 has been resolved, so has this issue. > StackOverflowError when version

[jira] [Closed] (MNG-6672) Upgrade Maven Resolver to 1.4.2

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6672. --- Resolution: Fixed Fixed with

[jira] [Created] (MASSEMBLY-935) remove unused dependencies

2020-04-27 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MASSEMBLY-935: --- Summary: remove unused dependencies Key: MASSEMBLY-935 URL: https://issues.apache.org/jira/browse/MASSEMBLY-935 Project: Maven Assembly Plugin

[jira] [Assigned] (MCHANGES-385) JIRA Report for Changes plugin Invalid browse URL for issueManagement

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MCHANGES-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MCHANGES-385: -- Assignee: (was: Elliotte Rusty Harold) > JIRA Report for

[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093736#comment-17093736 ] Elliotte Rusty Harold commented on DOXIA-540: - Turns out I did "Remove ancient information

[jira] [Updated] (MRESOLVER-105) Update Plexus ?

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-105: - Summary: Update Plexus ? (was: Updte plexus) > Update Plexus ? > --- > >

[GitHub] [maven-surefire] akomakom edited a comment on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
akomakom edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620089356 > You think that the java process won't set/override the JAVA_HOME for itself even if we did not specify it in the list of env for the inheritance? I can

[GitHub] [maven-surefire] akomakom edited a comment on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
akomakom edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620089356 > You think that the java process won't set/override the JAVA_HOME for itself even if we did not specify it in the list of env for the inheritance? I can

[GitHub] [maven-surefire] akomakom commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
akomakom commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620089356 > You think that the java process won't set/override the JAVA_HOME for itself even if we did not specify it in the list of env for the inheritance? I can tell you

[GitHub] [maven-surefire] akomakom commented on pull request #287: SUREFIRE-1782 Exclude explicitly configured env vars

2020-04-27 Thread GitBox
akomakom commented on pull request #287: URL: https://github.com/apache/maven-surefire/pull/287#issuecomment-620087672 @Tibor17 I think this is ready to merge, I was going to look into tests but haven't had much time. I tested this locally (manually), and also #288 works (locally) as

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620070432 You think that the java process won't set/override the JAVA_HOME for itself even if we did not specify it in the list of env for the inheritance?

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620070432 You think that the java process won't set/override the JAVA_HOME for itself if we did not specify it in the list of env for the inheritance?

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 edited a comment on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620070432 You think that the java process won't set/override the JAVA_HOME for itself if we did not specify it in the list of env?

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620070432 You think that the java process wil not set/override the JAVA_HOME for itself? This is an automated

[GitHub] [maven-surefire] Tibor17 commented on pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
Tibor17 commented on pull request #288: URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620067158 But the inheritance of the env is not done from the toolchain to the jvm. The toolchain is used only for one purpose, to get the path of the JDK installation on the disk,

[GitHub] [maven-antrun-plugin] elharo edited a comment on pull request #7: deps: update hamcrest

2020-04-27 Thread GitBox
elharo edited a comment on pull request #7: URL: https://github.com/apache/maven-antrun-plugin/pull/7#issuecomment-620050287 No complaints from jenkins: https://builds.apache.org/job/maven-box/job/maven-antrun-plugin/job/elharo-patch-1/

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093629#comment-17093629 ] Michael Osipov commented on WAGON-590: -- The behavior is correct. Here is the reason:

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093624#comment-17093624 ] Michael Osipov commented on WAGON-590: -- Can you please run Maven in debug mode with HTTP logging

[GitHub] [maven-invoker] khmarbaise commented on a change in pull request #3: upgrade parent POM and other dependencies

2020-04-27 Thread GitBox
khmarbaise commented on a change in pull request #3: URL: https://github.com/apache/maven-invoker/pull/3#discussion_r415903722 ## File path: pom.xml ## @@ -25,7 +25,7 @@ under the License. org.apache.maven.shared maven-shared-components -31 +34 Review

[GitHub] [maven-invoker] elharo commented on a change in pull request #3: upgrade parent POM and other dependencies

2020-04-27 Thread GitBox
elharo commented on a change in pull request #3: URL: https://github.com/apache/maven-invoker/pull/3#discussion_r415902478 ## File path: pom.xml ## @@ -25,7 +25,7 @@ under the License. org.apache.maven.shared maven-shared-components -31 +34 Review

[GitHub] [maven-antrun-plugin] elharo commented on pull request #7: deps: update hamcrest

2020-04-27 Thread GitBox
elharo commented on pull request #7: URL: https://github.com/apache/maven-antrun-plugin/pull/7#issuecomment-620050287 No complaints from jenkkins: https://builds.apache.org/job/maven-box/job/maven-antrun-plugin/job/elharo-patch-1/

[GitHub] [maven-invoker] khmarbaise commented on a change in pull request #3: upgrade parent POM and other dependencies

2020-04-27 Thread GitBox
khmarbaise commented on a change in pull request #3: URL: https://github.com/apache/maven-invoker/pull/3#discussion_r415900756 ## File path: pom.xml ## @@ -25,7 +25,7 @@ under the License. org.apache.maven.shared maven-shared-components -31 +34 Review

[jira] [Commented] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093602#comment-17093602 ] Tomo Suzuki commented on MNG-6737: -- Thank you. > StackOverflowError when version ranges are unsolvable

[GitHub] [maven-antrun-plugin] rfscholte commented on pull request #6: set Maven 3.1.1 as minimum version

2020-04-27 Thread GitBox
rfscholte commented on pull request #6: URL: https://github.com/apache/maven-antrun-plugin/pull/6#issuecomment-620025082 this should have been 3.1.0. The difference between api and impl is not clear, but as a result of earlier discussions this should the lower version.

[GitHub] [maven-surefire] Tibor17 commented on pull request #287: [DO NOT MERGE] SUREFIRE-1782 Exclude explicitly configured env vars

2020-04-27 Thread GitBox
Tibor17 commented on pull request #287: URL: https://github.com/apache/maven-surefire/pull/287#issuecomment-620021601 ok, thx let me know when it is ready to merge and we will change the title. This is an automated

[GitHub] [maven-antrun-plugin] elharo opened a new pull request #7: deps: update hamcrest

2020-04-27 Thread GitBox
elharo opened a new pull request #7: URL: https://github.com/apache/maven-antrun-plugin/pull/7 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-antrun-plugin] elharo commented on pull request #6: set Maven 3.1.1 as minimum version

2020-04-27 Thread GitBox
elharo commented on pull request #6: URL: https://github.com/apache/maven-antrun-plugin/pull/6#issuecomment-620020342 Yep, it was flaky CI. It passed now. This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-invoker] elharo commented on a change in pull request #3: upgrade parent POM and other dependencies

2020-04-27 Thread GitBox
elharo commented on a change in pull request #3: URL: https://github.com/apache/maven-invoker/pull/3#discussion_r401755394 ## File path: pom.xml ## @@ -25,7 +25,7 @@ under the License. org.apache.maven.shared maven-shared-components -31 +34 Review

[jira] [Comment Edited] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093558#comment-17093558 ] Cintia DR edited comment on WAGON-590 at 4/27/20, 2:20 PM: --- Thanks so much for

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093558#comment-17093558 ] Cintia DR commented on WAGON-590: - Thanks so much for the quick response.   > Please try Maven from

[jira] [Commented] (MASSEMBLY-765) add property groupIdPath

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093543#comment-17093543 ] Hudson commented on MASSEMBLY-765: -- Build succeeded in Jenkins: Maven TLP » maven-assembly-plugin »

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093525#comment-17093525 ] Michael Osipov commented on WAGON-590: -- FTR, please reread RFC 7231 about 3xx status codes. You are

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093521#comment-17093521 ] Michael Osipov commented on WAGON-590: -- Please try Maven from master. I included a branch new Wagon

[jira] [Updated] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-590: - Fix Version/s: waiting-for-feedback > Maven 3.5.0+ don't seem to send credentials after 301/302

[jira] [Commented] (MASSEMBLY-765) add property groupIdPath

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093518#comment-17093518 ] Hudson commented on MASSEMBLY-765: -- Build succeeded in Jenkins: Maven TLP » maven-assembly-plugin »

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093517#comment-17093517 ] Michael Osipov commented on WAGON-590: -- I will take a look. > Maven 3.5.0+ don't seem to send

[GitHub] [maven-resolver] elharo commented on pull request #48: [MRESOLVER-103] replace some deprecated classes

2020-04-27 Thread GitBox
elharo commented on pull request #48: URL: https://github.com/apache/maven-resolver/pull/48#issuecomment-619973399 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project maven-resolver-transport-http: Compilation failure

[jira] [Assigned] (MRESOLVER-38) SOE/OOME in DefaultDependencyNode.accept

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-38: --- Assignee: Michael Osipov > SOE/OOME in DefaultDependencyNode.accept >

[jira] [Commented] (MNG-5592) Maven dependency resolution locks up

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093454#comment-17093454 ] Michael Osipov commented on MNG-5592: - Still locks up with Maven 3.7.0-SNAPSHOT and Maven Resolver

[jira] [Closed] (MASSEMBLY-765) add property groupIdPath

2020-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MASSEMBLY-765. Fix Version/s: 3.3.0 Assignee: Robert Scholte Resolution: Fixed Fixed

[GitHub] [maven-resolver] michael-o edited a comment on pull request #47: [MRESOLVER-107] update wagon api

2020-04-27 Thread GitBox
michael-o edited a comment on pull request #47: URL: https://github.com/apache/maven-resolver/pull/47#issuecomment-619914667 It is released with the entire train. If you see no diff on the API, go ahead and update. This is

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-27 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619954280 Opened #288 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-surefire] akomakom opened a new pull request #288: SUREFIRE-1234 Set java home from toolchain

2020-04-27 Thread GitBox
akomakom opened a new pull request #288: URL: https://github.com/apache/maven-surefire/pull/288 When a toolchain is used to select a test jvm, also set the `JAVA_HOME` environment variable to the selected jvm instead of inheriting the environment variable from the invoking shell.

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-27 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619952659 > How the second fix would look like? I'd still do it this way (below), but I'm open to suggestions. What's the concern with using DefaultJavaToolchain?

[jira] [Closed] (MRESOLVER-107) Update wagon

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MRESOLVER-107. --- > Update wagon > > > Key: MRESOLVER-107 >

[jira] [Closed] (MRESOLVER-106) Update httpcomponents

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MRESOLVER-106. --- > Update httpcomponents > - > > Key:

[jira] [Resolved] (MRESOLVER-106) Update httpcomponents

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MRESOLVER-106. - Resolution: Fixed > Update httpcomponents > - > >

[jira] [Resolved] (MRESOLVER-107) Update wagon

2020-04-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MRESOLVER-107. - Resolution: Fixed > Update wagon > > >

[jira] [Comment Edited] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093401#comment-17093401 ] Michael Osipov edited comment on MNG-6737 at 4/27/20, 11:54 AM: With Maven

[jira] [Commented] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093401#comment-17093401 ] Michael Osipov commented on MNG-6737: - With Maven Resolver 1.4.2 this now corrects exits with:

[jira] [Assigned] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6737: --- Assignee: Michael Osipov > StackOverflowError when version ranges are unsolvable and graph

[jira] [Updated] (MNG-6737) StackOverflowError when version ranges are unsolvable and graph contains a cycle

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6737: Fix Version/s: 3.7.0 > StackOverflowError when version ranges are unsolvable and graph contains a >

[jira] [Updated] (MRESOLVER-38) SOE/OOME in DefaultDependencyNode.accept

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-38: Fix Version/s: 1.4.2 > SOE/OOME in DefaultDependencyNode.accept >

[jira] [Closed] (MRESOLVER-38) SOE/OOME in DefaultDependencyNode.accept

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-38. --- Resolution: Fixed > SOE/OOME in DefaultDependencyNode.accept >

[jira] [Comment Edited] (MRESOLVER-38) SOE/OOME in DefaultDependencyNode.accept

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093372#comment-17093372 ] Michael Osipov edited comment on MRESOLVER-38 at 4/27/20, 11:37 AM:

[jira] [Commented] (MRESOLVER-38) SOE/OOME in DefaultDependencyNode.accept

2020-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093372#comment-17093372 ] Michael Osipov commented on MRESOLVER-38: - org.webjars.npm:n3-charts:2.0.17: {noformat}

[jira] [Updated] (MASSEMBLY-765) add property groupIdPath

2020-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MASSEMBLY-765: - Summary: add property groupIdPath (was: add property groupIDpath) > add property

[GitHub] [maven-resolver] michael-o commented on pull request #47: [MRESOLVER-107] update wagon api

2020-04-27 Thread GitBox
michael-o commented on pull request #47: URL: https://github.com/apache/maven-resolver/pull/47#issuecomment-619914667 It is released with the entire train. If you see now diff on the API, go ahead and update. This is an

  1   2   >