[GitHub] [maven] pzygielo commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

pzygielo commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r542168538 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java ## @@ -1707,4 +1786,132 @@ protected void mergePlug

Following Java Modularity documentation creates errors

Hello, I have been trying for a few days to get Maven + Eclipse + TestNG to work with JPMS. The problem I am running into now is that following the Using Java Modularity documentation exactly causes the following error:

[jira] [Commented] (MINVOKER-272) use Files.createTempDirectory(...) instead of custom code around File.createTempFile(...)

[ https://issues.apache.org/jira/browse/MINVOKER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248695#comment-17248695 ] Hudson commented on MINVOKER-272: - Build failed in Jenkins: Maven » Maven TLP » maven-i

[jira] [Commented] (MSCMPUB-47) use Files.createTempDirectory(...) instead of custom code around File.createTempFile(...)

[ https://issues.apache.org/jira/browse/MSCMPUB-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248688#comment-17248688 ] Hudson commented on MSCMPUB-47: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-scm-

[jira] [Comment Edited] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248680#comment-17248680 ] Benjamin Marwell edited comment on MCOMPILER-445 at 12/13/20, 10:30 PM:

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248684#comment-17248684 ] Benjamin Marwell commented on MCOMPILER-445: Agreed, but as a module must

[GitHub] [maven] michael-o commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

michael-o commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r542017373 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java ## @@ -1901,8 +1901,9 @@ public Source getSource(

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248683#comment-17248683 ] Michael Osipov commented on MCOMPILER-445: -- This is so ugly. There must be a

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248680#comment-17248680 ] Benjamin Marwell commented on MCOMPILER-445: [~michael-o] I think I just f

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248674#comment-17248674 ] Michael Osipov commented on MCOMPILER-445: -- That's the stupidest thing I have

[GitHub] [maven-deploy-plugin] michael-o commented on a change in pull request #12: [MDEPLOY-279] Better validation for alt deploy repository mojo parameter

michael-o commented on a change in pull request #12: URL: https://github.com/apache/maven-deploy-plugin/pull/12#discussion_r542003179 ## File path: src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java ## @@ -51,6 +51,9 @@ public class DeployMojo extends AbstractD

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r542001814 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -703,15 +671,14 @@ private boolean build( List results, L

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541999673 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/TransformerContextBuilder.java ## @@ -0,0 +1,46 @@ +package org.apache.mave

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541999304 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/ModelCacheTag.java ## @@ -129,12 +129,16 @@ public DependencyManagement fro

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541999208 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingResult.java ## @@ -41,6 +41,13 @@ * @return The model id

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541998896 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -386,44 +381,22 @@ private ModelSource createStubModelSour

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541998917 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -505,32 +483,17 @@ private boolean build( List results, L

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541998876 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -386,44 +381,22 @@ private ModelSource createStubModelSour

[GitHub] [maven] rfscholte commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

rfscholte commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541998823 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -263,21 +264,14 @@ private DependencyResolutionResult reso

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248616#comment-17248616 ] Benjamin Marwell commented on MCOMPILER-445: It is not just you…  The com

[jira] [Commented] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

[ https://issues.apache.org/jira/browse/MCOMPILER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248613#comment-17248613 ] Michael Osipov commented on MCOMPILER-445: -- I am confused how a Javadoc optio

[jira] [Created] (MCOMPILER-445) Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

Benjamin Marwell created MCOMPILER-445: -- Summary: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing Key: MCOMPILER-445 URL: https://issues.apache.org/jira/browse/MCOMPILER-445 Proje

[jira] [Commented] (MNG-7034) StackOverflowError thrown if a cycle exists in BOM imports

[ https://issues.apache.org/jira/browse/MNG-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248595#comment-17248595 ] Hudson commented on MNG-7034: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven] michael-o commented on a change in pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

michael-o commented on a change in pull request #391: URL: https://github.com/apache/maven/pull/391#discussion_r541933983 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -263,21 +264,14 @@ private DependencyResolutionResult reso

[jira] [Closed] (MNG-7034) StackOverflowError thrown if a cycle exists in BOM imports

[ https://issues.apache.org/jira/browse/MNG-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7034. --- Fix Version/s: (was: 4.0.x-candidate) 4.0.0-alpha-1 4.0.0

[GitHub] [maven] asfgit closed pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

asfgit closed pull request #399: URL: https://github.com/apache/maven/pull/399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] michael-o removed a comment on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

michael-o removed a comment on pull request #399: URL: https://github.com/apache/maven/pull/399#issuecomment-744010593 This changes causes: ``` [ERROR] Failures: [ERROR] MavenITmng3819PluginDepPlexusUtilsTest>AbstractMavenIntegrationTestCase.runTest:255->testitMNG3819:62 [ERRO

[GitHub] [maven] michael-o commented on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

michael-o commented on pull request #399: URL: https://github.com/apache/maven/pull/399#issuecomment-744010593 This changes causes: ``` [ERROR] Failures: [ERROR] MavenITmng3819PluginDepPlexusUtilsTest>AbstractMavenIntegrationTestCase.runTest:255->testitMNG3819:62 [ERROR] Ma

[jira] [Commented] (MNG-6928) CREATE: Call to Action design card

[ https://issues.apache.org/jira/browse/MNG-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248579#comment-17248579 ] Robert Scholte commented on MNG-6928: - Based on the release of the first set, there are

[jira] [Closed] (MNG-7044) Allow use of attributes in Maven pom.xml

[ https://issues.apache.org/jira/browse/MNG-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-7044. --- Assignee: Robert Scholte Resolution: Won't Fix > Allow use of attributes in Maven pom.xml > -

[jira] [Commented] (MNG-7052) Do not allow symbols as first character of identifiers in the POM

[ https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248560#comment-17248560 ] Michael Osipov commented on MNG-7052: - I think this should also apply to elements in th

[jira] [Commented] (MNG-7052) Do not allow symbols as first character of identifiers in the POM

[ https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248559#comment-17248559 ] Michael Osipov commented on MNG-7052: - I think this should also apply to elements in th

[jira] [Commented] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds

[ https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248555#comment-17248555 ] Michael Osipov commented on MJAR-275: - I have talked to Rory O'Donell, there are two is

[jira] [Commented] (MDEPLOY-280) Ability so skip certain classifiers from deploy

[ https://issues.apache.org/jira/browse/MDEPLOY-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248544#comment-17248544 ] Michael Osipov commented on MDEPLOY-280: This also seems to me like a symptom so

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248542#comment-17248542 ] Michael Osipov commented on MNG-7037: - Why it is wrong? You use our work and it is perf

[jira] [Commented] (MRESOLVER-151) Switch the default checksum policy from "warn" to "fail"

[ https://issues.apache.org/jira/browse/MRESOLVER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248541#comment-17248541 ] Michael Osipov commented on MRESOLVER-151: -- Yes, that is correct. I haven't t

[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248527#comment-17248527 ] Alexander Kriegisch edited comment on MRELEASE-899 at 12/13/20, 8:14 AM:

[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248527#comment-17248527 ] Alexander Kriegisch edited comment on MRELEASE-899 at 12/13/20, 8:13 AM:

[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248528#comment-17248528 ] Alexander Kriegisch edited comment on MRELEASE-899 at 12/13/20, 8:09 AM:

[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248528#comment-17248528 ] Alexander Kriegisch commented on MRELEASE-899: -- Another finding alleviatin

[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248527#comment-17248527 ] Alexander Kriegisch edited comment on MRELEASE-899 at 12/13/20, 8:04 AM:

[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248527#comment-17248527 ] Alexander Kriegisch commented on MRELEASE-899: -- As for explanting the code