[jira] [Commented] (MNG-7074) Environment Variable defaulting

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270825#comment-17270825 ] Loïc Hermann commented on MNG-7074: --- Yes but the drawback with this is that if a variable is used ten

[GitHub] [maven-dependency-tree] slachiewicz opened a new pull request #6: [PoC] Require maven 3.1.1

2021-01-23 Thread GitBox
slachiewicz opened a new pull request #6: URL: https://github.com/apache/maven-dependency-tree/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (MNG-6757) Cant create a proper BOM when using ${revision}

2021-01-23 Thread Kalle Widell (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270780#comment-17270780 ] Kalle Widell commented on MNG-6757: --- Sorry, been busy here. I did try tonight.  Using 

[jira] [Updated] (MNG-6757) Cant create a proper BOM when using ${revision}

2021-01-23 Thread Kalle Widell (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalle Widell updated MNG-6757: -- Attachment: sample-project.tar.bz2 > Cant create a proper BOM when using ${revision} >

[jira] [Closed] (MCHECKSTYLE-395) Ignored 6 errors, 0 violation remaining.

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCHECKSTYLE-395. Resolution: Invalid > Ignored 6 errors, 0 violation remaining. >

[jira] [Closed] (MCHECKSTYLE-352) Add documentation information for GitHub

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCHECKSTYLE-352. Resolution: Fixed > Add documentation information for GitHub >

[jira] [Closed] (MCHECKSTYLE-334) "mvn install site" works differently than "mvn install" or "mvn site"

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCHECKSTYLE-334. Resolution: Incomplete > "mvn install site" works differently than

[jira] [Updated] (MCHECKSTYLE-398) suppressions inside JAR, non-absolute path, cannot be found

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MCHECKSTYLE-398: - Fix Version/s: 3.2.0 > suppressions inside JAR, non-absolute path,

[jira] [Commented] (MCHECKSTYLE-400) Remove travis.org ci

2021-01-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270774#comment-17270774 ] Hudson commented on MCHECKSTYLE-400: Build succeeded in Jenkins: Maven » Maven TLP »

[jira] [Commented] (MCHECKSTYLE-163) Test classpath resolution fails in mvn check:check when includeTestSourceDirectory = true

2021-01-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270775#comment-17270775 ] Hudson commented on MCHECKSTYLE-163: Build succeeded in Jenkins: Maven » Maven TLP »

[jira] [Closed] (MCHECKSTYLE-400) Remove travis.org ci

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCHECKSTYLE-400. Resolution: Fixed > Remove travis.org ci > > >

[GitHub] [maven-checkstyle-plugin] asfgit merged pull request #42: [MCHECKSTYLE-400] remove .travis.yml

2021-01-23 Thread GitBox
asfgit merged pull request #42: URL: https://github.com/apache/maven-checkstyle-plugin/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (MNG-7074) Environment Variable defaulting

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270770#comment-17270770 ] Michael Osipov edited comment on MNG-7074 at 1/23/21, 9:58 PM: --- I think this

[jira] [Comment Edited] (MNG-7074) Environment Variable defaulting

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270770#comment-17270770 ] Michael Osipov edited comment on MNG-7074 at 1/23/21, 9:57 PM: --- I think this

[jira] [Commented] (MNG-7074) Environment Variable defaulting

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270770#comment-17270770 ] Michael Osipov commented on MNG-7074: - I think this can be abstracted by introducing a wellknown syntax

[jira] [Commented] (MNG-6879) When the repo with the id of central is configured in settings.xml and the scope = import dependency is included in the project of the project, the central repo has a pro

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270769#comment-17270769 ] Michael Osipov commented on MNG-6879: - Have you tried what I have said? > When the repo with the id of

[jira] [Commented] (MNG-6757) Cant create a proper BOM when using ${revision}

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270768#comment-17270768 ] Michael Osipov commented on MNG-6757: - Did you test? > Cant create a proper BOM when using ${revision}

[jira] [Commented] (MNG-6283) [regression] resolution of nested import-scoped transitive dependencies ignores repositories overwriting 'central'

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270767#comment-17270767 ] Michael Osipov commented on MNG-6283: - Did you test? > [regression] resolution of nested import-scoped

[jira] [Updated] (MNG-7076) Allow .mavenrc file in project working directory to override the one in $HOME

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7076: Fix Version/s: wontfix-candidate > Allow .mavenrc file in project working directory to override the

[jira] [Assigned] (MCHECKSTYLE-400) Remove travis.org ci

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MCHECKSTYLE-400: Assignee: Sylwester Lachiewicz > Remove travis.org ci >

[jira] [Updated] (MCHECKSTYLE-400) Remove travis.org ci

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MCHECKSTYLE-400: - Fix Version/s: (was: 3.2.0) 3.1.2 > Remove

[jira] [Closed] (MNG-4142) Maven doesn't try to download a dependency when it already exists a version with classifier locally

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-4142. --- Fix Version/s: (was: waiting-for-feedback) Resolution: Incomplete I have been waiting for

[GitHub] [maven-enforcer] pzygielo commented on a change in pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-23 Thread GitBox
pzygielo commented on a change in pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85#discussion_r563157955 ## File path: enforcer-rules/pom.xml ## @@ -103,9 +103,11 @@ org.apache.maven.resolver maven-resolver-util +

[jira] [Assigned] (MNG-6985) Incorrect value for maven.multiModuleProjectDirectory in integration tests

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6985: --- Assignee: Maarten Mulders > Incorrect value for maven.multiModuleProjectDirectory in

[jira] [Updated] (MNG-6909) Inject objects using CDI in tests

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6909: Fix Version/s: 4.0.0 > Inject objects using CDI in tests > - > >

[jira] [Updated] (MNG-7071) Remove warning about ignored profiles.xml

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7071: Fix Version/s: 4.0.0 > Remove warning about ignored profiles.xml >

[jira] [Comment Edited] (WAGON-603) Connection reset error from Azure pipelines

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270763#comment-17270763 ] Michael Osipov edited comment on WAGON-603 at 1/23/21, 9:25 PM: Please get

[jira] [Commented] (WAGON-603) Connection reset error from Azure pipelines

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270763#comment-17270763 ] Michael Osipov commented on WAGON-603: -- Please get rid of this non-sense first and then retry:

[jira] [Commented] (MNG-7078) The integration tests use the default maven settings

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270759#comment-17270759 ] Michael Osipov commented on MNG-7078: - In general, settings should only be overridden if the usecase

[jira] [Comment Edited] (MRESOLVER-162) Restore binary compatibility broken by MRESOLVER-154

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270748#comment-17270748 ] Tamás Cservenák edited comment on MRESOLVER-162 at 1/23/21, 8:17 PM:

[jira] [Comment Edited] (MRESOLVER-162) Restore binary compatibility broken by MRESOLVER-154

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270748#comment-17270748 ] Tamás Cservenák edited comment on MRESOLVER-162 at 1/23/21, 8:10 PM:

[jira] [Commented] (MRESOLVER-162) Restore binary compatibility broken by MRESOLVER-154

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270748#comment-17270748 ] Tamás Cservenák commented on MRESOLVER-162: --- Maven bits expect syncontext (the "default"

[jira] [Commented] (MRESOLVER-161) Resolve circular dependency resolver -> maven -> resolver

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270747#comment-17270747 ] Michael Osipov commented on MRESOLVER-161: -- I agree that they need to move to a separate

[jira] [Commented] (MRESOLVER-162) Restore binary compatibility broken by MRESOLVER-154

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270746#comment-17270746 ] Michael Osipov commented on MRESOLVER-162: -- How did it break the snippets? Those are demo, we

[jira] [Updated] (MRESOLVER-161) Resolve circular dependency resolver -> maven -> resolver

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-161: -- Description: Apache Maven Resolver has a module {{maven-resolver-demo-snippets}}

[jira] [Updated] (MRESOLVER-161) Resolve circular dependency resolver -> maven -> resolver

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-161: -- Description: Apache Maven Resolver has a module {{maven-resolver-demo-snippets}}

[GitHub] [maven-resolver] cstamas opened a new pull request #91: [MRESOLVER-162] Restore binary compatiblity

2021-01-23 Thread GitBox
cstamas opened a new pull request #91: URL: https://github.com/apache/maven-resolver/pull/91 And make demos work again. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (MRESOLVER-162) Restore binary compatibility broken by MRESOLVER-154

2021-01-23 Thread Jira
Tamás Cservenák created MRESOLVER-162: - Summary: Restore binary compatibility broken by MRESOLVER-154 Key: MRESOLVER-162 URL: https://issues.apache.org/jira/browse/MRESOLVER-162 Project: Maven

[jira] [Created] (MRESOLVER-161) Resolve circular dependency resolver -> maven -> resolver

2021-01-23 Thread Jira
Tamás Cservenák created MRESOLVER-161: - Summary: Resolve circular dependency resolver -> maven -> resolver Key: MRESOLVER-161 URL: https://issues.apache.org/jira/browse/MRESOLVER-161 Project:

[jira] [Commented] (MRESOLVER-160) Deprecate ServiceLocator

2021-01-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270732#comment-17270732 ] Hudson commented on MRESOLVER-160: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver »

[jira] [Resolved] (MRESOLVER-160) Deprecate ServiceLocator

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-160. --- Fix Version/s: 1.7.0 Assignee: Tamás Cservenák Resolution: Fixed

[jira] [Updated] (MRESOLVER-160) Deprecate ServiceLocator

2021-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-160: -- Description: As prequel to MRESOLVER-157 we need to deprecate (to warn users of)

[GitHub] [maven-resolver] asfgit merged pull request #90: [MRESOLVER-160] Deprecate service locator

2021-01-23 Thread GitBox
asfgit merged pull request #90: URL: https://github.com/apache/maven-resolver/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270730#comment-17270730 ] Michael Osipov commented on MRESOLVER-153: -- I do observe this too once in a while: {noformat}

[GitHub] [maven-dependency-tree] slachiewicz commented on pull request #1: [MSHARED-788] Add functionality to collect raw dependencies in Maven 3+

2021-01-23 Thread GitBox
slachiewicz commented on pull request #1: URL: https://github.com/apache/maven-dependency-tree/pull/1#issuecomment-766156623 We should no longer use maven-artifact-transfer This is an automated message from the Apache Git

[jira] [Commented] (MSHARED-788) Add functionality to collect raw dependencies in Maven 3+

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270727#comment-17270727 ] Sylwester Lachiewicz commented on MSHARED-788: -- maven-artifact-transfer is now deprecated.

[GitHub] [maven-shared-utils] elharo commented on pull request #74: Windows 9X is long dead

2021-01-23 Thread GitBox
elharo commented on pull request #74: URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766155596 That still doesn't mean we should break the build of projects that have this in their tree. Deprecate and warn them. We can take it out in a few releases.

[jira] [Updated] (MSHARED-627) Enhance the ArtifactResolver with a method to resolve versions of an Artifact

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-627: - Labels: close-pending (was: ) > Enhance the ArtifactResolver with a method to

[jira] [Updated] (MSHARED-820) Check for duplicated attachment of the same artifact

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-820: - Labels: close-pending (was: ) > Check for duplicated attachment of the same

[jira] [Updated] (MSHARED-662) Create Aether->Wagon TransferListener adapter

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-662: - Labels: close-pending (was: ) > Create Aether->Wagon TransferListener adapter

[GitHub] [maven-resolver] cstamas opened a new pull request #90: [MRESOLVER-160] Deprecate service locator

2021-01-23 Thread GitBox
cstamas opened a new pull request #90: URL: https://github.com/apache/maven-resolver/pull/90 Deprecate `ServiceLocator` and `Service` interfaces. This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (MRESOLVER-160) Deprecate ServiceLocator

2021-01-23 Thread Jira
Tamás Cservenák created MRESOLVER-160: - Summary: Deprecate ServiceLocator Key: MRESOLVER-160 URL: https://issues.apache.org/jira/browse/MRESOLVER-160 Project: Maven Resolver Issue Type:

[jira] [Closed] (MSHARED-967) permanent solution to MINSTALL-3

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-967. Resolution: Won't Fix > permanent solution to MINSTALL-3 >

[jira] [Commented] (MENFORCER-277) Upgrade maven-dependency-tree to 3.x

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270725#comment-17270725 ] Sylwester Lachiewicz commented on MENFORCER-277: maven-artifact-transfer component is

[jira] [Updated] (MSHARED-801) Add functionality to collect raw dependencies in Maven 3+

2021-01-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-801: - Labels: close-pending (was: intern) > Add functionality to collect raw

[GitHub] [maven-shared-utils] michael-o commented on pull request #74: Windows 9X is long dead

2021-01-23 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766152018 @elharo This won't even run in Windows 9x because there isn't Java 7 for. This is an automated message

[jira] [Updated] (SUREFIRE-1860) extend ReportEntry interface and SimpleReportEntry with mandatory properties runMode:String, id:long, forkId:int

2021-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1860: --- Description: We are missing two properties in the {{ReportEntry}} interface *

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766138237 @mkarg hmm, for me the contract was that getPath returns either setPath or setFile value (converted with toPath if needed or the opposite). If there is no contract then don't

[jira] [Deleted] (MENFORCER-375) Best Working Kodi addon in 2020, These addons can be run on the Android Mobiles & Tablets, Windows & Mac computers, FireStick, Fire Stick 4K, Fire TV Cube, and all the

2021-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov deleted MENFORCER-375: - > Best Working Kodi addon in 2020, These addons can be run on the Android > Mobiles &

[jira] [Updated] (SUREFIRE-1860) extend ReportEntry interface and SimpleReportEntry with mandatory properties runMode:String, id:long, forkId:int

2021-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1860: --- Description: We are missing two properties in the {{ReportEntry}} interface *

[jira] [Closed] (MSHARED-944) Set minimum Maven version to 3.1.1

2021-01-23 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHARED-944. - Resolution: Fixed maven-archiver done in

[GitHub] [maven-shared-utils] slawekjaranowski commented on pull request #74: Windows 9X is long dead

2021-01-23 Thread GitBox
slawekjaranowski commented on pull request #74: URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766096218 So please deprecate class with reason. Another case is that apache components don't have any release plan / calendar so nobody know when next release

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766093196 (just as a side note: My test does *not strive* to test whether "getPath" returns "setPath" as this contract is not defined anywhere)

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766092983 @rmannibucau Talking about speeding things up, I think it is best if you just author a commit ontop that replaces my "wrong" code by your "correct" code, as apparently we have

[GitHub] [maven-enforcer] pzygielo commented on a change in pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-23 Thread GitBox
pzygielo commented on a change in pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85#discussion_r563157955 ## File path: enforcer-rules/pom.xml ## @@ -103,9 +103,11 @@ org.apache.maven.resolver maven-resolver-util +

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766017252 @mkarg Agree with @elharo , you dont test the contract (which is 100%) of what a default method is but its impl. There are other ways to impl it correctly and your test would

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766006649 > It is not necessary to test that setPath actually invokes setFile. Indeed it is a **bad idea** to test that setPath invokes setFile. Testing the implementation instead of the

[GitHub] [maven] elharo commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
elharo commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-765992624 It is not necessary to test that setPath actually invokes setFile. Indeed it is a **bad idea** to test that setPath invokes setFile. Testing the implementation instead of the

[GitHub] [maven-shared-utils] elharo opened a new pull request #79: move plexus-utils to scope test

2021-01-23 Thread GitBox
elharo opened a new pull request #79: URL: https://github.com/apache/maven-shared-utils/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-shared-utils] elharo opened a new pull request #78: remove unused plexus dependency

2021-01-23 Thread GitBox
elharo opened a new pull request #78: URL: https://github.com/apache/maven-shared-utils/pull/78 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-765974428 Guys, don't get me wrong, but for the sake of finding a concensus, maybe we should agree on two things: (1) We do *not* insist on personally wanted changes *must* be done

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563147626 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563147723 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563147626 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563147511 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java ## @@ -86,6 +87,16 @@ void setFile( File destination ); +

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563147313 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java ## @@ -86,6 +87,16 @@ void setFile( File destination ); +

[GitHub] [maven-shared-utils] elharo commented on pull request #74: Windows 9X is long dead

2021-01-23 Thread GitBox
elharo commented on pull request #74: URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765945045 I'm not comfortable removing public API without reasonable notice. Sounds like there are existing uses.

[GitHub] [maven] elharo commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
elharo commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563146428 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java ## @@ -86,6 +87,16 @@ void setFile( File destination ); +

[GitHub] [maven-archetype] dhutchison commented on pull request #61: [ARCHETYPE-612] Fixes to required property sort approach

2021-01-23 Thread GitBox
dhutchison commented on pull request #61: URL: https://github.com/apache/maven-archetype/pull/61#issuecomment-765907113 The only way I could find was to get people to specify properties on the command line instead of using the interactive prompts.

[GitHub] [maven] rmannibucau commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
rmannibucau commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563042648 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563040883 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[jira] [Updated] (MCHECKSTYLE-99) should use default test sources xref output dir: ${project.reporting.outputDirectory}/xref-test

2021-01-23 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MCHECKSTYLE-99: Fix Version/s: 3.2.0 > should use default test sources xref output dir: >

[GitHub] [maven-checkstyle-plugin] bmarwell commented on a change in pull request #16: [MCHECKSTYLE-376] Remove window line endings from files

2021-01-23 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-checkstyle-plugin/pull/16#discussion_r563040574 ## File path: src/it/MCHECKSTYLE-225-pluginManagement/invoker.properties ## @@ -1,19 +1,19 @@ -# Licensed to the Apache Software Foundation

[GitHub] [maven-checkstyle-plugin] bmarwell commented on a change in pull request #36: [MCHECKSTYLE-397] support ${config_loc} on checkstyle xml

2021-01-23 Thread GitBox
bmarwell commented on a change in pull request #36: URL: https://github.com/apache/maven-checkstyle-plugin/pull/36#discussion_r563040248 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java ## @@ -584,6 +584,20 @@ private

[GitHub] [maven-checkstyle-plugin] bmarwell opened a new pull request #42: [MCHECKSTYLE-400] remove .travis.yml

2021-01-23 Thread GitBox
bmarwell opened a new pull request #42: URL: https://github.com/apache/maven-checkstyle-plugin/pull/42 failed anyway, shuts down soon. for 3.2.0 (do not merge just yet) --- Following this checklist to help us incorporate your contribution quickly and easily: -

[jira] [Created] (MCHECKSTYLE-400) Remove travis.org ci

2021-01-23 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MCHECKSTYLE-400: Summary: Remove travis.org ci Key: MCHECKSTYLE-400 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-400 Project: Maven Checkstyle Plugin

[GitHub] [maven] rmannibucau commented on a change in pull request #421: Artifact.getPath() and .setPath()

2021-01-23 Thread GitBox
rmannibucau commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r563037805 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactTest.java ## @@ -0,0 +1,43 @@ +package org.apache.maven.artifact; + +import

[GitHub] [maven-indexer] akurtakov commented on a change in pull request #75: Remove guava dependency from indexer-core

2021-01-23 Thread GitBox
akurtakov commented on a change in pull request #75: URL: https://github.com/apache/maven-indexer/pull/75#discussion_r563035684 ## File path: indexer-core/src/main/java/org/apache/maven/index/ArtifactInfo.java ## @@ -431,7 +429,8 @@ public Gav calculateGav() public String