[GitHub] [maven] gnodet commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
gnodet commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917316633 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Parameter.java: ## @@ -0,0 +1,95 @@ +package org.apache.maven.api.plugin.annotations; + +/* + *

[GitHub] [maven] gnodet commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
gnodet commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917316576 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Component.java: ## @@ -0,0 +1,57 @@ +package org.apache.maven.api.plugin.annotations; + +/* + *

[GitHub] [maven] gnodet commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
gnodet commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917315424 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/Mojo.java: ## @@ -0,0 +1,44 @@ +package org.apache.maven.api.plugin; + +/* + * Licensed to the Apache

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917312767 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Parameter.java: ## @@ -0,0 +1,95 @@ +package org.apache.maven.api.plugin.annotations; +

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917312476 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Mojo.java: ## @@ -0,0 +1,98 @@ +package org.apache.maven.api.plugin.annotations; + +/*

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917311069 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Component.java: ## @@ -0,0 +1,57 @@ +package org.apache.maven.api.plugin.annotations; +

[GitHub] [maven-apache-parent] hboutemy commented on pull request #92: [MPOM-337] load plugins containing lifecycle mappings with extensions

2022-07-09 Thread GitBox
hboutemy commented on PR #92: URL: https://github.com/apache/maven-apache-parent/pull/92#issuecomment-1179610376 -1 having every plugin as extension just bloats and takes risk in the Maven core classloader -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #703: New API with immutable model

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #703: URL: https://github.com/apache/maven/pull/703#discussion_r917310837 ## api/maven-api-core/src/main/java/org/apache/maven/api/plugin/Mojo.java: ## @@ -0,0 +1,44 @@ +package org.apache.maven.api.plugin; + +/* + * Licensed to the

[GitHub] [maven] michael-o commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
michael-o commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917284006 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564594#comment-17564594 ] ASF GitHub Bot commented on MNG-7353: - michael-o commented on code in PR #757: URL:

[jira] [Created] (SUREFIRE-2109) User cannot write temporary file to surefire/ temp directory

2022-07-09 Thread Markus Spann (Jira)
Markus Spann created SUREFIRE-2109: -- Summary: User cannot write temporary file to surefire/ temp directory Key: SUREFIRE-2109 URL: https://issues.apache.org/jira/browse/SUREFIRE-2109 Project: Maven

[GitHub] [maven-surefire] sman-81 closed pull request #457: [SUREFIRE-1992] Do not output class name on error/failure for certain exceptions

2022-07-09 Thread GitBox
sman-81 closed pull request #457: [SUREFIRE-1992] Do not output class name on error/failure for certain exceptions URL: https://github.com/apache/maven-surefire/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven-surefire] sman-81 closed pull request #456: [SUREFIRE-1992] Limit error/failure messages to first line but do not abbreviate

2022-07-09 Thread GitBox
sman-81 closed pull request #456: [SUREFIRE-1992] Limit error/failure messages to first line but do not abbreviate URL: https://github.com/apache/maven-surefire/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564583#comment-17564583 ] ASF GitHub Bot commented on MNG-7353: - hboutemy commented on code in PR #757: URL:

[GitHub] [maven] hboutemy commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
hboutemy commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917273518 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[GitHub] [maven] varunsh-coder commented on pull request #745: ci: Add GitHub token permissions for workflows

2022-07-09 Thread GitBox
varunsh-coder commented on PR #745: URL: https://github.com/apache/maven/pull/745#issuecomment-1179551608 Please let me know if there is anything pending on my side for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-install-plugin] slawekjaranowski commented on a diff in pull request #32: Streamline the plugin

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-install-plugin/pull/32#discussion_r917258610 ## src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java: ## @@ -158,48 +165,36 @@ @Parameter( property = "localRepositoryPath" )

[GitHub] [maven-install-plugin] slawekjaranowski commented on a diff in pull request #32: Streamline the plugin

2022-07-09 Thread GitBox
slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-install-plugin/pull/32#discussion_r917258353 ## src/main/java/org/apache/maven/plugins/install/InstallMojo.java: ## @@ -153,31 +163,90 @@ private boolean allProjectsMarked() return

[jira] [Updated] (MPIR-407) Provide a way to map license names

2022-07-09 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPIR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPIR-407: --- Description: add {{licenseMappings}} parameter: {code:xml}

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564563#comment-17564563 ] ASF GitHub Bot commented on MNG-7353: - hboutemy commented on code in PR #757: URL:

[GitHub] [maven] hboutemy commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
hboutemy commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917251268 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564559#comment-17564559 ] ASF GitHub Bot commented on MNG-7353: - michael-o commented on code in PR #757: URL:

[GitHub] [maven] michael-o commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
michael-o commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917248360 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564554#comment-17564554 ] ASF GitHub Bot commented on MNG-7353: - hboutemy commented on code in PR #757: URL:

[GitHub] [maven] hboutemy commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
hboutemy commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917241749 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564553#comment-17564553 ] ASF GitHub Bot commented on MNG-7353: - hboutemy commented on code in PR #757: URL:

[jira] [Commented] (MNG-5091) Add option to fail build if WARNING's appear in POM

2022-07-09 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564551#comment-17564551 ] Robert Scholte commented on MNG-5091: - [~astubbs] that means you either need to update those groovy

[GitHub] [maven] hboutemy commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
hboutemy commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917239154 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564548#comment-17564548 ] ASF GitHub Bot commented on MNG-7353: - michael-o commented on code in PR #757: URL:

[GitHub] [maven] michael-o commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-09 Thread GitBox
michael-o commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r917237430 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-5091) Add option to fail build if WARNING's appear in POM

2022-07-09 Thread Antony Stubbs (Jira)
[ https://issues.apache.org/jira/browse/MNG-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564540#comment-17564540 ] Antony Stubbs commented on MNG-5091: FYI the GMaven workaround fails on Java 18 with: 

[jira] [Updated] (MNG-7510) Enhance AbstractMavenLifecycleParticipant to watch for buildProject events

2022-07-09 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoph Läubrich updated MNG-7510: Description: Currently Tycho injects some dependencies into the maven model at a very early

[jira] [Created] (MNG-7510) Enhance AbstractMavenLifecycleParticipant to watch for buildProject events

2022-07-09 Thread Jira
Christoph Läubrich created MNG-7510: --- Summary: Enhance AbstractMavenLifecycleParticipant to watch for buildProject events Key: MNG-7510 URL: https://issues.apache.org/jira/browse/MNG-7510 Project: