[GitHub] [maven-shade-plugin] gnodet commented on pull request #149: [MSHADE-419] createDependencyReducedPom should not replace original pom when shadedArtifactAttached

2022-10-22 Thread GitBox
gnodet commented on PR #149: URL: https://github.com/apache/maven-shade-plugin/pull/149#issuecomment-1287937197 The problem seems to have been fixed in 3.4.1 according to #162 which seems to pass on master. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (MPOM-352) Remove managed dependency on deprecated plexus-component-annotations

2022-10-22 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MPOM-352: Summary: Remove managed dependency on deprecated plexus-component-annotations Key: MPOM-352 URL: https://issues.apache.org/jira/browse/MPOM-352 Project: Maven POMs

[jira] [Created] (MPOM-351) Upgrade plexus-utils to 3.4.2

2022-10-22 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MPOM-351: Summary: Upgrade plexus-utils to 3.4.2 Key: MPOM-351 URL: https://issues.apache.org/jira/browse/MPOM-351 Project: Maven POMs Issue Type: Dependency upgrade

[jira] [Updated] (MPOM-350) Raise JDK requirement to 1.8

2022-10-22 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MPOM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MPOM-350: - Fix Version/s: MAVEN-38 > Raise JDK requirement to 1.8 > > >

[GitHub] [maven-ear-plugin] pzygielo commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
pzygielo commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287922492 One module that gets repacked, instead being taken as-is, differs in following way for several entries, here just shown for MANIFEST.MF: \- is entry from original module

[jira] [Updated] (MPOM-350) Raise JDK requirement to 1.8

2022-10-22 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-350: -- Component/s: maven > Raise JDK requirement to 1.8 > > >

[jira] [Comment Edited] (MNG-7577) Ability to activate profile based on multiple property values

2022-10-22 Thread Garret Wilson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622691#comment-17622691 ] Garret Wilson edited comment on MNG-7577 at 10/22/22 8:56 PM: -- Oops, looks

[jira] [Commented] (MNG-7577) Ability to activate profile based on multiple property values

2022-10-22 Thread Garret Wilson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622691#comment-17622691 ] Garret Wilson commented on MNG-7577: Oops, looks like this is a duplicate (MNG-3328) … from _four_

[jira] [Created] (MNG-7577) Ability to activate profile based on multiple property values

2022-10-22 Thread Garret Wilson (Jira)
Garret Wilson created MNG-7577: -- Summary: Ability to activate profile based on multiple property values Key: MNG-7577 URL: https://issues.apache.org/jira/browse/MNG-7577 Project: Maven Issue

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [4.x] Support for the new maven4 api

2022-10-22 Thread GitBox
gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1001740948 ## maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/MojoAnnotationsScanner.java: ## @@ -37,13 +37,21

[GitHub] [maven-parent] gnodet opened a new pull request, #83: [MPOM-350] Raise JDK requirement to 1.8

2022-10-22 Thread GitBox
gnodet opened a new pull request, #83: URL: https://github.com/apache/maven-parent/pull/83 JIRA issue: https://issues.apache.org/jira/browse/MPOM-350 Raise JDK mimimum requirements to 1.8 Discussion at: https://lists.apache.org/thread/ksqgjw7v3rbzw7pq2pvv8xov38799yok --

[jira] [Created] (MPOM-350) Raise JDK requirement to 1.8

2022-10-22 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MPOM-350: Summary: Raise JDK requirement to 1.8 Key: MPOM-350 URL: https://issues.apache.org/jira/browse/MPOM-350 Project: Maven POMs Issue Type: Task

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622686#comment-17622686 ] ASF GitHub Bot commented on MNG-7559: - sultan opened a new pull request, #331: URL:

[GitHub] [maven-site] sultan opened a new pull request, #331: [MNG-7559] Fix versions comparison

2022-10-22 Thread GitBox
sultan opened a new pull request, #331: URL: https://github.com/apache/maven-site/pull/331 Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559 intention is: * milestone < preview < rc * .RC1 < -RC2 * -pfd < final, ga, release -- This is an automated message

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622685#comment-17622685 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #840: URL:

[GitHub] [maven] gnodet commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-22 Thread GitBox
gnodet commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1287888704 > I think I ran into a chicken-egg type of problem. > > * I would like to have the project.topdir available as a variable that can be used in the pom.xml to pin point things. This

[jira] [Commented] (MSHARED-1149) DependencyClassFileVisitor should use Logger

2022-10-22 Thread Bartlomiej (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622684#comment-17622684 ] Bartlomiej commented on MSHARED-1149: - Hi, I created

[GitHub] [maven-dependency-analyzer] Koziolek opened a new pull request, #71: [MSHARED-1149] – Replace System.out by logger

2022-10-22 Thread GitBox
Koziolek opened a new pull request, #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71 Replace usage of `System.out.println` by Logger from slf4j. Introducing slf4j in similar way like other MSHARED projects like maven-filtering - [x] I hereby declare this

[jira] [Commented] (MRESOLVER-279) Simplify and improve trusted checksum sources

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622678#comment-17622678 ] ASF GitHub Bot commented on MRESOLVER-279: -- gnodet commented on code in PR #203: URL:

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #203: [MRESOLVER-279] Simplify and improve trusted checksum sources

2022-10-22 Thread GitBox
gnodet commented on code in PR #203: URL: https://github.com/apache/maven-resolver/pull/203#discussion_r1002547214 ## maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/checksum/FileTrustedChecksumsSourceTestSupport.java: ## @@ -51,58 +56,79 @@ private

[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
slawekjaranowski commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287861226 In 07a84983809b4ec416b1330412bbd83844a88a44 I was replaced a way how items are changed in attached modules before it whole module was unpacked to temporary location, one

[GitHub] [maven-ear-plugin] pzygielo commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
pzygielo commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287857868 I have tested m-ear-p:3.3.0 + revert 07a84983809b4ec416b1330412bbd83844a88a44 and it's also fine and does not cause the deploy problem. -- This is an automated message from the

[GitHub] [maven-ear-plugin] pzygielo commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
pzygielo commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287856632 > can be connected with JDK versions and build Using the same JDK (Temurin 11.0.16.1) here and there. -- This is an automated message from the Apache Git Service.

[GitHub] [maven-ear-plugin] pzygielo commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
pzygielo commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287855504 > Also - I have problems to reproduce it locally on regular linux box. It fails only on GitHub Actions node. To clarify: I have problem **to build** reproducible archive

[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
slawekjaranowski commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287854266 > Hi @slawekjaranowski, thanks for checking this issue. > > Currently I have bisected it to

[GitHub] [maven-ear-plugin] pzygielo commented on pull request #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
pzygielo commented on PR #80: URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287852135 Hi @slawekjaranowski, thanks for checking this issue. Currently I have bisected it to 07a84983809b4ec416b1330412bbd83844a88a44. I have _"reproducer"_ but it is with

[jira] [Commented] (MEAR-322) Exception while deploying the app: java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor

2022-10-22 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622666#comment-17622666 ] Slawomir Jaranowski commented on MEAR-322: -- I was tried to reproduce issue ... but I can not

[jira] [Updated] (MEAR-322) Exception while deploying the app: java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor

2022-10-22 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zygielo updated MEAR-322: --- Description: After m-ear-p upgrade from 3.2.0 to 3.3.0, this {quote}Exception while deploying the app:

[GitHub] [maven-ear-plugin] slawekjaranowski opened a new pull request, #80: [MEAR-322] Try to reproduce issue

2022-10-22 Thread GitBox
slawekjaranowski opened a new pull request, #80: URL: https://github.com/apache/maven-ear-plugin/pull/80 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MEAR)

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622664#comment-17622664 ] ASF GitHub Bot commented on MNG-7559: - sultan commented on code in PR #845: URL:

[GitHub] [maven] sultan commented on a diff in pull request #845: [MNG-7559] Fix versions comparison

2022-10-22 Thread GitBox
sultan commented on code in PR #845: URL: https://github.com/apache/maven/pull/845#discussion_r1002523615 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -354,15 +354,15 @@ public String toString() implements Item

[jira] [Commented] (MRESOLVER-274) Introduce Remote Repository Filter feature

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622662#comment-17622662 ] ASF GitHub Bot commented on MRESOLVER-274: -- gnodet commented on code in PR #197: URL:

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #197: [MRESOLVER-274] Remote Repository Filter

2022-10-22 Thread GitBox
gnodet commented on code in PR #197: URL: https://github.com/apache/maven-resolver/pull/197#discussion_r1002523689 ## src/site/markdown/remote-repository-filtering.md: ## @@ -0,0 +1,70 @@ +# Remote Repository Filtering + + +A new Maven Resolver feature that allows filtering of

[GitHub] [maven] sultan commented on a diff in pull request #845: Fix versions comparison

2022-10-22 Thread GitBox
sultan commented on code in PR #845: URL: https://github.com/apache/maven/pull/845#discussion_r1002523615 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -354,15 +354,15 @@ public String toString() implements Item

[GitHub] [maven] sultan commented on a diff in pull request #845: Fix versions comparison

2022-10-22 Thread GitBox
sultan commented on code in PR #845: URL: https://github.com/apache/maven/pull/845#discussion_r1002523419 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -354,15 +354,15 @@ public String toString() implements Item

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-10-22 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622660#comment-17622660 ] Gwénaël Ruelland commented on MNG-7559: --- !image-2022-10-22-18-22-11-591.png! > ComparableVersion vs

[jira] [Updated] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-10-22 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwénaël Ruelland updated MNG-7559: -- Attachment: image-2022-10-22-18-22-11-591.png > ComparableVersion vs versions with custom

[GitHub] [maven] sultan commented on a diff in pull request #845: Fix versions comparison

2022-10-22 Thread GitBox
sultan commented on code in PR #845: URL: https://github.com/apache/maven/pull/845#discussion_r1002518719 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -354,15 +354,15 @@ public String toString() implements Item

[GitHub] [maven] michael-o commented on a diff in pull request #845: Fix versions comparison

2022-10-22 Thread GitBox
michael-o commented on code in PR #845: URL: https://github.com/apache/maven/pull/845#discussion_r1002518336 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -354,15 +354,15 @@ public String toString() implements Item

[GitHub] [maven-install-plugin] dependabot[bot] commented on pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

2022-10-22 Thread GitBox
dependabot[bot] commented on PR #33: URL: https://github.com/apache/maven-install-plugin/pull/33#issuecomment-1287838504 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-install-plugin] slawekjaranowski closed pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

2022-10-22 Thread GitBox
slawekjaranowski closed pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0 URL: https://github.com/apache/maven-install-plugin/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-install-plugin] dependabot[bot] commented on pull request #34: Bump slf4jVersion from 1.7.5 to 1.7.32

2022-10-22 Thread GitBox
dependabot[bot] commented on PR #34: URL: https://github.com/apache/maven-install-plugin/pull/34#issuecomment-1287838416 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-install-plugin] slawekjaranowski closed pull request #34: Bump slf4jVersion from 1.7.5 to 1.7.32

2022-10-22 Thread GitBox
slawekjaranowski closed pull request #34: Bump slf4jVersion from 1.7.5 to 1.7.32 URL: https://github.com/apache/maven-install-plugin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] sultan opened a new pull request, #845: Fix versions comparison

2022-10-22 Thread GitBox
sultan opened a new pull request, #845: URL: https://github.com/apache/maven/pull/845 Fix versions comparison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622613#comment-17622613 ] ASF GitHub Bot commented on MNG-7038: - nielsbasjes commented on PR #840: URL:

[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-22 Thread GitBox
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1287770947 I think I ran into a chicken-egg type of problem. - I would like to have the project.topdir available as a variable that can be used in the pom.xml to pin point things. This implies it

[jira] [Updated] (MEAR-322) Exception while deploying the app: java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor

2022-10-22 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zygielo updated MEAR-322: --- Description: After m-ear-p upgrade from 3.2.0 to 3.3.0, this {quote}Exception while deploying the app:

[jira] [Created] (MEAR-322) Exception while deploying the app: java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor

2022-10-22 Thread Piotr Zygielo (Jira)
Piotr Zygielo created MEAR-322: -- Summary: Exception while deploying the app: java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor Key: MEAR-322 URL:

[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #38: Fix installAtEnd when module does not use m-install-p

2022-10-22 Thread GitBox
slawekjaranowski commented on PR #38: URL: https://github.com/apache/maven-install-plugin/pull/38#issuecomment-1287757533 @cstamas please look - I added more cases in IT test and corresponding implementation -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] gnodet opened a new pull request, #162: [MSHADE-419] Add an IT for MSHADE-419

2022-10-22 Thread GitBox
gnodet opened a new pull request, #162: URL: https://github.com/apache/maven-shade-plugin/pull/162 JIRA issue: https://issues.apache.org/jira/browse/MSHADE-419 Shade plugin causes pom to be created without compile dependencies IT extracted from #149 ===

[jira] [Created] (MINSTALL-179) installAtEnd when module does not use m-install-p

2022-10-22 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINSTALL-179: Summary: installAtEnd when module does not use m-install-p Key: MINSTALL-179 URL: https://issues.apache.org/jira/browse/MINSTALL-179 Project: Maven

[jira] [Closed] (MINSTALL-102) installAtEnd does not install artifacts for multi-module with packaging maven-archetype

2022-10-22 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINSTALL-102. Fix Version/s: 3.0.0 Resolution: Fixed Fixed by MINSTALL-115 >

[GitHub] [maven-parent] gnodet commented on pull request #80: Apply spotless to check/reformat code

2022-10-22 Thread GitBox
gnodet commented on PR #80: URL: https://github.com/apache/maven-parent/pull/80#issuecomment-1287697958 Superseded by #82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-parent] gnodet closed pull request #80: Apply spotless to check/reformat code

2022-10-22 Thread GitBox
gnodet closed pull request #80: Apply spotless to check/reformat code URL: https://github.com/apache/maven-parent/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-parent] gnodet opened a new pull request, #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-22 Thread GitBox
gnodet opened a new pull request, #82: URL: https://github.com/apache/maven-parent/pull/82 JIRA issue: https://issues.apache.org/jira/browse/MPOM-349 - [MPOM-349] Apply spotless to check/reformat code + poms - [MPOM-349] Reformat poms Discussed on *

[jira] [Created] (MPOM-349) Enable spotless for autoformatting

2022-10-22 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MPOM-349: Summary: Enable spotless for autoformatting Key: MPOM-349 URL: https://issues.apache.org/jira/browse/MPOM-349 Project: Maven POMs Issue Type: Task

[jira] [Commented] (MCOMPILER-480) Running om macOS Monterey produces an error

2022-10-22 Thread Vasiliy Kudriavtsev (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622590#comment-17622590 ] Vasiliy Kudriavtsev commented on MCOMPILER-480: --- I am getting the same problem, but on