[jira] [Commented] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813083#comment-17813083 ] ASF GitHub Bot commented on MWRAPPER-123: - rmannibucau commented on code in PR #117: URL:

Re: [PR] [MWRAPPER-123] replace bogus printf %d with constant 104 for now [maven-wrapper]

2024-01-31 Thread via GitHub
rmannibucau commented on code in PR #117: URL: https://github.com/apache/maven-wrapper/pull/117#discussion_r1473937034 ## maven-wrapper-distribution/src/resources/only-mvnw: ## @@ -72,7 +72,9 @@ set_java_home() { hash_string() { str="${1:-}" h=0 while [ -n "$str" ]; do -

[jira] [Commented] (MWRAPPER-104) Add prettier config for shell scripts

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813082#comment-17813082 ] ASF GitHub Bot commented on MWRAPPER-104: - bmarwell commented on PR #84: URL:

Re: [PR] [MWRAPPER-104] add prettier config for shell [maven-wrapper]

2024-01-31 Thread via GitHub
bmarwell commented on PR #84: URL: https://github.com/apache/maven-wrapper/pull/84#issuecomment-1920693472 > I see that we should first update parent to the latest in order to build under JDK 21 Was about to say the same. Yup. There are a couple more PRs we should put into the next

[jira] [Commented] (MWRAPPER-104) Add prettier config for shell scripts

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813080#comment-17813080 ] ASF GitHub Bot commented on MWRAPPER-104: - slawekjaranowski commented on PR #84: URL:

Re: [PR] [MWRAPPER-104] add prettier config for shell [maven-wrapper]

2024-01-31 Thread via GitHub
slawekjaranowski commented on PR #84: URL: https://github.com/apache/maven-wrapper/pull/84#issuecomment-1920688534 @bmarwell thanks ... I did forgot it  I see that we should first update parent to the latest in order to build under JDK 21 -- This is an automated message from

[jira] [Commented] (MWRAPPER-104) Add prettier config for shell scripts

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813076#comment-17813076 ] ASF GitHub Bot commented on MWRAPPER-104: - bmarwell commented on PR #84: URL:

Re: [PR] [MWRAPPER-104] add prettier config for shell [maven-wrapper]

2024-01-31 Thread via GitHub
bmarwell commented on PR #84: URL: https://github.com/apache/maven-wrapper/pull/84#issuecomment-1920679887 @slachiewicz @slawekjaranowski rebased and added a commit which applies the prettier config -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813072#comment-17813072 ] ASF GitHub Bot commented on MWRAPPER-123: - bmarwell opened a new pull request, #117: URL:

[PR] [MWRAPPER-123] replace bogus printf %d with constant 104 for now [maven-wrapper]

2024-01-31 Thread via GitHub
bmarwell opened a new pull request, #117: URL: https://github.com/apache/maven-wrapper/pull/117 Old behaviour was to always use h * 331 + 104 (because on most shells, `printf %d "'%str"` always evaluated to 104). For now, use this constant as this does not change behavour. It

[jira] [Created] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation

2024-01-31 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MWRAPPER-123: - Summary: only-mvnw fails on AIX' ksh implementation Key: MWRAPPER-123 URL: https://issues.apache.org/jira/browse/MWRAPPER-123 Project: Maven Wrapper

[jira] [Updated] (MNG-8039) DefaultProjectBuilder should not change given artifact

2024-01-31 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-8039: - Description: In {{org.apache.maven.project.DefaultProjectBuilder}} we have a code:

[jira] [Created] (MNG-8039) DefaultProjectBuilder should not change given artifact

2024-01-31 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-8039: Summary: DefaultProjectBuilder should not change given artifact Key: MNG-8039 URL: https://issues.apache.org/jira/browse/MNG-8039 Project: Maven

[jira] [Comment Edited] (MNG-7906) Dependency Management import does not work the "maven way"

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813051#comment-17813051 ] Herve Boutemy edited comment on MNG-7906 at 2/1/24 6:25 AM: {quote}So I think

[jira] [Commented] (MNG-7906) Dependency Management import does not work the "maven way"

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813051#comment-17813051 ] Herve Boutemy commented on MNG-7906: {quote}So I think the first step would be to add a WARNING when

[PR] Bump org.apache.commons:commons-compress from 1.23.0 to 1.25.0 [maven-shade-plugin]

2024-01-31 Thread via GitHub
dependabot[bot] opened a new pull request, #214: URL: https://github.com/apache/maven-shade-plugin/pull/214 Bumps org.apache.commons:commons-compress from 1.23.0 to 1.25.0. [![Dependabot compatibility

[jira] [Updated] (MSHADE-468) add plugin system requirements history section

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSHADE-468: - Fix Version/s: next-release (was: 3.5.1) > add plugin system

[jira] [Commented] (MASSEMBLY-1016) clarify and fix plugin system requirements history

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813034#comment-17813034 ] ASF GitHub Bot commented on MASSEMBLY-1016: --- hboutemy opened a new pull request, #181: URL:

[jira] [Created] (MASSEMBLY-1016) clarify and fix plugin system requirements history

2024-01-31 Thread Herve Boutemy (Jira)
Herve Boutemy created MASSEMBLY-1016: Summary: clarify and fix plugin system requirements history Key: MASSEMBLY-1016 URL: https://issues.apache.org/jira/browse/MASSEMBLY-1016 Project: Maven

[jira] [Commented] (MSHADE-468) add plugin system requirements history section

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813027#comment-17813027 ] ASF GitHub Bot commented on MSHADE-468: --- hboutemy opened a new pull request, #213: URL:

[jira] [Created] (MSHADE-468) add plugin system requirements history section

2024-01-31 Thread Herve Boutemy (Jira)
Herve Boutemy created MSHADE-468: Summary: add plugin system requirements history section Key: MSHADE-468 URL: https://issues.apache.org/jira/browse/MSHADE-468 Project: Maven Shade Plugin

[jira] [Updated] (MSHADE-464) Maven 3.6.3 as minimum requirements

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSHADE-464: - Affects Version/s: 3.5.1 > Maven 3.6.3 as minimum requirements >

[jira] [Commented] (MNG-8026) Maven should define from ground up scopes used with Resolver

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812965#comment-17812965 ] ASF GitHub Bot commented on MNG-8026: - gnodet commented on PR #1391: URL:

Re: [PR] [MNG-8026] Maven drives regarding scopes [maven]

2024-01-31 Thread via GitHub
gnodet commented on PR #1391: URL: https://github.com/apache/maven/pull/1391#issuecomment-1920108675 @cstamas I've removed `BuildPath` which will be provided by #1378 (inside `DependencyResolverResult`) and renamed `BuildPathScope` to `PathScope` to align with the other PR which defines

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812961#comment-17812961 ] ASF GitHub Bot commented on MNG-8015: - gnodet commented on PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-31 Thread via GitHub
gnodet commented on PR #1378: URL: https://github.com/apache/maven/pull/1378#issuecomment-1920102981 @desruisseaux I've pushed a small rework of this PR on top of #1391 on my fork. The squashed and rebased commit can be found at

[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812831#comment-17812831 ] ASF GitHub Bot commented on MSHADE-462: --- hboutemy commented on PR #208: URL:

[jira] [Closed] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHADE-462. Fix Version/s: next-release Resolution: Fixed > 3.5.1 not compatible with 3.4.1: The

[jira] [Assigned] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MSHADE-462: Assignee: Herve Boutemy > 3.5.1 not compatible with 3.4.1: The version cannot be empty >

[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812830#comment-17812830 ] ASF GitHub Bot commented on MSHADE-462: --- hboutemy merged PR #208: URL:

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-31 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1919653757 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-31 Thread via GitHub
hboutemy merged PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 [maven-shade-plugin]

2024-01-31 Thread via GitHub
dependabot[bot] opened a new pull request, #212: URL: https://github.com/apache/maven-shade-plugin/pull/212 Bumps org.apache.commons:commons-compress from 1.23.0 to 1.24.0. [![Dependabot compatibility

[jira] [Closed] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHADE-420. Assignee: Herve Boutemy Resolution: Fixed > Reproducible Builds timestamp issue in some

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812826#comment-17812826 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy merged PR #179: URL:

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-31 Thread via GitHub
hboutemy merged PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812825#comment-17812825 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on PR #93: URL:

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-31 Thread via GitHub
abelsromero commented on PR #93: URL: https://github.com/apache/maven-filtering/pull/93#issuecomment-1919621316 Fixed the formatting, is there a way to run the pipeline without manual intervention? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812809#comment-17812809 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on PR #93: URL:

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-31 Thread via GitHub
abelsromero commented on PR #93: URL: https://github.com/apache/maven-filtering/pull/93#issuecomment-1919531112 Anything else I should be checking? I don't any have anything identified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (MNG-7906) Dependency Management import does not work the "maven way"

2024-01-31 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812637#comment-17812637 ] Tamas Cservenak commented on MNG-7906: -- I have several issues with statements in previous post, but

[jira] [Commented] (MRESOLVER-484) The dependencies properties should be provided by the resolver consumer

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812634#comment-17812634 ] ASF GitHub Bot commented on MRESOLVER-484: -- gnodet merged PR #422: URL:

[jira] [Closed] (MRESOLVER-484) The dependencies properties should be provided by the resolver consumer

2024-01-31 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MRESOLVER-484. - Fix Version/s: 2.0.0 Resolution: Fixed > The dependencies properties should be

Re: [PR] [MRESOLVER-484] The dependencies properties should be provided by the resolver consumer [maven-resolver]

2024-01-31 Thread via GitHub
gnodet merged PR #422: URL: https://github.com/apache/maven-resolver/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-484) The dependencies properties should be provided by the resolver consumer

2024-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812595#comment-17812595 ] ASF GitHub Bot commented on MRESOLVER-484: -- gnodet opened a new pull request, #422: URL:

[PR] [MRESOLVER-484] The dependencies properties should be provided by the resolver consumer [maven-resolver]

2024-01-31 Thread via GitHub
gnodet opened a new pull request, #422: URL: https://github.com/apache/maven-resolver/pull/422 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (MRESOLVER-484) The dependencies properties should be provided by the resolver consumer

2024-01-31 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MRESOLVER-484: -- Summary: The dependencies properties should be provided by the resolver consumer

[jira] [Created] (MRESOLVER-484) The dependency traverser should be the responsibility of the resolver consumer

2024-01-31 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MRESOLVER-484: - Summary: The dependency traverser should be the responsibility of the resolver consumer Key: MRESOLVER-484 URL: https://issues.apache.org/jira/browse/MRESOLVER-484