[jira] [Commented] (MWAR-351) Optional dependency not being included in the WEB-INF/lib folder

2022-10-23 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MWAR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622801#comment-17622801 ] elharo commented on MWAR-351: - This might be working as intended. "When A declares B as an optional dependency

[jira] [Commented] (MDEP-526) copy and copy-dependencies should take latest release version from version range

2022-10-03 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MDEP-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612354#comment-17612354 ] elharo commented on MDEP-526: - I don't think this is a good idea. If the POM ends at 1.4.0-SNAPSHOT then

[jira] [Commented] (MDEP-727) Broken JavaDoc links

2022-10-01 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MDEP-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611868#comment-17611868 ] elharo commented on MDEP-727: - I don't currently see this one > Broken JavaDoc links > >

[jira] [Commented] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows

2022-01-01 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467513#comment-17467513 ] elharo commented on MRELEASE-1066: -- That commit might be a workaround, but I don't think it gets at

[jira] [Commented] (DOXIA-60) Use an external XML Pull parser instead of plexus one

2021-12-31 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467310#comment-17467310 ] elharo commented on DOXIA-60: - Still worth doing one of these days, but I do suggest using something that's in

[jira] [Commented] (MNG-6065) Creating option --fail-on-severity / -fos to support errorless or warningless builds

2019-12-19 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1688#comment-1688 ] elharo commented on MNG-6065: - If off is the default, would that mean the build doesn't fail, not matter what?

[jira] [Commented] (MNG-5652) "supplies"/"provides"/"proffers" concept proposal

2019-12-18 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999020#comment-16999020 ] elharo commented on MNG-5652: - This proposal is interesting but it feels obsolete in a Java 9+ world. Would it

[jira] [Commented] (MNG-6357) Dependency order should be nearest first

2019-12-18 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999016#comment-16999016 ] elharo commented on MNG-6357: - There might be other edge cases where this matters. For instance, imagine

[jira] [Commented] (MNG-5980) DependencyGraphBuilder gives different results depending on the order of dependencies in the pom

2019-12-17 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998120#comment-16998120 ] elharo commented on MNG-5980: - If we don't guarantee an order for transitives, then dependency mediation is

[jira] [Comment Edited] (MNG-5980) DependencyGraphBuilder gives different results depending on the order of dependencies in the pom

2019-12-16 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997477#comment-16997477 ] elharo edited comment on MNG-5980 at 12/16/19 5:34 PM: --- Consider the case where class

[jira] [Comment Edited] (MNG-5980) DependencyGraphBuilder gives different results depending on the order of dependencies in the pom

2019-12-16 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997477#comment-16997477 ] elharo edited comment on MNG-5980 at 12/16/19 5:31 PM: --- Consider the case where class

[jira] [Commented] (MNG-5980) DependencyGraphBuilder gives different results depending on the order of dependencies in the pom

2019-12-16 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997477#comment-16997477 ] elharo commented on MNG-5980: - Consider the case where class com.example.Foo is found in A.jar and B.jar, both

[jira] [Commented] (MNG-5980) DependencyGraphBuilder gives different results depending on the order of dependencies in the pom

2019-12-16 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997292#comment-16997292 ] elharo commented on MNG-5980: - If we don't document the order dependency, that would be a good bug against

[jira] [Commented] (MENFORCER-243) Create rule to check versions of dependencies

2019-12-15 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996884#comment-16996884 ] elharo commented on MENFORCER-243: -- so I can remind myself of the issues I think should be closed. If

[jira] [Commented] (MNG-6036) Allow proper namespace usage for pom.xml

2019-12-15 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996774#comment-16996774 ] elharo commented on MNG-6036: - I'm not sure I know enough about the Maven code base to say for sure at a code

[jira] [Commented] (MNG-6036) Allow proper namespace usage for pom.xml

2019-12-15 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996767#comment-16996767 ] elharo commented on MNG-6036: - For the same reason that a compiler that allowed Java files that ignored the

[jira] [Commented] (MENFORCER-288) RequireJavaVersion: Support new Java 9 versioning schema even for older Java versions

2019-12-15 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996683#comment-16996683 ] elharo commented on MENFORCER-288: -- I'm not sure this is a good idea. I'd prefer maven not to