[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-13 Thread via GitHub
gnodet commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1325372519 ## maven-core/src/main/java/org/apache/maven/internal/aether/LoggingRepositoryListener.java: ## @@ -63,48 +63,47 @@ public void metadataResolved(RepositoryEvent event) {

[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-11 Thread via GitHub
gnodet commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1321137864 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,16 +149,15 @@ private ClassRealm createRealm( List

[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-03 Thread via GitHub
gnodet commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1314461642 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List