gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1714387479
@elharo I've rewritten the `dag` related classes with non public classes.
The other copyrighted class originate from within the ASF and the last one was
written by me.
--
This is an
gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1707384017
> @elharo we can't refactor the `Os` class in a different PR unless we merge
it first, as the PR removes the plexus-utils dependency... I'll refactor the
class completely.
Done.
gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1707329632
@elharo we can't refactor the `Os` class in a different PR unless we merge
it first, as the PR removes the plexus-utils dependency... I'll refactor the
class completely.
--
This is an
gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1693347546
@CrazyHZM I've seen the `Os` stuff copied multiple times. Could the class
be copied into maven-core and reused instead of duplicating this bits 3/4 times
?
--
This is an automated
gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1692789865
> > @elharo I don't really see the need to spend much time on rewriting code
copied from a utility class. The DefaultWagonManager is part of maven-compat,
so deprecated and not really
gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1691906581
@elharo I don't really see the need to spend much time on rewriting code
copied from a utility class. The DefaultWagonManager is part of maven-compat,
so deprecated and not really
