[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-04-04 Thread GitBox
laeubi commented on PR #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1087632670 @cstamas I have now fetched your test as well into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-29 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1081853247 > Is there an IT for this? If there would be, I'd check this and add for 3.8.6+. [The jira](https://issues.apache.org/jira/browse/MNG-7432) has a link [to a

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-29 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1081805771 > Seems like a straightforward fix. If I understand correctly, one or both of Exactly! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-28 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1081326893 @michael-o just wondering inf we can proceed here? If its fine for 3.8.x I'll prepare PRs for 2.9.x and 4.x as well ... I also wonder if it would be suitable to release a 3.8.6

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-21 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1074208880 > I suppose > >

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-20 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1073188594 > I think that writing "restoring the old behavior from Maven 3.8.4" should have made it clear that I already knew that. Sure but if you simply "do not really care" the

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-20 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1073175696 > I do not really know or care what a workspace reader is. I just want my builds to work again. You can use maven 3.8.4 in the meantime. -- This is an automated message

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-19 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1073173726 > This fixes the problem for me but will instantly fail once another workspace reader is registered again ;-) -- This is an automated message from the Apache Git Service.

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-18 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1072265226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-18 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1072344466 Not sure, at least this does restores the previous behavior. The problem is caused by the following (we have noticed something similar in Tycho as well): 1.

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-18 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1072265226 @michael-o do you like to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go