[GitHub] [maven] michael-o commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments

2023-05-05 Thread via GitHub
michael-o commented on code in PR #1062: URL: https://github.com/apache/maven/pull/1062#discussion_r1185874264 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -31,16 +31,8 @@ import java.nio.file.Files; import java.nio.file.Path; import

[GitHub] [maven] michael-o commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments

2023-05-05 Thread via GitHub
michael-o commented on code in PR #1062: URL: https://github.com/apache/maven/pull/1062#discussion_r1185873548 ## maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java: ## @@ -552,6 +553,38 @@ public void findRootProjectWithAttribute() {

[GitHub] [maven] michael-o commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments

2023-05-05 Thread via GitHub
michael-o commented on code in PR #1062: URL: https://github.com/apache/maven/pull/1062#discussion_r1185850625 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -31,16 +31,8 @@ import java.nio.file.Files; import java.nio.file.Path; import

[GitHub] [maven] michael-o commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments

2023-04-15 Thread via GitHub
michael-o commented on code in PR #1062: URL: https://github.com/apache/maven/pull/1062#discussion_r1167475281 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,51 @@ public interface MavenExecutionRequest { /** *

[GitHub] [maven] michael-o commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments

2023-04-15 Thread via GitHub
michael-o commented on code in PR #1062: URL: https://github.com/apache/maven/pull/1062#discussion_r1167473448 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,51 @@ public interface MavenExecutionRequest { /** *