[GitHub] [maven] mthmulders commented on a change in pull request #351: Refactor MavenCli.populateRequest

2020-09-19 Thread GitBox
mthmulders commented on a change in pull request #351: URL: https://github.com/apache/maven/pull/351#discussion_r491484783 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -1331,103 +1335,172 @@ private MavenExecutionRequest populateRequest(

[GitHub] [maven] mthmulders commented on a change in pull request #351: Refactor MavenCli.populateRequest

2020-05-24 Thread GitBox
mthmulders commented on a change in pull request #351: URL: https://github.com/apache/maven/pull/351#discussion_r429637535 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -1318,103 +1322,165 @@ private MavenExecutionRequest populateRequest(

[GitHub] [maven] mthmulders commented on a change in pull request #351: Refactor MavenCli.populateRequest

2020-05-24 Thread GitBox
mthmulders commented on a change in pull request #351: URL: https://github.com/apache/maven/pull/351#discussion_r429637471 ## File path: maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java ## @@ -687,6 +687,11 @@ public MavenExecutionRequest

[GitHub] [maven] mthmulders commented on a change in pull request #351: Refactor MavenCli.populateRequest

2020-05-24 Thread GitBox
mthmulders commented on a change in pull request #351: URL: https://github.com/apache/maven/pull/351#discussion_r429637493 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -19,6 +19,7 @@ * under the License. */ +import