bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-591958125
@elharo this is already merged and on maven central.
Also, everything you mentioned will be removed in the
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-570575862
@eolivelli blue light spotted :)
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569611427
> we need to give signal to user that classpath is deprecated
Yes I agree on that. That's definitely
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569537715
For users? No. This is really interesting for devs. Imagine you do not
upgrade checkstyle (yet) for various
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569505877
Thanks and agreed about the tests. We may need to refibe existing tests
if/when we use checkstyle 8.24 or newer.
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569500345
@romani @struberg @rfscholte
Reworked to call the method if it is available by catching a
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-568699000
It's really not easy to spot breaking changes from a maven perspective. When
I recently updated checkstyle, my xml
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-568369364
This plugin is using checkstyle 8.19 and will probably not update beyond
8.23, because 8.24 introduced breaking
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-565334303
The method `private List getFilesToProcess( CheckstyleExecutorRequest
request )` also has a unused variable
