[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values

2022-12-02 Thread GitBox
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1335567397 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values

2022-11-25 Thread GitBox
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1327514243 > maybe we should simply change `showWarnings` to `true` per default as described in MCOMPILER-457? - Doing so in apache/maven-compiler-plugin#157 - What about

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values

2022-11-24 Thread GitBox
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326375665 Is there any change requested here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values

2022-11-03 Thread GitBox
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1302396964 I didn't want to change currently implemented logic. MCOMPILER-457 happened to me as well. Caused some... confusion. For future me, that does not remember that,

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values

2022-11-03 Thread GitBox
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1301766219 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go