[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-29 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059280780 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireJavaVersion.java: ## @@ -89,30 +88,36 @@ void settingsTheJavaVersionAsNormalizedVersi

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-29 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059280557 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireJavaVendor.java: ## @@ -56,25 +54,33 @@ public void matchingInclude() throws EnforcerR