[GitHub] [maven-fluido-skin] michael-o commented on pull request #51: [MSKINS-226] Add custom option to enable/disable AnchorJS along with …

2023-04-24 Thread via GitHub
michael-o commented on PR #51: URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1520370123 @hboutemy I will first apply the AnchorJS upgrade separately. As said, there is no way to explicitly disable this just like with other options and the inconsistency between

[GitHub] [maven-fluido-skin] michael-o commented on pull request #51: [MSKINS-226] Add custom option to enable/disable AnchorJS along with …

2023-04-15 Thread via GitHub
michael-o commented on PR #51: URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1509885293 > If we have working Doxia, why we need also js generated? Doxia does not generate any IDs by default, you have to request it in the markup. If Doxia would generate them by

[GitHub] [maven-fluido-skin] michael-o commented on pull request #51: [MSKINS-226] Add custom option to enable/disable AnchorJS along with …

2023-04-15 Thread via GitHub
michael-o commented on PR #51: URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1509860698 > > having an option to disable, why not, but please enable by default: what is the issue with these (visual) anchors added in https://issues.apache.org/jira/browse/MSKINS-167?

[GitHub] [maven-fluido-skin] michael-o commented on pull request #51: [MSKINS-226] Add custom option to enable/disable AnchorJS along with …

2023-04-10 Thread via GitHub
michael-o commented on PR #51: URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1501602257 > having an option to disable, why not, but please enable by default: what is the issue with these (visual) anchors added in https://issues.apache.org/jira/browse/MSKINS-167?