slawekjaranowski commented on code in PR #176: URL: https://github.com/apache/maven-integration-testing/pull/176#discussion_r972024803
########## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3038TransitiveDepManVersionTest.java: ########## @@ -22,14 +22,19 @@ import java.io.File; import java.io.IOException; -import org.apache.maven.it.util.ResourceExtractor; +import org.apache.maven.shared.verifier.VerificationException; +import org.apache.maven.shared.verifier.Verifier; +import org.apache.maven.shared.verifier.util.ResourceExtractor; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; /** * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-3038";>MNG-3038</a> * * @author Joakim Erdfelt * */ +@Disabled( "cannot reproduce" ) Review Comment: I suppose that now is working with junit 4, maybe TODO remarks to verify later ########## pom.xml: ########## @@ -82,7 +82,12 @@ under the License. <dependency> <groupId>org.apache.maven.shared</groupId> <artifactId>maven-verifier</artifactId> - <version>1.8.0</version> + <version>2.0.0-SNAPSHOT</version> Review Comment: I prefer a some of release version, even milestone In other case tests can be unstable and investigation can be more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
