[GitHub] [maven-mvnd] ppalaga commented on pull request #717: Try native image then fallback to pure java version

2023-01-10 Thread GitBox
ppalaga commented on PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#issuecomment-1378032665 I'd dare to vote against making `mvnd` to point at a shell script by default. It is adding indirection and performance penalties on major platforms for which we have proper native

[GitHub] [maven-mvnd] ppalaga commented on pull request #717: Try native image then fallback to pure java version

2022-10-21 Thread GitBox
ppalaga commented on PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#issuecomment-1287247495 I think both proposals boil down to having a reusable piece of shell/PowerShell for linking/moving `mvnd` to the right file. I like that idea. @gnodet variant would also be able to

[GitHub] [maven-mvnd] ppalaga commented on pull request #717: Try native image then fallback to pure java version

2022-10-21 Thread GitBox
ppalaga commented on PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#issuecomment-1286855833 These changes seem to be addressing what I'd call install time concerns. Whether the given build of mvnd native executable can run on the current machine can be decided once at install