[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-09-02 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843673856 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r844060718 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843928400 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843882391 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843879478 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843876935 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843874851 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843730700 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )

[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-06 Thread GitBox
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843673856 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove )