[GitHub] [maven-shared-utils] roxspring commented on pull request #28: [MSHARED-884] - Don't always overwrite filtered resources

2020-05-26 Thread GitBox
roxspring commented on pull request #28: URL: https://github.com/apache/maven-shared-utils/pull/28#issuecomment-634302632 > Does it actually make sense to introduce a threshold? E.g., > 1 MB? You're suggesting that we apply the new logic only to input >1MB and for smaller files we

[GitHub] [maven-shared-utils] roxspring commented on pull request #28: [MSHARED-884] - Don't always overwrite filtered resources

2020-05-15 Thread GitBox
roxspring commented on pull request #28: URL: https://github.com/apache/maven-shared-utils/pull/28#issuecomment-629534673 @michael-o I think I've fixed the Buffer code as you requested - I'd be grateful of another review!

[GitHub] [maven-shared-utils] roxspring commented on pull request #28: [MSHARED-884] - Don't always overwrite filtered resources

2020-05-03 Thread GitBox
roxspring commented on pull request #28: URL: https://github.com/apache/maven-shared-utils/pull/28#issuecomment-623106474 Yes. That’s the point, as discussed in the jira issue and dev mailing lists. Unnecessarily modifying the file when the filter content hasn’t changed can lead to