Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521377284
@wilkinsona Thx for contributing!
This is an auto
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521304306
@wilkinsona
thx, the build is in progress.
Th
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521220085
@wilkinsona
The cache has `ConcurrentHashMap`.
If you agree, this Map can be turned to the pure `HashMap`.
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521168378
@wilkinsona
There is checkstyle errors. You can see this if you build the project
locally `mvn install`.
``
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521164814
@wilkinsona
Can you please add unit tests and fully core your cache?
I want to keep the code coverage on cur
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521163824
The build is currently running
https://builds.apache.org/job/maven-box/job/maven-surefire/job/SUREFIRE-1679/
--
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from
causing pollution
URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521147055
@wilkinsona
Thx, LGTM
I will make ASF branch and trigger Jenkins.
-
